RE: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
> -Original Message- > From: Rob Herring > Sent: Monday, February 8, 2021 12:21 PM > To: Leo Li > Cc: linux-arm-ker...@lists.infradead.org; Oleksij Rempel privat.de>; Krzysztof Kozlowski ; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Shawn Guo > > Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to > yaml schema > > On Mon, Feb 08, 2021 at 05:07:14PM +, Leo Li wrote: > > > > > > > -Original Message- > > > From: Rob Herring > > > Sent: Monday, February 8, 2021 10:55 AM > > > To: Leo Li > > > Cc: linux-arm-ker...@lists.infradead.org; Oleksij Rempel > > > ; Rob Herring ; > > > Krzysztof Kozlowski ; devicet...@vger.kernel.org; > > > linux- ker...@vger.kernel.org; Shawn Guo > > > Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc > > > binding to yaml schema > > > > > > On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote: > > > > Convert the txt binding to yaml format and add description. Also > > > > updated the recommended node name to ifc-bus to align with the > > > > simple-bus node name requirements. > > > > > > > > Signed-off-by: Li Yang > > > > --- > > > > .../bindings/memory-controllers/fsl/ifc.txt | 82 -- > > > > .../bindings/memory-controllers/fsl/ifc.yaml | 140 > > > > ++ > > > > 2 files changed, 140 insertions(+), 82 deletions(-) delete mode > > > > 100644 > > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > > > create mode 100644 > > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > Documentation/devicetree/bindings/memory- > > > controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): > > > /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address > > > format error, expected "0" > > > Documentation/devicetree/bindings/memory- > > > controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): > > > /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address > > > format error, expected "1" > > > Documentation/devicetree/bindings/memory- > > > controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): > > > /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address > > > format error, expected "3" > > > > Hi Rob, > > > > I saw these warnings, but cannot find a good solution to it. The > > first cell in the address is the Chip select, while the second cell in > > the address is the address offset within the chip select. It would > > confusing to combine the two cells of different purposes into a single > > address as suggested by the warning. Can we allow the multi-cell > > address in the node name? > > Drop 'simple-bus'. It's not a simple bus. You have registers that presumably > have some configuration needed. That's probably true for just using "simple-bus" as compatible along. But I see many of the current bindings are defining a more specific compatible string in addition to the "simple-bus" compatible and have their own drivers. I think this probably meet the statement in the device tree spec? "Bindings may be defined as extensions of other each. For example a new bus type could be defined as an extension of the simple-bus binding." Regards, Leo
Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
On Mon, Feb 08, 2021 at 05:07:14PM +, Leo Li wrote: > > > > -Original Message- > > From: Rob Herring > > Sent: Monday, February 8, 2021 10:55 AM > > To: Leo Li > > Cc: linux-arm-ker...@lists.infradead.org; Oleksij Rempel > privat.de>; Rob Herring ; Krzysztof Kozlowski > > ; devicet...@vger.kernel.org; linux- > > ker...@vger.kernel.org; Shawn Guo > > Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to > > yaml schema > > > > On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote: > > > Convert the txt binding to yaml format and add description. Also > > > updated the recommended node name to ifc-bus to align with the > > > simple-bus node name requirements. > > > > > > Signed-off-by: Li Yang > > > --- > > > .../bindings/memory-controllers/fsl/ifc.txt | 82 -- > > > .../bindings/memory-controllers/fsl/ifc.yaml | 140 > > > ++ > > > 2 files changed, 140 insertions(+), 82 deletions(-) delete mode > > > 100644 > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address > > format error, expected "0" > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address > > format error, expected "1" > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format > > error, expected "3" > > Hi Rob, > > I saw these warnings, but cannot find a good solution to it. The > first cell in the address is the Chip select, while the second cell > in the address is the address offset within the chip select. It > would confusing to combine the two cells of different purposes into > a single address as suggested by the warning. Can we allow the > multi-cell address in the node name? Drop 'simple-bus'. It's not a simple bus. You have registers that presumably have some configuration needed. Rob
RE: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
> -Original Message- > From: Rob Herring > Sent: Monday, February 8, 2021 10:55 AM > To: Leo Li > Cc: linux-arm-ker...@lists.infradead.org; Oleksij Rempel privat.de>; Rob Herring ; Krzysztof Kozlowski > ; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; Shawn Guo > Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to > yaml schema > > On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote: > > Convert the txt binding to yaml format and add description. Also > > updated the recommended node name to ifc-bus to align with the > > simple-bus node name requirements. > > > > Signed-off-by: Li Yang > > --- > > .../bindings/memory-controllers/fsl/ifc.txt | 82 -- > > .../bindings/memory-controllers/fsl/ifc.yaml | 140 > > ++ > > 2 files changed, 140 insertions(+), 82 deletions(-) delete mode > > 100644 > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > create mode 100644 > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/memory- > controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): > /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address > format error, expected "0" > Documentation/devicetree/bindings/memory- > controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): > /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address > format error, expected "1" > Documentation/devicetree/bindings/memory- > controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): > /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format > error, expected "3" Hi Rob, I saw these warnings, but cannot find a good solution to it. The first cell in the address is the Chip select, while the second cell in the address is the address offset within the chip select. It would confusing to combine the two cells of different purposes into a single address as suggested by the warning. Can we allow the multi-cell address in the node name? Regards, Leo
Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote: > Convert the txt binding to yaml format and add description. Also > updated the recommended node name to ifc-bus to align with the > simple-bus node name requirements. > > Signed-off-by: Li Yang > --- > .../bindings/memory-controllers/fsl/ifc.txt | 82 -- > .../bindings/memory-controllers/fsl/ifc.yaml | 140 ++ > 2 files changed, 140 insertions(+), 82 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > create mode 100644 > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address format error, expected "0" Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address format error, expected "1" Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format error, expected "3" See https://patchwork.ozlabs.org/patch/1436960 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
On Fri, Feb 05, 2021 at 05:47:22PM -0600, Li Yang wrote:
> Convert the txt binding to yaml format and add description. Also
> updated the recommended node name to ifc-bus to align with the
> simple-bus node name requirements.
>
> Signed-off-by: Li Yang
> ---
> .../bindings/memory-controllers/fsl/ifc.txt | 82 --
> .../bindings/memory-controllers/fsl/ifc.yaml | 140 ++
> 2 files changed, 140 insertions(+), 82 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> create mode 100644
> Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> deleted file mode 100644
> index 89427b018ba7..
> --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -Integrated Flash Controller
> -
> -Properties:
> -- name : Should be ifc
> -- compatible : should contain "fsl,ifc". The version of the integrated
> - flash controller can be found in the IFC_REV register at
> - offset zero.
> -
> -- #address-cells : Should be either two or three. The first cell is the
> - chipselect number, and the remaining cells are the
> - offset into the chipselect.
> -- #size-cells : Either one or two, depending on how large each chipselect
> -can be.
> -- reg : Offset and length of the register set for the device
> -- interrupts: IFC may have one or two interrupts. If two interrupt
> - specifiers are present, the first is the "common"
> - interrupt (CM_EVTER_STAT), and the second is the NAND
> - interrupt (NAND_EVTER_STAT). If there is only one,
> - that interrupt reports both types of event.
> -
> -- little-endian : If this property is absent, the big-endian mode will
> - be in use as default for registers.
> -
> -- ranges : Each range corresponds to a single chipselect, and covers
> - the entire access window as configured.
> -
> -Child device nodes describe the devices connected to IFC such as NOR (e.g.
> -cfi-flash) and NAND (fsl,ifc-nand). There might be board specific devices
> -like FPGAs, CPLDs, etc.
> -
> -Example:
> -
> - ifc@ffe1e000 {
> - compatible = "fsl,ifc", "simple-bus";
> - #address-cells = <2>;
> - #size-cells = <1>;
> - reg = <0x0 0xffe1e000 0 0x2000>;
> - interrupts = <16 2 19 2>;
> - little-endian;
> -
> - /* NOR, NAND Flashes and CPLD on board */
> - ranges = <0x0 0x0 0x0 0xee00 0x0200
> - 0x1 0x0 0x0 0xffa0 0x0001
> - 0x3 0x0 0x0 0xffb0 0x0002>;
> -
> - flash@0,0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - compatible = "cfi-flash";
> - reg = <0x0 0x0 0x200>;
> - bank-width = <2>;
> - device-width = <1>;
> -
> - partition@0 {
> - /* 32MB for user data */
> - reg = <0x0 0x0200>;
> - label = "NOR Data";
> - };
> - };
> -
> - flash@1,0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - compatible = "fsl,ifc-nand";
> - reg = <0x1 0x0 0x1>;
> -
> - partition@0 {
> - /* This location must not be altered */
> - /* 1MB for u-boot Bootloader Image */
> - reg = <0x0 0x0010>;
> - label = "NAND U-Boot Image";
> - read-only;
> - };
> - };
> -
> - cpld@3,0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - compatible = "fsl,p1010rdb-cpld";
> - reg = <0x3 0x0 0x01f>;
> - };
> - };
> diff --git
> a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> new file mode 100644
> index ..d37cae66b027
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> @@ -0,0 +1,140 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/fsl/ifc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FSL/NXP Integrated Flash Controller
> +
> +maintainers:
> + - Li Yang
> +
> +description: |
> + NXP's int
[PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
Convert the txt binding to yaml format and add description. Also
updated the recommended node name to ifc-bus to align with the
simple-bus node name requirements.
Signed-off-by: Li Yang
---
.../bindings/memory-controllers/fsl/ifc.txt | 82 --
.../bindings/memory-controllers/fsl/ifc.yaml | 140 ++
2 files changed, 140 insertions(+), 82 deletions(-)
delete mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
deleted file mode 100644
index 89427b018ba7..
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
+++ /dev/null
@@ -1,82 +0,0 @@
-Integrated Flash Controller
-
-Properties:
-- name : Should be ifc
-- compatible : should contain "fsl,ifc". The version of the integrated
- flash controller can be found in the IFC_REV register at
- offset zero.
-
-- #address-cells : Should be either two or three. The first cell is the
- chipselect number, and the remaining cells are the
- offset into the chipselect.
-- #size-cells : Either one or two, depending on how large each chipselect
-can be.
-- reg : Offset and length of the register set for the device
-- interrupts: IFC may have one or two interrupts. If two interrupt
- specifiers are present, the first is the "common"
- interrupt (CM_EVTER_STAT), and the second is the NAND
- interrupt (NAND_EVTER_STAT). If there is only one,
- that interrupt reports both types of event.
-
-- little-endian : If this property is absent, the big-endian mode will
- be in use as default for registers.
-
-- ranges : Each range corresponds to a single chipselect, and covers
- the entire access window as configured.
-
-Child device nodes describe the devices connected to IFC such as NOR (e.g.
-cfi-flash) and NAND (fsl,ifc-nand). There might be board specific devices
-like FPGAs, CPLDs, etc.
-
-Example:
-
- ifc@ffe1e000 {
- compatible = "fsl,ifc", "simple-bus";
- #address-cells = <2>;
- #size-cells = <1>;
- reg = <0x0 0xffe1e000 0 0x2000>;
- interrupts = <16 2 19 2>;
- little-endian;
-
- /* NOR, NAND Flashes and CPLD on board */
- ranges = <0x0 0x0 0x0 0xee00 0x0200
- 0x1 0x0 0x0 0xffa0 0x0001
- 0x3 0x0 0x0 0xffb0 0x0002>;
-
- flash@0,0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "cfi-flash";
- reg = <0x0 0x0 0x200>;
- bank-width = <2>;
- device-width = <1>;
-
- partition@0 {
- /* 32MB for user data */
- reg = <0x0 0x0200>;
- label = "NOR Data";
- };
- };
-
- flash@1,0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "fsl,ifc-nand";
- reg = <0x1 0x0 0x1>;
-
- partition@0 {
- /* This location must not be altered */
- /* 1MB for u-boot Bootloader Image */
- reg = <0x0 0x0010>;
- label = "NAND U-Boot Image";
- read-only;
- };
- };
-
- cpld@3,0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "fsl,p1010rdb-cpld";
- reg = <0x3 0x0 0x01f>;
- };
- };
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
new file mode 100644
index ..d37cae66b027
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/fsl/ifc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FSL/NXP Integrated Flash Controller
+
+maintainers:
+ - Li Yang
+
+description: |
+ NXP's integrated flash controller (IFC) is an advanced version of the
+ enhanced local bus controller which includes similar programming and signal
+ interfaces with an extended feature set. The IFC provides access to multipl
