[PATCH 04/11] spi: bcm2835: Simplify with dev_err_probe()

[Krzysztof Kozlowski]

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/spi/spi-bcm2835.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index c45d76c848c8..5519f1eda238 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -1319,11 +1319,8 @@ static int bcm2835_spi_probe(struct platform_device 
*pdev)
 
bs->clk = devm_clk_get(>dev, NULL);
if (IS_ERR(bs->clk)) {
-   err = PTR_ERR(bs->clk);
-   if (err == -EPROBE_DEFER)
-   dev_dbg(>dev, "could not get clk: %d\n", err);
-   else
-   dev_err(>dev, "could not get clk: %d\n", err);
+   err = dev_err_probe(>dev, PTR_ERR(bs->clk),
+   "could not get clk\n");
goto out_controller_put;
}
 
-- 
2.17.1

Re: [PATCH 04/11] spi: bcm2835: Simplify with dev_err_probe()

[Florian Fainelli]

On 9/1/2020 8:27 AM, Krzysztof Kozlowski wrote:

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 


Acked-by: Florian Fainelli 
--
Florian