Re: [PATCH 04/12] ext2: drop unneeded newline

2018-01-02 Thread Jan Kara
On Wed 27-12-17 23:30:42, Ted Tso wrote:
> On Wed, Dec 27, 2017 at 03:51:37PM +0100, Julia Lawall wrote:
> > ext2_msg prints a newline at the end of the message string, so the message
> > string does not need to include a newline explicitly.  Done using
> > Coccinelle.
> > 
> > Signed-off-by: Julia Lawall 
> 
> Reviewed-by: Theodore Ts'o 

Thanks. I've picked up the patch to my tree.

Honza
-- 
Jan Kara 
SUSE Labs, CR


Re: [PATCH 04/12] ext2: drop unneeded newline

2017-12-27 Thread Theodore Ts'o
On Wed, Dec 27, 2017 at 03:51:37PM +0100, Julia Lawall wrote:
> ext2_msg prints a newline at the end of the message string, so the message
> string does not need to include a newline explicitly.  Done using
> Coccinelle.
> 
> Signed-off-by: Julia Lawall 

Reviewed-by: Theodore Ts'o 

- Ted


[PATCH 04/12] ext2: drop unneeded newline

2017-12-27 Thread Julia Lawall
ext2_msg prints a newline at the end of the message string, so the message
string does not need to include a newline explicitly.  Done using
Coccinelle.

Signed-off-by: Julia Lawall 

---
 fs/ext2/super.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 0083ea5..3220035 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1226,7 +1226,7 @@ static void ext2_clear_super_error(struct super_block *sb)
 * write and hope for the best.
 */
ext2_msg(sb, KERN_ERR,
-  "previous I/O error to superblock detected\n");
+  "previous I/O error to superblock detected");
clear_buffer_write_io_error(sbh);
set_buffer_uptodate(sbh);
}