Re: [PATCH 04/29] sparc: Avoid comma separated statements

2021-01-30 Thread Joe Perches 
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

ping?

> Signed-off-by: Joe Perches 
> ---
>  arch/sparc/kernel/smp_64.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
> index e286e2badc8a..28c11f7871cd 100644
> --- a/arch/sparc/kernel/smp_64.c
> +++ b/arch/sparc/kernel/smp_64.c
> @@ -186,8 +186,11 @@ static inline long get_delta (long *rt, long *master)
>   wmb();
>   t1 = tick_ops->get_tick();
>  
> 
> - if (t1 - t0 < best_t1 - best_t0)
> - best_t0 = t0, best_t1 = t1, best_tm = tm;
> + if (t1 - t0 < best_t1 - best_t0) {
> + best_t0 = t0;
> + best_t1 = t1;
> + best_tm = tm;
> + }
>   }
>  
> 
>   *rt = best_t1 - best_t0;

[PATCH 04/29] sparc: Avoid comma separated statements

2020-08-24 Thread Joe Perches 
Use semicolons and braces.

Signed-off-by: Joe Perches 
---
 arch/sparc/kernel/smp_64.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
index e286e2badc8a..28c11f7871cd 100644
--- a/arch/sparc/kernel/smp_64.c
+++ b/arch/sparc/kernel/smp_64.c
@@ -186,8 +186,11 @@ static inline long get_delta (long *rt, long *master)
wmb();
t1 = tick_ops->get_tick();
 
-   if (t1 - t0 < best_t1 - best_t0)
-   best_t0 = t0, best_t1 = t1, best_tm = tm;
+   if (t1 - t0 < best_t1 - best_t0) {
+   best_t0 = t0;
+   best_t1 = t1;
+   best_tm = tm;
+   }
}
 
*rt = best_t1 - best_t0;
-- 
2.26.0