Re: [PATCH 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-09 Thread Greg Kroah-Hartman
On Mon, Oct 09, 2023 at 04:19:03PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann 
> 
> The .ndo_do_ioctl functions are never called, and can just be removed,
> especially since this is a staging driver.
> 
> Signed-off-by: Arnd Bergmann 
> ---
>  drivers/staging/rtl8192u/ieee80211/dot11d.c   |  41 --
>  drivers/staging/rtl8192u/ieee80211/dot11d.h   |   2 -
>  .../staging/rtl8192u/ieee80211/ieee80211.h|  12 -
>  .../rtl8192u/ieee80211/ieee80211_softmac.c| 563 --
>  drivers/staging/rtl8192u/r8192U.h |   2 -
>  drivers/staging/rtl8192u/r8192U_core.c| 109 
>  6 files changed, 729 deletions(-)

Reviewed-by: Greg Kroah-Hartman 


[PATCH 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-09 Thread Arnd Bergmann
From: Arnd Bergmann 

The .ndo_do_ioctl functions are never called, and can just be removed,
especially since this is a staging driver.

Signed-off-by: Arnd Bergmann 
---
 drivers/staging/rtl8192u/ieee80211/dot11d.c   |  41 --
 drivers/staging/rtl8192u/ieee80211/dot11d.h   |   2 -
 .../staging/rtl8192u/ieee80211/ieee80211.h|  12 -
 .../rtl8192u/ieee80211/ieee80211_softmac.c| 563 --
 drivers/staging/rtl8192u/r8192U.h |   2 -
 drivers/staging/rtl8192u/r8192U_core.c| 109 
 6 files changed, 729 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c 
b/drivers/staging/rtl8192u/ieee80211/dot11d.c
index ddaf66fa0f936..8a72c1e9eb1e1 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.c
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.c
@@ -97,22 +97,6 @@ void dot11d_update_country_ie(struct ieee80211_device *dev, 
u8 *pTaddr,
 }
 EXPORT_SYMBOL(dot11d_update_country_ie);
 
-u8 dot11d_get_max_tx_pwr_in_dbm(struct ieee80211_device *dev, u8 Channel)
-{
-   struct rt_dot11d_info *dot11d_info = GET_DOT11D_INFO(dev);
-   u8 MaxTxPwrInDbm = 255;
-
-   if (Channel > MAX_CHANNEL_NUMBER) {
-   netdev_err(dev->dev, "%s: Invalid Channel\n", __func__);
-   return MaxTxPwrInDbm;
-   }
-   if (dot11d_info->channel_map[Channel])
-   MaxTxPwrInDbm = dot11d_info->max_tx_pwr_dbm_list[Channel];
-
-   return MaxTxPwrInDbm;
-}
-EXPORT_SYMBOL(dot11d_get_max_tx_pwr_in_dbm);
-
 void dot11d_scan_complete(struct ieee80211_device *dev)
 {
struct rt_dot11d_info *dot11d_info = GET_DOT11D_INFO(dev);
@@ -147,28 +131,3 @@ int is_legal_channel(struct ieee80211_device *dev, u8 
channel)
return 0;
 }
 EXPORT_SYMBOL(is_legal_channel);
-
-int to_legal_channel(struct ieee80211_device *dev, u8 channel)
-{
-   struct rt_dot11d_info *dot11d_info = GET_DOT11D_INFO(dev);
-   u8 default_chn = 0;
-   u32 i = 0;
-
-   for (i = 1; i <= MAX_CHANNEL_NUMBER; i++) {
-   if (dot11d_info->channel_map[i] > 0) {
-   default_chn = i;
-   break;
-   }
-   }
-
-   if (channel > MAX_CHANNEL_NUMBER) {
-   netdev_err(dev->dev, "%s: Invalid Channel\n", __func__);
-   return default_chn;
-   }
-
-   if (dot11d_info->channel_map[channel] > 0)
-   return channel;
-
-   return default_chn;
-}
-EXPORT_SYMBOL(to_legal_channel);
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h 
b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 8b485fa180898..fd774265211a5 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -49,9 +49,7 @@ void dot11d_update_country_ie(struct ieee80211_device *dev,
  u8 *addr,
  u16 coutry_ie_len,
  u8 *coutry_ie);
-u8 dot11d_get_max_tx_pwr_in_dbm(struct ieee80211_device *dev, u8 channel);
 void dot11d_scan_complete(struct ieee80211_device *dev);
 int is_legal_channel(struct ieee80211_device *dev, u8 channel);
-int to_legal_channel(struct ieee80211_device *dev, u8 channel);
 
 #endif /* #ifndef __INC_DOT11D_H */
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h 
b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
index 694d1b18f81c7..fc4201757c408 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
@@ -223,11 +223,7 @@ struct cb_desc {
 #define MAX_IE_LEN  0xff
 
 // added for kernel conflict
-#define ieee80211_wake_queue   ieee80211_wake_queue_rsl
-#define ieee80211_stop_queue   ieee80211_stop_queue_rsl
 #define notify_wx_assoc_event  notify_wx_assoc_event_rsl
-#define SendDisassociation SendDisassociation_rsl
-
 
 struct ieee_param {
u32 cmd;
@@ -2152,7 +2148,6 @@ int ieee80211_wx_set_gen_ie(struct ieee80211_device 
*ieee, u8 *ie, size_t len);
 
 /* ieee80211_softmac.c */
 short ieee80211_is_54g(const struct ieee80211_network *net);
-short ieee80211_is_shortslot(const struct ieee80211_network *net);
 int ieee80211_rx_frame_softmac(struct ieee80211_device *ieee,
   struct sk_buff *skb,
   struct ieee80211_rx_stats *rx_stats,
@@ -2160,7 +2155,6 @@ int ieee80211_rx_frame_softmac(struct ieee80211_device 
*ieee,
 void ieee80211_softmac_new_net(struct ieee80211_device *ieee,
   struct ieee80211_network *net);
 
-void SendDisassociation(struct ieee80211_device *ieee, u8 *asSta, u8 asRsn);
 void ieee80211_softmac_xmit(struct ieee80211_txb *txb,
struct ieee80211_device *ieee);
 
@@ -2182,13 +2176,7 @@ void ieee80211_stop_protocol(struct ieee80211_device 
*ieee);
 void ieee80211_softmac_start_protocol(struct ieee80211_device *ieee);
 void ieee80211_softmac_stop_protocol(struct ieee80211_device *ieee);
 void