Re: [PATCH 05/10] vhost: make interval tree static inline

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

vhost_umem_interval_tree is only used locally within vhost.c, mark it
static. As some functions generated go unused, this triggers warnings
unless we also mark it inline.

Signed-off-by: Michael S. Tsirkin 
---
  drivers/vhost/vhost.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index c6f2d89..7331ef3 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -49,7 +49,7 @@ enum {
  
  INTERVAL_TREE_DEFINE(struct vhost_umem_node,

 rb, __u64, __subtree_last,
-START, LAST, , vhost_umem_interval_tree);
+START, LAST, static inline, vhost_umem_interval_tree);
  
  #ifdef CONFIG_VHOST_CROSS_ENDIAN_LEGACY

  static void vhost_disable_cross_endian(struct vhost_virtqueue *vq)


Reviewed-by: Jason Wang 

Re: [PATCH 05/10] vhost: make interval tree static inline

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

vhost_umem_interval_tree is only used locally within vhost.c, mark it
static. As some functions generated go unused, this triggers warnings
unless we also mark it inline.

Signed-off-by: Michael S. Tsirkin 
---
  drivers/vhost/vhost.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index c6f2d89..7331ef3 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -49,7 +49,7 @@ enum {
  
  INTERVAL_TREE_DEFINE(struct vhost_umem_node,

 rb, __u64, __subtree_last,
-START, LAST, , vhost_umem_interval_tree);
+START, LAST, static inline, vhost_umem_interval_tree);
  
  #ifdef CONFIG_VHOST_CROSS_ENDIAN_LEGACY

  static void vhost_disable_cross_endian(struct vhost_virtqueue *vq)


Reviewed-by: Jason Wang 

[PATCH 05/10] vhost: make interval tree static inline

[Michael S. Tsirkin]

vhost_umem_interval_tree is only used locally within vhost.c, mark it
static. As some functions generated go unused, this triggers warnings
unless we also mark it inline.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index c6f2d89..7331ef3 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -49,7 +49,7 @@ enum {
 
 INTERVAL_TREE_DEFINE(struct vhost_umem_node,
 rb, __u64, __subtree_last,
-START, LAST, , vhost_umem_interval_tree);
+START, LAST, static inline, vhost_umem_interval_tree);
 
 #ifdef CONFIG_VHOST_CROSS_ENDIAN_LEGACY
 static void vhost_disable_cross_endian(struct vhost_virtqueue *vq)
-- 
MST

[PATCH 05/10] vhost: make interval tree static inline

[Michael S. Tsirkin]

vhost_umem_interval_tree is only used locally within vhost.c, mark it
static. As some functions generated go unused, this triggers warnings
unless we also mark it inline.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index c6f2d89..7331ef3 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -49,7 +49,7 @@ enum {
 
 INTERVAL_TREE_DEFINE(struct vhost_umem_node,
 rb, __u64, __subtree_last,
-START, LAST, , vhost_umem_interval_tree);
+START, LAST, static inline, vhost_umem_interval_tree);
 
 #ifdef CONFIG_VHOST_CROSS_ENDIAN_LEGACY
 static void vhost_disable_cross_endian(struct vhost_virtqueue *vq)
-- 
MST