Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-18 Thread Tushar Behera 
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote:
> On Fri, 16 Nov 2012, Tushar Behera wrote:
> 
>> Checking '< 0' for unsigned variables always returns false. For error
>> codes, use IS_ERR_VALUE() instead.
> 
> Wouldn't just changing "irq" type to "int" also work? I think that would 
> be a more straight-forward solution. If however there are strong arguments 
> against that, I'm fine with this fix too.
> 

By changing irq to signed variable, we would get compilation warning in
subsequent line (request_irq).

> Thanks
> Guennadi
> 
>>
>> CC: Mauro Carvalho Chehab 
>> CC: linux-me...@vger.kernel.org
>> Signed-off-by: Tushar Behera 
>> ---
>>  drivers/media/platform/soc_camera/atmel-isi.c |2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
>> b/drivers/media/platform/soc_camera/atmel-isi.c
>> index 6274a91..5bd65df 100644
>> --- a/drivers/media/platform/soc_camera/atmel-isi.c
>> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
>> @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
>> platform_device *pdev)
>>  isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
>>  
>>  irq = platform_get_irq(pdev, 0);
>> -if (irq < 0) {
>> +if (IS_ERR_VALUE(irq)) {
>>  ret = irq;
>>  goto err_req_irq;
>>  }
>> -- 
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> 


-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-18 Thread Tushar Behera 
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote:
 On Fri, 16 Nov 2012, Tushar Behera wrote:
 
 Checking ' 0' for unsigned variables always returns false. For error
 codes, use IS_ERR_VALUE() instead.
 
 Wouldn't just changing irq type to int also work? I think that would 
 be a more straight-forward solution. If however there are strong arguments 
 against that, I'm fine with this fix too.
 

By changing irq to signed variable, we would get compilation warning in
subsequent line (request_irq).

 Thanks
 Guennadi
 

 CC: Mauro Carvalho Chehab mche...@infradead.org
 CC: linux-me...@vger.kernel.org
 Signed-off-by: Tushar Behera tushar.beh...@linaro.org
 ---
  drivers/media/platform/soc_camera/atmel-isi.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
 b/drivers/media/platform/soc_camera/atmel-isi.c
 index 6274a91..5bd65df 100644
 --- a/drivers/media/platform/soc_camera/atmel-isi.c
 +++ b/drivers/media/platform/soc_camera/atmel-isi.c
 @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
 platform_device *pdev)
  isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
  
  irq = platform_get_irq(pdev, 0);
 -if (irq  0) {
 +if (IS_ERR_VALUE(irq)) {
  ret = irq;
  goto err_req_irq;
  }
 -- 
 1.7.4.1

 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

 
 ---
 Guennadi Liakhovetski, Ph.D.
 Freelance Open-Source Software Developer
 http://www.open-technology.de/
 


-- 
Tushar Behera
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-17 Thread Guennadi Liakhovetski 
On Fri, 16 Nov 2012, Tushar Behera wrote:

> Checking '< 0' for unsigned variables always returns false. For error
> codes, use IS_ERR_VALUE() instead.

Wouldn't just changing "irq" type to "int" also work? I think that would 
be a more straight-forward solution. If however there are strong arguments 
against that, I'm fine with this fix too.

Thanks
Guennadi

> 
> CC: Mauro Carvalho Chehab 
> CC: linux-me...@vger.kernel.org
> Signed-off-by: Tushar Behera 
> ---
>  drivers/media/platform/soc_camera/atmel-isi.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
> b/drivers/media/platform/soc_camera/atmel-isi.c
> index 6274a91..5bd65df 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
> platform_device *pdev)
>   isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
>  
>   irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> + if (IS_ERR_VALUE(irq)) {
>   ret = irq;
>   goto err_req_irq;
>   }
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-17 Thread Guennadi Liakhovetski 
On Fri, 16 Nov 2012, Tushar Behera wrote:

 Checking ' 0' for unsigned variables always returns false. For error
 codes, use IS_ERR_VALUE() instead.

Wouldn't just changing irq type to int also work? I think that would 
be a more straight-forward solution. If however there are strong arguments 
against that, I'm fine with this fix too.

Thanks
Guennadi

 
 CC: Mauro Carvalho Chehab mche...@infradead.org
 CC: linux-me...@vger.kernel.org
 Signed-off-by: Tushar Behera tushar.beh...@linaro.org
 ---
  drivers/media/platform/soc_camera/atmel-isi.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
 b/drivers/media/platform/soc_camera/atmel-isi.c
 index 6274a91..5bd65df 100644
 --- a/drivers/media/platform/soc_camera/atmel-isi.c
 +++ b/drivers/media/platform/soc_camera/atmel-isi.c
 @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
 platform_device *pdev)
   isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
  
   irq = platform_get_irq(pdev, 0);
 - if (irq  0) {
 + if (IS_ERR_VALUE(irq)) {
   ret = irq;
   goto err_req_irq;
   }
 -- 
 1.7.4.1
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera 
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.

CC: Mauro Carvalho Chehab 
CC: linux-me...@vger.kernel.org
Signed-off-by: Tushar Behera 
---
 drivers/media/platform/soc_camera/atmel-isi.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
b/drivers/media/platform/soc_camera/atmel-isi.c
index 6274a91..5bd65df 100644
--- a/drivers/media/platform/soc_camera/atmel-isi.c
+++ b/drivers/media/platform/soc_camera/atmel-isi.c
@@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
platform_device *pdev)
isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
 
irq = platform_get_irq(pdev, 0);
-   if (irq < 0) {
+   if (IS_ERR_VALUE(irq)) {
ret = irq;
goto err_req_irq;
}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera 
Checking ' 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.

CC: Mauro Carvalho Chehab mche...@infradead.org
CC: linux-me...@vger.kernel.org
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
 drivers/media/platform/soc_camera/atmel-isi.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/platform/soc_camera/atmel-isi.c 
b/drivers/media/platform/soc_camera/atmel-isi.c
index 6274a91..5bd65df 100644
--- a/drivers/media/platform/soc_camera/atmel-isi.c
+++ b/drivers/media/platform/soc_camera/atmel-isi.c
@@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct 
platform_device *pdev)
isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
 
irq = platform_get_irq(pdev, 0);
-   if (irq  0) {
+   if (IS_ERR_VALUE(irq)) {
ret = irq;
goto err_req_irq;
}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/