Re: [PATCH 06/29] drbd: Avoid comma separated statements

2021-01-31 Thread Jens Axboe 
On 1/30/21 11:57 AM, Joe Perches wrote:
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>> Use semicolons and braces.
> 
> ping?

Queued for 5.12.

-- 
Jens Axboe

Re: [PATCH 06/29] drbd: Avoid comma separated statements

2021-01-30 Thread Joe Perches 
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

ping?

> Signed-off-by: Joe Perches 
> ---
>  drivers/block/drbd/drbd_receiver.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_receiver.c 
> b/drivers/block/drbd/drbd_receiver.c
> index 422363daa618..87f732fb5456 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -111,8 +111,10 @@ static struct page *page_chain_tail(struct page *page, 
> int *len)
>  {
>   struct page *tmp;
>   int i = 1;
> - while ((tmp = page_chain_next(page)))
> - ++i, page = tmp;
> + while ((tmp = page_chain_next(page))) {
> + ++i;
> + page = tmp;
> + }
>   if (len)
>   *len = i;
>   return page;

[PATCH 06/29] drbd: Avoid comma separated statements

2020-08-24 Thread Joe Perches 
Use semicolons and braces.

Signed-off-by: Joe Perches 
---
 drivers/block/drbd/drbd_receiver.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/block/drbd/drbd_receiver.c 
b/drivers/block/drbd/drbd_receiver.c
index 422363daa618..87f732fb5456 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -111,8 +111,10 @@ static struct page *page_chain_tail(struct page *page, int 
*len)
 {
struct page *tmp;
int i = 1;
-   while ((tmp = page_chain_next(page)))
-   ++i, page = tmp;
+   while ((tmp = page_chain_next(page))) {
+   ++i;
+   page = tmp;
+   }
if (len)
*len = i;
return page;
-- 
2.26.0