Re: [PATCH 06/59] arch/sparc: Add missing "space"
From: Joe Perches <[EMAIL PROTECTED]>
Date: Mon, 19 Nov 2007 23:48:36 -0800
> On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote:
> > From: Joe Perches <[EMAIL PROTECTED]>
> > Date: Mon, 19 Nov 2007 17:47:58 -0800
> > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
> > Please check your patches, for trailing white "space".
> > Adds trailing whitespace.
> > diff:10:prom_printf("PCIC: Error, cannot map "
> > Adds trailing whitespace.
> > diff:19:prom_printf("PCIC: Error, cannot map "
> > warning: 2 lines add whitespace errors.
> > I've fixed it up this time.
>
> It doesn't add whitespace, but it does keep the trailing
> whitespace that's already there.
I know that, you should still do sanity checks and fix these kinds of
things up because they trigger errors in my patch applying scripts and
that of many other developers.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/59] arch/sparc: Add missing space
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 23:48:36 -0800 On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 17:47:58 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Please check your patches, for trailing white space. Adds trailing whitespace. diff:10:prom_printf(PCIC: Error, cannot map Adds trailing whitespace. diff:19:prom_printf(PCIC: Error, cannot map warning: 2 lines add whitespace errors. I've fixed it up this time. It doesn't add whitespace, but it does keep the trailing whitespace that's already there. I know that, you should still do sanity checks and fix these kinds of things up because they trigger errors in my patch applying scripts and that of many other developers. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/59] arch/sparc: Add missing "space"
On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote:
> From: Joe Perches <[EMAIL PROTECTED]>
> Date: Mon, 19 Nov 2007 17:47:58 -0800
> > Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
> Please check your patches, for trailing white "space".
> Adds trailing whitespace.
> diff:10: prom_printf("PCIC: Error, cannot map "
> Adds trailing whitespace.
> diff:19: prom_printf("PCIC: Error, cannot map "
> warning: 2 lines add whitespace errors.
> I've fixed it up this time.
It doesn't add whitespace, but it does keep the trailing
whitespace that's already there.
cheers, Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/59] arch/sparc: Add missing "space"
From: Joe Perches <[EMAIL PROTECTED]>
Date: Mon, 19 Nov 2007 17:47:58 -0800
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
Please check your patches, for trailing white "space".
Adds trailing whitespace.
diff:10:prom_printf("PCIC: Error, cannot map "
Adds trailing whitespace.
diff:19:prom_printf("PCIC: Error, cannot map "
warning: 2 lines add whitespace errors.
I've fixed it up this time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/59] arch/sparc: Add missing "space"
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
arch/sparc/kernel/pcic.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/sparc/kernel/pcic.c b/arch/sparc/kernel/pcic.c
index f2d432e..396718b 100644
--- a/arch/sparc/kernel/pcic.c
+++ b/arch/sparc/kernel/pcic.c
@@ -329,7 +329,7 @@ int __init pcic_probe(void)
pcic->pcic_res_cfg_addr.name = "pcic_cfg_addr";
if ((pcic->pcic_config_space_addr =
ioremap(regs[2].phys_addr, regs[2].reg_size * 2)) == 0) {
- prom_printf("PCIC: Error, cannot map"
+ prom_printf("PCIC: Error, cannot map "
"PCI Configuration Space Address.\n");
prom_halt();
}
@@ -341,7 +341,7 @@ int __init pcic_probe(void)
pcic->pcic_res_cfg_data.name = "pcic_cfg_data";
if ((pcic->pcic_config_space_data =
ioremap(regs[3].phys_addr, regs[3].reg_size * 2)) == 0) {
- prom_printf("PCIC: Error, cannot map"
+ prom_printf("PCIC: Error, cannot map "
"PCI Configuration Space Data.\n");
prom_halt();
}
@@ -518,8 +518,8 @@ static void pcic_map_pci_device(struct linux_pcic *pcic,
* board in a PCI slot. We must remap it
* under 64K but it is not done yet. XXX
*/
- printk("PCIC: Skipping I/O space at 0x%lx,"
- "this will Oops if a driver attaches;"
+ printk("PCIC: Skipping I/O space at 0x%lx, "
+ "this will Oops if a driver attaches "
"device '%s' at %02x:%02x)\n", address,
namebuf, dev->bus->number, dev->devfn);
}
--
1.5.3.5.652.gf192c
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/59] arch/sparc: Add missing space
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
arch/sparc/kernel/pcic.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/sparc/kernel/pcic.c b/arch/sparc/kernel/pcic.c
index f2d432e..396718b 100644
--- a/arch/sparc/kernel/pcic.c
+++ b/arch/sparc/kernel/pcic.c
@@ -329,7 +329,7 @@ int __init pcic_probe(void)
pcic-pcic_res_cfg_addr.name = pcic_cfg_addr;
if ((pcic-pcic_config_space_addr =
ioremap(regs[2].phys_addr, regs[2].reg_size * 2)) == 0) {
- prom_printf(PCIC: Error, cannot map
+ prom_printf(PCIC: Error, cannot map
PCI Configuration Space Address.\n);
prom_halt();
}
@@ -341,7 +341,7 @@ int __init pcic_probe(void)
pcic-pcic_res_cfg_data.name = pcic_cfg_data;
if ((pcic-pcic_config_space_data =
ioremap(regs[3].phys_addr, regs[3].reg_size * 2)) == 0) {
- prom_printf(PCIC: Error, cannot map
+ prom_printf(PCIC: Error, cannot map
PCI Configuration Space Data.\n);
prom_halt();
}
@@ -518,8 +518,8 @@ static void pcic_map_pci_device(struct linux_pcic *pcic,
* board in a PCI slot. We must remap it
* under 64K but it is not done yet. XXX
*/
- printk(PCIC: Skipping I/O space at 0x%lx,
- this will Oops if a driver attaches;
+ printk(PCIC: Skipping I/O space at 0x%lx,
+ this will Oops if a driver attaches
device '%s' at %02x:%02x)\n, address,
namebuf, dev-bus-number, dev-devfn);
}
--
1.5.3.5.652.gf192c
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/59] arch/sparc: Add missing space
On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 17:47:58 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Please check your patches, for trailing white space. Adds trailing whitespace. diff:10: prom_printf(PCIC: Error, cannot map Adds trailing whitespace. diff:19: prom_printf(PCIC: Error, cannot map warning: 2 lines add whitespace errors. I've fixed it up this time. It doesn't add whitespace, but it does keep the trailing whitespace that's already there. cheers, Joe - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/59] arch/sparc: Add missing space
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 17:47:58 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Please check your patches, for trailing white space. Adds trailing whitespace. diff:10:prom_printf(PCIC: Error, cannot map Adds trailing whitespace. diff:19:prom_printf(PCIC: Error, cannot map warning: 2 lines add whitespace errors. I've fixed it up this time. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
