[RESEND PATCH 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

[Moritz Fischer]

Simplify registration using new devm_fpga_mgr_register() API.

Reviewed-by: Tom Rix 
Signed-off-by: Moritz Fischer 
---
 drivers/fpga/ts73xx-fpga.c | 14 +-
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
index 2888ff000e4d..101f016c6ed8 100644
--- a/drivers/fpga/ts73xx-fpga.c
+++ b/drivers/fpga/ts73xx-fpga.c
@@ -127,18 +127,7 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
if (!mgr)
return -ENOMEM;
 
-   platform_set_drvdata(pdev, mgr);
-
-   return fpga_mgr_register(mgr);
-}
-
-static int ts73xx_fpga_remove(struct platform_device *pdev)
-{
-   struct fpga_manager *mgr = platform_get_drvdata(pdev);
-
-   fpga_mgr_unregister(mgr);
-
-   return 0;
+   return devm_fpga_mgr_register(kdev, mgr);
 }
 
 static struct platform_driver ts73xx_fpga_driver = {
@@ -146,7 +135,6 @@ static struct platform_driver ts73xx_fpga_driver = {
.name   = "ts73xx-fpga-mgr",
},
.probe  = ts73xx_fpga_probe,
-   .remove = ts73xx_fpga_remove,
 };
 module_platform_driver(ts73xx_fpga_driver);
 
-- 
2.29.2

Re: [PATCH 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

[Tom Rix]

On 10/3/20 10:14 PM, Moritz Fischer wrote:
> Simplify registration using new devm_fpga_mgr_register() API.
>
> Signed-off-by: Moritz Fischer 
> ---
>  drivers/fpga/ts73xx-fpga.c | 14 +-
>  1 file changed, 1 insertion(+), 13 deletions(-)

LOTM

Reviewed-by: Tom Rix 

[PATCH 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

[Moritz Fischer]

Simplify registration using new devm_fpga_mgr_register() API.

Signed-off-by: Moritz Fischer 
---
 drivers/fpga/ts73xx-fpga.c | 14 +-
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
index 2888ff000e4d..101f016c6ed8 100644
--- a/drivers/fpga/ts73xx-fpga.c
+++ b/drivers/fpga/ts73xx-fpga.c
@@ -127,18 +127,7 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
if (!mgr)
return -ENOMEM;
 
-   platform_set_drvdata(pdev, mgr);
-
-   return fpga_mgr_register(mgr);
-}
-
-static int ts73xx_fpga_remove(struct platform_device *pdev)
-{
-   struct fpga_manager *mgr = platform_get_drvdata(pdev);
-
-   fpga_mgr_unregister(mgr);
-
-   return 0;
+   return devm_fpga_mgr_register(kdev, mgr);
 }
 
 static struct platform_driver ts73xx_fpga_driver = {
@@ -146,7 +135,6 @@ static struct platform_driver ts73xx_fpga_driver = {
.name   = "ts73xx-fpga-mgr",
},
.probe  = ts73xx_fpga_probe,
-   .remove = ts73xx_fpga_remove,
 };
 module_platform_driver(ts73xx_fpga_driver);
 
-- 
2.28.0