Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation

[Stefan Hajnoczi]

On Tue, Dec 06, 2016 at 05:40:57PM +0200, Michael S. Tsirkin wrote:
> guest cid is read from config space, therefore it's in little endian
> format and is treated as such, annotate it accordingly.
> 
> Signed-off-by: Michael S. Tsirkin 
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation

[Stefan Hajnoczi]

On Tue, Dec 06, 2016 at 05:40:57PM +0200, Michael S. Tsirkin wrote:
> guest cid is read from config space, therefore it's in little endian
> format and is treated as such, annotate it accordingly.
> 
> Signed-off-by: Michael S. Tsirkin 
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

guest cid is read from config space, therefore it's in little endian
format and is treated as such, annotate it accordingly.

Signed-off-by: Michael S. Tsirkin 
---
  net/vmw_vsock/virtio_transport.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 936d7ee..90096b9 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk)
  static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock)
  {
struct virtio_device *vdev = vsock->vdev;
-   u64 guest_cid;
+   __le64 guest_cid;
  
  	vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid),

  _cid, sizeof(guest_cid));


Reviewed-by: Jason Wang 

Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

guest cid is read from config space, therefore it's in little endian
format and is treated as such, annotate it accordingly.

Signed-off-by: Michael S. Tsirkin 
---
  net/vmw_vsock/virtio_transport.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 936d7ee..90096b9 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk)
  static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock)
  {
struct virtio_device *vdev = vsock->vdev;
-   u64 guest_cid;
+   __le64 guest_cid;
  
  	vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid),

  _cid, sizeof(guest_cid));


Reviewed-by: Jason Wang 

[PATCH 07/10] vsock/virtio: add a missing __le annotation

[Michael S. Tsirkin]

guest cid is read from config space, therefore it's in little endian
format and is treated as such, annotate it accordingly.

Signed-off-by: Michael S. Tsirkin 
---
 net/vmw_vsock/virtio_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 936d7ee..90096b9 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk)
 static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock)
 {
struct virtio_device *vdev = vsock->vdev;
-   u64 guest_cid;
+   __le64 guest_cid;
 
vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid),
  _cid, sizeof(guest_cid));
-- 
MST

[PATCH 07/10] vsock/virtio: add a missing __le annotation

[Michael S. Tsirkin]

guest cid is read from config space, therefore it's in little endian
format and is treated as such, annotate it accordingly.

Signed-off-by: Michael S. Tsirkin 
---
 net/vmw_vsock/virtio_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 936d7ee..90096b9 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk)
 static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock)
 {
struct virtio_device *vdev = vsock->vdev;
-   u64 guest_cid;
+   __le64 guest_cid;
 
vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid),
  _cid, sizeof(guest_cid));
-- 
MST