Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, Apr 25, 2013 at 11:17 AM, Lee Jones wrote: > On Thu, 25 Apr 2013, Linus Walleij wrote: > >> On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: >> >> > The DMA40 controller uses two sets of base addresses. In order to have >> > them automatically setup as resources by the Open Format framework we >> > have to set names for them. The names have to be the same as the ones >> > used to fetch them back out of the resource structure. >> > >> > Signed-off-by: Lee Jones >> >> This is OK with Arnds suggested changed, but I want the patch >> split off from this series and put into a device-tree-specific patch >> series so I can apply this to a branch where I try to keep >> all patches to the device tree files. (ux500-devicetree). > > Do you want to take this one separately? > > Feel free and I'll remove it from this set. The problem I'm facing in the ux500 tree is that different changes to the device tree files are colliding like hell. So I really need those changes (to those files) to come in separately. Usually the changes are orthogonal anyway, and the DT stuff "could" be maintained as if it was out-of-tree. At the core of that is basically that the DT files have a higher evolutionary pace than the kernel code and that is straining the merge model. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > > > The DMA40 controller uses two sets of base addresses. In order to have > > them automatically setup as resources by the Open Format framework we > > have to set names for them. The names have to be the same as the ones > > used to fetch them back out of the resource structure. > > > > Signed-off-by: Lee Jones > > This is OK with Arnds suggested changed, but I want the patch > split off from this series and put into a device-tree-specific patch > series so I can apply this to a branch where I try to keep > all patches to the device tree files. (ux500-devicetree). Do you want to take this one separately? Feel free and I'll remove it from this set. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > The DMA40 controller uses two sets of base addresses. In order to have > them automatically setup as resources by the Open Format framework we > have to set names for them. The names have to be the same as the ones > used to fetch them back out of the resource structure. > > Signed-off-by: Lee Jones This is OK with Arnds suggested changed, but I want the patch split off from this series and put into a device-tree-specific patch series so I can apply this to a branch where I try to keep all patches to the device tree files. (ux500-devicetree). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org This is OK with Arnds suggested changed, but I want the patch split off from this series and put into a device-tree-specific patch series so I can apply this to a branch where I try to keep all patches to the device tree files. (ux500-devicetree). Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org This is OK with Arnds suggested changed, but I want the patch split off from this series and put into a device-tree-specific patch series so I can apply this to a branch where I try to keep all patches to the device tree files. (ux500-devicetree). Do you want to take this one separately? Feel free and I'll remove it from this set. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, Apr 25, 2013 at 11:17 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org This is OK with Arnds suggested changed, but I want the patch split off from this series and put into a device-tree-specific patch series so I can apply this to a branch where I try to keep all patches to the device tree files. (ux500-devicetree). Do you want to take this one separately? Feel free and I'll remove it from this set. The problem I'm facing in the ux500 tree is that different changes to the device tree files are colliding like hell. So I really need those changes (to those files) to come in separately. Usually the changes are orthogonal anyway, and the DT stuff could be maintained as if it was out-of-tree. At the core of that is basically that the DT files have a higher evolutionary pace than the kernel code and that is straining the merge model. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 18 Apr 2013, Arnd Bergmann wrote: > On Thursday 18 April 2013, Lee Jones wrote: > > The DMA40 controller uses two sets of base addresses. In order to have > > them automatically setup as resources by the Open Format framework we > > have to set names for them. The names have to be the same as the ones > > used to fetch them back out of the resource structure. > > > > Signed-off-by: Lee Jones > > Typo: s/Open Format/Open Firmware/ > > To be more specific, just write of_platform framework. Note that we > still get resources without passing the names, they are just not > named in that case and have to be retrieved by index. Changed to: The DMA40 controller uses two sets of base addresses. In order to have the resources setup by the of_platform framework so they are searchable by name instead of index, we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. > You should also document the strings in the binding document. Done. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 18 Apr 2013, Arnd Bergmann wrote: > On Thursday 18 April 2013, Lee Jones wrote: > > The DMA40 controller uses two sets of base addresses. In order to have > > them automatically setup as resources by the Open Format framework we > > have to set names for them. The names have to be the same as the ones > > used to fetch them back out of the resource structure. > > > > Signed-off-by: Lee Jones > > Typo: s/Open Format/Open Firmware/ > > To be more specific, just write of_platform framework. Note that we > still get resources without passing the names, they are just not > named in that case and have to be retrieved by index. Okay, I'll fixup. > You should also document the strings in the binding document. I'll do that, thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thursday 18 April 2013, Lee Jones wrote: > The DMA40 controller uses two sets of base addresses. In order to have > them automatically setup as resources by the Open Format framework we > have to set names for them. The names have to be the same as the ones > used to fetch them back out of the resource structure. > > Signed-off-by: Lee Jones Typo: s/Open Format/Open Firmware/ To be more specific, just write of_platform framework. Note that we still get resources without passing the names, they are just not named in that case and have to be retrieved by index. You should also document the strings in the binding document. ARnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones --- arch/arm/boot/dts/dbx5x0.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index aaa63d0..0f462b7 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -186,6 +186,7 @@ compatible = "stericsson,db8500-dma40", "stericsson,dma40"; reg = <0x801C 0x1000 0x4001 0x800>; + reg-names = "base", "lcpa"; interrupts = <0 25 0x4>; }; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/dbx5x0.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index aaa63d0..0f462b7 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -186,6 +186,7 @@ compatible = stericsson,db8500-dma40, stericsson,dma40; reg = 0x801C 0x1000 0x4001 0x800; + reg-names = base, lcpa; interrupts = 0 25 0x4; }; -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thursday 18 April 2013, Lee Jones wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org Typo: s/Open Format/Open Firmware/ To be more specific, just write of_platform framework. Note that we still get resources without passing the names, they are just not named in that case and have to be retrieved by index. You should also document the strings in the binding document. ARnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 18 Apr 2013, Arnd Bergmann wrote: On Thursday 18 April 2013, Lee Jones wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org Typo: s/Open Format/Open Firmware/ To be more specific, just write of_platform framework. Note that we still get resources without passing the names, they are just not named in that case and have to be retrieved by index. Okay, I'll fixup. You should also document the strings in the binding document. I'll do that, thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
On Thu, 18 Apr 2013, Arnd Bergmann wrote: On Thursday 18 April 2013, Lee Jones wrote: The DMA40 controller uses two sets of base addresses. In order to have them automatically setup as resources by the Open Format framework we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. Signed-off-by: Lee Jones lee.jo...@linaro.org Typo: s/Open Format/Open Firmware/ To be more specific, just write of_platform framework. Note that we still get resources without passing the names, they are just not named in that case and have to be retrieved by index. Changed to: The DMA40 controller uses two sets of base addresses. In order to have the resources setup by the of_platform framework so they are searchable by name instead of index, we have to set names for them. The names have to be the same as the ones used to fetch them back out of the resource structure. You should also document the strings in the binding document. Done. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
