Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-10-06 Thread Fabien Lahoudere 

Hi,

On 30/09/16 19:35, Geert Uytterhoeven wrote:

On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
 wrote:

Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:



- "exar,xra1403" : a GPIO expander


Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403



Good idea, however we have to measure impact of this change on the project.

Thanks

Fabien


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-10-06 Thread Fabien Lahoudere 

Hi,

On 30/09/16 19:35, Geert Uytterhoeven wrote:

On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
 wrote:

Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:



- "exar,xra1403" : a GPIO expander


Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403



Good idea, however we have to measure impact of this change on the project.

Thanks

Fabien


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Geert Uytterhoeven 
On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
 wrote:
> Entries are needed in the spidev ID list to configure configure it from a
> device tree. Add entries for the following devices:

> - "exar,xra1403" : a GPIO expander

Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Geert Uytterhoeven 
On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
 wrote:
> Entries are needed in the spidev ID list to configure configure it from a
> device tree. Add entries for the following devices:

> - "exar,xra1403" : a GPIO expander

Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Mark Brown 
On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:

> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip

> + { .compatible = "fsl,MK20FN1M0VMD12" },

This compatible is in uppercase which is not the normal style for DT
bindings at all.  I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.


signature.asc
Description: PGP signature

Re: [PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Mark Brown 
On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:

> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip

> + { .compatible = "fsl,MK20FN1M0VMD12" },

This compatible is in uppercase which is not the normal style for DT
bindings at all.  I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.


signature.asc
Description: PGP signature

[PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Fabien Lahoudere 
Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:
- "fsl,mk20fn1m0vmd12" : a cortex m4 based chip
- "exar,xra1403" : a GPIO expander

Signed-off-by: Fabien Lahoudere 
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e05046..821937a 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -696,6 +696,8 @@ static struct class *spidev_class;
 static const struct of_device_id spidev_dt_ids[] = {
{ .compatible = "rohm,dh2228fv" },
{ .compatible = "lineartechnology,ltc2488" },
+   { .compatible = "fsl,MK20FN1M0VMD12" },
+   { .compatible = "exar,xra1403" },
{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
2.1.4

[PATCH 1/1] Add devices to spidev device tree compatibility list

2016-09-30 Thread Fabien Lahoudere 
Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:
- "fsl,mk20fn1m0vmd12" : a cortex m4 based chip
- "exar,xra1403" : a GPIO expander

Signed-off-by: Fabien Lahoudere 
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e05046..821937a 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -696,6 +696,8 @@ static struct class *spidev_class;
 static const struct of_device_id spidev_dt_ids[] = {
{ .compatible = "rohm,dh2228fv" },
{ .compatible = "lineartechnology,ltc2488" },
+   { .compatible = "fsl,MK20FN1M0VMD12" },
+   { .compatible = "exar,xra1403" },
{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
2.1.4