Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, 2015-08-08 at 08:42 -0700, Greg KH wrote: > Greg does not accept drivers/staging/media/* patches, You could change --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 111a6b2..089c458 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9742,6 +9742,7 @@ T:git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git L: de...@driverdev.osuosl.org S: Supported F: drivers/staging/ +X: drivers/staging/media/ STAGING - COMEDI M: Ian Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, Aug 08, 2015 at 03:42:18PM +0530, Sudip Mukherjee wrote: > On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: > > > > On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: > > > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > > > > > > > > Thanks for pointing it out. > > Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters > > warning detected by the script. > > This time I fixed up the indentation issue claimed in the previous one. > > Signed-off-by: Junsu Shin > > --- > Greg will not accept patches like this way. please send it as v2. Greg does not accept drivers/staging/media/* patches, but anyway, no one will accept a patch in this format, as you say. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: > > On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: > > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > > > > Thanks for pointing it out. > Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters > warning detected by the script. > This time I fixed up the indentation issue claimed in the previous one. > Signed-off-by: Junsu Shin > --- Greg will not accept patches like this way. please send it as v2. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: >> This is a patch to the dm365_ipipe.c that fixes over 80 characters warning >> detected by checkpatch.pl. >> Signed-off-by: Junsu Shin > please do not use whitespace before Signed-off-by: line. >> >> --- >> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c >> b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c >> index 1bbb90c..57cd274 100644 >> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c >> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c >> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct >> v4l2_subdev_pad_config *cfg, >> * @fse: pointer to v4l2_subdev_frame_size_enum structure. >> */ >> static int >> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config >> *cfg, >> - struct v4l2_subdev_frame_size_enum *fse) >> +ipipe_enum_frame_size(struct v4l2_subdev *sd, >> +struct v4l2_subdev_pad_config *cfg, >> +struct v4l2_subdev_frame_size_enum *fse) > since you are modifying this line, please fix up the indention also. > > regards > sudip > Thanks for pointing it out. Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script. This time I fixed up the indentation issue claimed in the previous one. Signed-off-by: Junsu Shin --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..a474adf 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) { struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt format; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl. Signed-off-by: Junsu Shin jjun...@gmail.com please do not use whitespace before Signed-off-by: line. --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..57cd274 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, +struct v4l2_subdev_pad_config *cfg, +struct v4l2_subdev_frame_size_enum *fse) since you are modifying this line, please fix up the indention also. regards sudip Thanks for pointing it out. Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script. This time I fixed up the indentation issue claimed in the previous one. Signed-off-by: Junsu Shin jjun...@gmail.com --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..a474adf 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) { struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt format; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: snip Thanks for pointing it out. Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script. This time I fixed up the indentation issue claimed in the previous one. Signed-off-by: Junsu Shin jjun...@gmail.com --- Greg will not accept patches like this way. please send it as v2. regards sudip -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, Aug 08, 2015 at 03:42:18PM +0530, Sudip Mukherjee wrote: On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: snip Thanks for pointing it out. Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script. This time I fixed up the indentation issue claimed in the previous one. Signed-off-by: Junsu Shin jjun...@gmail.com --- Greg will not accept patches like this way. please send it as v2. Greg does not accept drivers/staging/media/* patches, but anyway, no one will accept a patch in this format, as you say. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Sat, 2015-08-08 at 08:42 -0700, Greg KH wrote: Greg does not accept drivers/staging/media/* patches, You could change --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 111a6b2..089c458 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9742,6 +9742,7 @@ T:git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git L: de...@driverdev.osuosl.org S: Supported F: drivers/staging/ +X: drivers/staging/media/ STAGING - COMEDI M: Ian Abbott abbo...@mev.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > This is a patch to the dm365_ipipe.c that fixes over 80 characters warning > detected by checkpatch.pl. > Signed-off-by: Junsu Shin please do not use whitespace before Signed-off-by: line. > > --- > drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > index 1bbb90c..57cd274 100644 > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct > v4l2_subdev_pad_config *cfg, > * @fse: pointer to v4l2_subdev_frame_size_enum structure. > */ > static int > -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config > *cfg, > - struct v4l2_subdev_frame_size_enum *fse) > +ipipe_enum_frame_size(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_size_enum *fse) since you are modifying this line, please fix up the indention also. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl. Signed-off-by: Junsu Shin --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..57cd274 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) { struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt format; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl. Signed-off-by: Junsu Shin jjun...@gmail.com --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..57cd274 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) { struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt format; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl. Signed-off-by: Junsu Shin jjun...@gmail.com please do not use whitespace before Signed-off-by: line. --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..57cd274 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum structure. */ static int -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +ipipe_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) since you are modifying this line, please fix up the indention also. regards sudip -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/