Re: [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
On Mon, Jan 21, 2013 at 05:15:49PM +0530, Sachin Kamat wrote: > 'exynos_rng_pm_ops' is used only in this file. Without this patch > we get the following sparse warning: > drivers/char/hw_random/exynos-rng.c:165:1: warning: > symbol 'exynos_rng_pm_ops' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > Cc: Jonghwa Lee > --- > drivers/char/hw_random/exynos-rng.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Sorry, someone else already sent in this patch on Saturday. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
'exynos_rng_pm_ops' is used only in this file. Without this patch we get the following sparse warning: drivers/char/hw_random/exynos-rng.c:165:1: warning: symbol 'exynos_rng_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat Cc: Jonghwa Lee --- drivers/char/hw_random/exynos-rng.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c index 48bbfec..2a4a86d 100644 --- a/drivers/char/hw_random/exynos-rng.c +++ b/drivers/char/hw_random/exynos-rng.c @@ -162,7 +162,7 @@ static int exynos_rng_runtime_resume(struct device *dev) } -UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend, +static UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend, exynos_rng_runtime_resume, NULL); static struct platform_driver exynos_rng_driver = { -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
'exynos_rng_pm_ops' is used only in this file. Without this patch we get the following sparse warning: drivers/char/hw_random/exynos-rng.c:165:1: warning: symbol 'exynos_rng_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jonghwa Lee jonghwa3@samsung.com --- drivers/char/hw_random/exynos-rng.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c index 48bbfec..2a4a86d 100644 --- a/drivers/char/hw_random/exynos-rng.c +++ b/drivers/char/hw_random/exynos-rng.c @@ -162,7 +162,7 @@ static int exynos_rng_runtime_resume(struct device *dev) } -UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend, +static UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend, exynos_rng_runtime_resume, NULL); static struct platform_driver exynos_rng_driver = { -- 1.7.4.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
On Mon, Jan 21, 2013 at 05:15:49PM +0530, Sachin Kamat wrote: 'exynos_rng_pm_ops' is used only in this file. Without this patch we get the following sparse warning: drivers/char/hw_random/exynos-rng.c:165:1: warning: symbol 'exynos_rng_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jonghwa Lee jonghwa3@samsung.com --- drivers/char/hw_random/exynos-rng.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Sorry, someone else already sent in this patch on Saturday. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/