Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
From: Zhu Yanjun Date: Wed, 20 Aug 2014 17:31:43 +0800 > Since the transport has always been in state SCTP_UNCONFIRMED, it > therefore wasn't active before and hasn't been used before, and it > always has been, so it is unnecessary to bug the user with a > notification. > > Reported-by: Deepak Khandelwal > Suggested-by: Vlad Yasevich > Suggested-by: Michael Tuexen > Suggested-by: Daniel Borkmann > Signed-off-by: Zhu Yanjun Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/20/2014 11:31 AM, Zhu Yanjun wrote: Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Suggested-by: Daniel Borkmann Signed-off-by: Zhu Yanjun Looks a bit better, thanks! Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/20/2014 11:31 AM, Zhu Yanjun wrote: Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal khandelwal.deepak.1...@gmail.com Suggested-by: Vlad Yasevich vyasev...@gmail.com Suggested-by: Michael Tuexen tue...@fh-muenster.de Suggested-by: Daniel Borkmann dbork...@redhat.com Signed-off-by: Zhu Yanjun yanjun@windriver.com Looks a bit better, thanks! Acked-by: Daniel Borkmann dbork...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
From: Zhu Yanjun zyjzyj2...@gmail.com Date: Wed, 20 Aug 2014 17:31:43 +0800 Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal khandelwal.deepak.1...@gmail.com Suggested-by: Vlad Yasevich vyasev...@gmail.com Suggested-by: Michael Tuexen tue...@fh-muenster.de Suggested-by: Daniel Borkmann dbork...@redhat.com Signed-off-by: Zhu Yanjun yanjun@windriver.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/20/2014 05:31 AM, Zhu Yanjun wrote:
> Since the transport has always been in state SCTP_UNCONFIRMED, it
> therefore wasn't active before and hasn't been used before, and it
> always has been, so it is unnecessary to bug the user with a
> notification.
>
> Reported-by: Deepak Khandelwal
> Suggested-by: Vlad Yasevich
> Suggested-by: Michael Tuexen
> Suggested-by: Daniel Borkmann
> Signed-off-by: Zhu Yanjun
Acked-by: Vlad Yasevich
Thanks
-vlad
> ---
> net/sctp/associola.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index 9de23a2..2e23f6b 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
> *asoc,
> else {
> dst_release(transport->dst);
> transport->dst = NULL;
> + ulp_notify = false;
> }
>
> spc_state = SCTP_ADDR_UNREACHABLE;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
Since the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and it
always has been, so it is unnecessary to bug the user with a
notification.
Reported-by: Deepak Khandelwal
Suggested-by: Vlad Yasevich
Suggested-by: Michael Tuexen
Suggested-by: Daniel Borkmann
Signed-off-by: Zhu Yanjun
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport->dst);
transport->dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
Since the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and it
always has been, so it is unnecessary to bug the user with a
notification.
Reported-by: Deepak Khandelwal khandelwal.deepak.1...@gmail.com
Suggested-by: Vlad Yasevich vyasev...@gmail.com
Suggested-by: Michael Tuexen tue...@fh-muenster.de
Suggested-by: Daniel Borkmann dbork...@redhat.com
Signed-off-by: Zhu Yanjun yanjun@windriver.com
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport-dst);
transport-dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/20/2014 05:31 AM, Zhu Yanjun wrote:
Since the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and it
always has been, so it is unnecessary to bug the user with a
notification.
Reported-by: Deepak Khandelwal khandelwal.deepak.1...@gmail.com
Suggested-by: Vlad Yasevich vyasev...@gmail.com
Suggested-by: Michael Tuexen tue...@fh-muenster.de
Suggested-by: Daniel Borkmann dbork...@redhat.com
Signed-off-by: Zhu Yanjun yanjun@windriver.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
Thanks
-vlad
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport-dst);
transport-dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/15/2014 11:27 AM, Zhu Yanjun wrote:
When a failed probe comes along UNCONFIRMED path, it is not necessary
to send SCTP_PEER_ADDR_CHANGE notification.
I do not find this in the RFC, but it seems reasonable - at least, I would
have liked to see a more elaborate commit message from you explaining why
it's okay to do; at least RFC6458 I read:
SCTP_ADDR_UNREACHABLE:
The address specified can no longer be reached. Any data sent
to this address is rerouted to an alternate until this address
becomes reachable. This notification is provided whenever an
address *becomes* unreachable.
Given that the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and one could
argue that it doesn't "become" "unreachable" but always has been, so we
wouldn't need to bug the user with a notification about it.
Reported-by: DEEPAK KHANDELWAL
Nit: please write names normally: Deepak Khandelwal
Suggested-by: Vlad Yasevich
Suggested-by: Michael Tuexen
Signed-off-by: Zhu Yanjun
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport->dst);
transport->dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
On 08/15/2014 11:27 AM, Zhu Yanjun wrote:
When a failed probe comes along UNCONFIRMED path, it is not necessary
to send SCTP_PEER_ADDR_CHANGE notification.
I do not find this in the RFC, but it seems reasonable - at least, I would
have liked to see a more elaborate commit message from you explaining why
it's okay to do; at least RFC6458 I read:
SCTP_ADDR_UNREACHABLE:
The address specified can no longer be reached. Any data sent
to this address is rerouted to an alternate until this address
becomes reachable. This notification is provided whenever an
address *becomes* unreachable.
Given that the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and one could
argue that it doesn't become unreachable but always has been, so we
wouldn't need to bug the user with a notification about it.
Reported-by: DEEPAK KHANDELWAL khandelwal.deepak.1...@gmail.com
Nit: please write names normally: Deepak Khandelwal
Suggested-by: Vlad Yasevich vyasev...@gmail.com
Suggested-by: Michael Tuexen tue...@fh-muenster.de
Signed-off-by: Zhu Yanjun yanjun@windriver.com
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport-dst);
transport-dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
When a failed probe comes along UNCONFIRMED path, it is not necessary
to send SCTP_PEER_ADDR_CHANGE notification.
Reported-by: DEEPAK KHANDELWAL
Suggested-by: Vlad Yasevich
Suggested-by: Michael Tuexen
Signed-off-by: Zhu Yanjun
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport->dst);
transport->dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
When a failed probe comes along UNCONFIRMED path, it is not necessary
to send SCTP_PEER_ADDR_CHANGE notification.
Reported-by: DEEPAK KHANDELWAL khandelwal.deepak.1...@gmail.com
Suggested-by: Vlad Yasevich vyasev...@gmail.com
Suggested-by: Michael Tuexen tue...@fh-muenster.de
Signed-off-by: Zhu Yanjun yanjun@windriver.com
---
net/sctp/associola.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association
*asoc,
else {
dst_release(transport-dst);
transport-dst = NULL;
+ ulp_notify = false;
}
spc_state = SCTP_ADDR_UNREACHABLE;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
