Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

On 12/06/2016 11:00 PM, Maxime Ripard wrote:

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.


Got it. Thanks! Please just ignore my patches.

Best regards,
Milo

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

On 12/06/2016 11:00 PM, Maxime Ripard wrote:

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.


Got it. Thanks! Please just ignore my patches.

Best regards,
Milo

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Maxime Ripard]

On Tue, Dec 06, 2016 at 04:23:57PM +0900, Milo Kim wrote:
> On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> > On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> > > The board has DDR3 512MB. This patch helps scanning the memory and
> > > adding memblock through the DT.
> > > 
> > > Signed-off-by: Milo Kim 
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
> > > b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > index ec63d10..be3668f 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > @@ -45,6 +45,11 @@
> > >  / {
> > >   model = "FriendlyArm NanoPi M1";
> > >   compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> > > +
> > > + memory@4000 {
> > > + device_type = "memory";
> > > + reg = <0x4000 0x2000>;
> > > + };
> > 
> > U-boot will fill that up, so there's no need to put it there.
> 
> Right, my intention was adding memblock through the DT whether the bootload
> does or not. However I'm not sure the situation (missing memblock in u-boot)
> could really happen.

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Maxime Ripard]

On Tue, Dec 06, 2016 at 04:23:57PM +0900, Milo Kim wrote:
> On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> > On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> > > The board has DDR3 512MB. This patch helps scanning the memory and
> > > adding memblock through the DT.
> > > 
> > > Signed-off-by: Milo Kim 
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
> > > b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > index ec63d10..be3668f 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > @@ -45,6 +45,11 @@
> > >  / {
> > >   model = "FriendlyArm NanoPi M1";
> > >   compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> > > +
> > > + memory@4000 {
> > > + device_type = "memory";
> > > + reg = <0x4000 0x2000>;
> > > + };
> > 
> > U-boot will fill that up, so there's no need to put it there.
> 
> Right, my intention was adding memblock through the DT whether the bootload
> does or not. However I'm not sure the situation (missing memblock in u-boot)
> could really happen.

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

On 12/05/2016 05:09 PM, Maxime Ripard wrote:

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:

The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim 
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
model = "FriendlyArm NanoPi M1";
compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+   memory@4000 {
+   device_type = "memory";
+   reg = <0x4000 0x2000>;
+   };


U-boot will fill that up, so there's no need to put it there.


Right, my intention was adding memblock through the DT whether the 
bootload does or not. However I'm not sure the situation (missing 
memblock in u-boot) could really happen.


Best regards,
Milo

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

On 12/05/2016 05:09 PM, Maxime Ripard wrote:

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:

The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim 
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
model = "FriendlyArm NanoPi M1";
compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+   memory@4000 {
+   device_type = "memory";
+   reg = <0x4000 0x2000>;
+   };


U-boot will fill that up, so there's no need to put it there.


Right, my intention was adding memblock through the DT whether the 
bootload does or not. However I'm not sure the situation (missing 
memblock in u-boot) could really happen.


Best regards,
Milo

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Maxime Ripard]

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> The board has DDR3 512MB. This patch helps scanning the memory and
> adding memblock through the DT.
> 
> Signed-off-by: Milo Kim 
> ---
>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
> b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> index ec63d10..be3668f 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> @@ -45,6 +45,11 @@
>  / {
>   model = "FriendlyArm NanoPi M1";
>   compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> +
> + memory@4000 {
> + device_type = "memory";
> + reg = <0x4000 0x2000>;
> + };

U-boot will fill that up, so there's no need to put it there.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Maxime Ripard]

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> The board has DDR3 512MB. This patch helps scanning the memory and
> adding memblock through the DT.
> 
> Signed-off-by: Milo Kim 
> ---
>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
> b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> index ec63d10..be3668f 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> @@ -45,6 +45,11 @@
>  / {
>   model = "FriendlyArm NanoPi M1";
>   compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> +
> + memory@4000 {
> + device_type = "memory";
> + reg = <0x4000 0x2000>;
> + };

U-boot will fill that up, so there's no need to put it there.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

[PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim 
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
model = "FriendlyArm NanoPi M1";
compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+   memory@4000 {
+   device_type = "memory";
+   reg = <0x4000 0x2000>;
+   };
 };
 
  {
-- 
2.9.3

[PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

[Milo Kim]

The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim 
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts 
b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
model = "FriendlyArm NanoPi M1";
compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+   memory@4000 {
+   device_type = "memory";
+   reg = <0x4000 0x2000>;
+   };
 };
 
  {
-- 
2.9.3