Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-11 Thread Pushkar Jambhlekar 
Thanks Dan!

On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams  wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
>  wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to 
>> avoid this situation
>>
>> Signed-off-by: Pushkar Jambhlekar 
>> ---
>>  drivers/dax/dax.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
>> index 0d1ca24..fd9c4db 100644
>> --- a/drivers/dax/dax.c
>> +++ b/drivers/dax/dax.c
>> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
>> rc = __dax_dev_pud_fault(dax_dev, vmf);
>> break;
>> default:
>> -   return VM_FAULT_FALLBACK;
>> +   rc = VM_FAULT_FALLBACK;
>> }
>> rcu_read_unlock();
>
> Thanks Pushkar, I'll apply this and combine with patch 2 as well.



-- 
Jambhlekar Pushkar Arun

Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-11 Thread Pushkar Jambhlekar 
Thanks Dan!

On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams  wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
>  wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to 
>> avoid this situation
>>
>> Signed-off-by: Pushkar Jambhlekar 
>> ---
>>  drivers/dax/dax.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
>> index 0d1ca24..fd9c4db 100644
>> --- a/drivers/dax/dax.c
>> +++ b/drivers/dax/dax.c
>> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
>> rc = __dax_dev_pud_fault(dax_dev, vmf);
>> break;
>> default:
>> -   return VM_FAULT_FALLBACK;
>> +   rc = VM_FAULT_FALLBACK;
>> }
>> rcu_read_unlock();
>
> Thanks Pushkar, I'll apply this and combine with patch 2 as well.



-- 
Jambhlekar Pushkar Arun

Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-11 Thread Dan Williams 
On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
 wrote:
> dax_dev_huge_fault returning without releasing lock. Making code change to 
> avoid this situation
>
> Signed-off-by: Pushkar Jambhlekar 
> ---
>  drivers/dax/dax.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0d1ca24..fd9c4db 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
> rc = __dax_dev_pud_fault(dax_dev, vmf);
> break;
> default:
> -   return VM_FAULT_FALLBACK;
> +   rc = VM_FAULT_FALLBACK;
> }
> rcu_read_unlock();

Thanks Pushkar, I'll apply this and combine with patch 2 as well.

Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-11 Thread Dan Williams 
On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
 wrote:
> dax_dev_huge_fault returning without releasing lock. Making code change to 
> avoid this situation
>
> Signed-off-by: Pushkar Jambhlekar 
> ---
>  drivers/dax/dax.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0d1ca24..fd9c4db 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
> rc = __dax_dev_pud_fault(dax_dev, vmf);
> break;
> default:
> -   return VM_FAULT_FALLBACK;
> +   rc = VM_FAULT_FALLBACK;
> }
> rcu_read_unlock();

Thanks Pushkar, I'll apply this and combine with patch 2 as well.

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4

[PATCH 1/2] drivers/dax: Avoiding potential deadlock

2017-04-10 Thread Pushkar Jambhlekar 
dax_dev_huge_fault returning without releasing lock. Making code change to 
avoid this situation

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
-   return VM_FAULT_FALLBACK;
+   rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
 
-- 
2.7.4