Re: [PATCH 1/2] null_blk: Remove null block from list in error path
On 12/09/2015 06:21 AM, Minfei Huang wrote: Ping. Any comment is appreciate. Thanks Minfei That'll work. Thanks for fixing up my mistake. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] null_blk: Remove null block from list in error path
Ping. Any comment is appreciate. Thanks Minfei On 11/27/15 at 09:26pm, Minfei Huang wrote: > To make consistent of null block list, we should remove enqueued null > block from the list before freeing it. > > Signed-off-by: Minfei Huang > --- > drivers/block/null_blk.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c > index ec99568..729ecd7 100644 > --- a/drivers/block/null_blk.c > +++ b/drivers/block/null_blk.c > @@ -738,7 +738,7 @@ static int null_add_dev(void) > rv = nvm_register(nullb->q, nullb->disk_name, > &null_lnvm_dev_ops); > if (rv) > - goto out_cleanup_blk_queue; > + goto out_cleanup_blk_list; > goto done; > } > > @@ -765,6 +765,10 @@ done: > out_cleanup_lightnvm: > if (use_lightnvm) > nvm_unregister(nullb->disk_name); > +out_cleanup_blk_list: > + mutex_lock(&lock); > + list_del_init(&nullb->list); > + mutex_unlock(&lock); > out_cleanup_blk_queue: > blk_cleanup_queue(nullb->q); > out_cleanup_tags: > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] null_blk: Remove null block from list in error path
To make consistent of null block list, we should remove enqueued null block from the list before freeing it. Signed-off-by: Minfei Huang --- drivers/block/null_blk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index ec99568..729ecd7 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -738,7 +738,7 @@ static int null_add_dev(void) rv = nvm_register(nullb->q, nullb->disk_name, &null_lnvm_dev_ops); if (rv) - goto out_cleanup_blk_queue; + goto out_cleanup_blk_list; goto done; } @@ -765,6 +765,10 @@ done: out_cleanup_lightnvm: if (use_lightnvm) nvm_unregister(nullb->disk_name); +out_cleanup_blk_list: + mutex_lock(&lock); + list_del_init(&nullb->list); + mutex_unlock(&lock); out_cleanup_blk_queue: blk_cleanup_queue(nullb->q); out_cleanup_tags: -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
