Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
* Gu Zheng wrote:
> Hi Ingo,
> On 01/28/2014 07:48 PM, Ingo Molnar wrote:
>
> >
> > * David Rientjes wrote:
> >
> >> On Tue, 28 Jan 2014, Tang Chen wrote:
> >>
> >>> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
> >>> was not initialized. So we need to initialize it.
> >>>
> >>> Signed-off-by: Tang Chen
> >>> Tested-by: Gu Zheng
> >>
> >> Reported-by: David Rientjes
> >
> > Agreed. Tang Chen, please also spell it out in the changelog:
> >
> >David Rientjes reported a boot crash, caused by
> >commit XYZ ("foo: bar").
> >
> > I find it somewhat annoying that you found time to credit a corporate
> > collegue with a Tested-by tag, who didn't even reply to the whole
> > thread to indicate his testing efforts,
>
> Sorry for missing to indicate the test result, because I am really
> busy with some thorny issues. If Tang did not remind me, maybe I'll
> miss the whole thread. But I think the "Tested-by:" is the best
> confirmation of the testing efforts, it indicates that the guy has
> nearly completely tested the patch on his environment.
Thanks for the effort!
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
Hi Ingo,
On 01/28/2014 07:48 PM, Ingo Molnar wrote:
>
> * David Rientjes wrote:
>
>> On Tue, 28 Jan 2014, Tang Chen wrote:
>>
>>> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
>>> was not initialized. So we need to initialize it.
>>>
>>> Signed-off-by: Tang Chen
>>> Tested-by: Gu Zheng
>>
>> Reported-by: David Rientjes
>
> Agreed. Tang Chen, please also spell it out in the changelog:
>
>David Rientjes reported a boot crash, caused by
>commit XYZ ("foo: bar").
>
> I find it somewhat annoying that you found time to credit a corporate
> collegue with a Tested-by tag, who didn't even reply to the whole
> thread to indicate his testing efforts,
Sorry for missing to indicate the test result, because I am really busy with
some thorny issues. If Tang did not remind me, maybe I'll miss the whole thread.
But I think the "Tested-by:" is the best confirmation of the testing efforts,
it indicates that the guy has nearly completely tested the patch on his
environment.
Thanks,
Gu
> but you didn't find the time
> to credit the original reporter of the bug who also reviewed your
> patches ...
>
> Thanks,
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On 01/28/2014 07:48 PM, Ingo Molnar wrote:
* David Rientjes wrote:
On Tue, 28 Jan 2014, Tang Chen wrote:
On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
was not initialized. So we need to initialize it.
Signed-off-by: Tang Chen
Tested-by: Gu Zheng
Reported-by: David Rientjes
Agreed. Tang Chen, please also spell it out in the changelog:
David Rientjes reported a boot crash, caused by
commit XYZ ("foo: bar").
I find it somewhat annoying that you found time to credit a corporate
collegue with a Tested-by tag, who didn't even reply to the whole
thread to indicate his testing efforts, but you didn't find the time
to credit the original reporter of the bug who also reviewed your
patches ...
Hi David, Ingo,
I'm sorry for the missing original reporter. I was paying so much attention
to the second patch. And Andrew has added the missing info and committed
the patch. :)
Thanks.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
* David Rientjes wrote:
> On Tue, 28 Jan 2014, Tang Chen wrote:
>
> > On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
> > was not initialized. So we need to initialize it.
> >
> > Signed-off-by: Tang Chen
> > Tested-by: Gu Zheng
>
> Reported-by: David Rientjes
Agreed. Tang Chen, please also spell it out in the changelog:
David Rientjes reported a boot crash, caused by
commit XYZ ("foo: bar").
I find it somewhat annoying that you found time to credit a corporate
collegue with a Tested-by tag, who didn't even reply to the whole
thread to indicate his testing efforts, but you didn't find the time
to credit the original reporter of the bug who also reviewed your
patches ...
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On Tue, 28 Jan 2014, Tang Chen wrote: > On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() > was not initialized. So we need to initialize it. > > Signed-off-by: Tang Chen > Tested-by: Gu Zheng Reported-by: David Rientjes > --- > arch/x86/mm/numa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 81b2750..00c9f09 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -569,6 +569,8 @@ static void __init numa_clear_kernel_node_hotplug(void) > unsigned long start, end; > struct memblock_type *type = > > + nodes_clear(numa_kernel_nodes) Just initialize it with NODE_MASK_NONE. > + > /* Mark all kernel nodes. */ > for (i = 0; i < type->cnt; i++) > node_set(type->regions[i].nid, numa_kernel_nodes); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen Tested-by: Gu Zheng --- arch/x86/mm/numa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c index 81b2750..00c9f09 100644 --- a/arch/x86/mm/numa.c +++ b/arch/x86/mm/numa.c @@ -569,6 +569,8 @@ static void __init numa_clear_kernel_node_hotplug(void) unsigned long start, end; struct memblock_type *type = + nodes_clear(numa_kernel_nodes); + /* Mark all kernel nodes. */ for (i = 0; i < type->cnt; i++) node_set(type->regions[i].nid, numa_kernel_nodes); -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Tested-by: Gu Zheng guz.f...@cn.fujitsu.com --- arch/x86/mm/numa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c index 81b2750..00c9f09 100644 --- a/arch/x86/mm/numa.c +++ b/arch/x86/mm/numa.c @@ -569,6 +569,8 @@ static void __init numa_clear_kernel_node_hotplug(void) unsigned long start, end; struct memblock_type *type = memblock.reserved; + nodes_clear(numa_kernel_nodes); + /* Mark all kernel nodes. */ for (i = 0; i type-cnt; i++) node_set(type-regions[i].nid, numa_kernel_nodes); -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On Tue, 28 Jan 2014, Tang Chen wrote: On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Tested-by: Gu Zheng guz.f...@cn.fujitsu.com Reported-by: David Rientjes rient...@google.com --- arch/x86/mm/numa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c index 81b2750..00c9f09 100644 --- a/arch/x86/mm/numa.c +++ b/arch/x86/mm/numa.c @@ -569,6 +569,8 @@ static void __init numa_clear_kernel_node_hotplug(void) unsigned long start, end; struct memblock_type *type = memblock.reserved; + nodes_clear(numa_kernel_nodes) Just initialize it with NODE_MASK_NONE. + /* Mark all kernel nodes. */ for (i = 0; i type-cnt; i++) node_set(type-regions[i].nid, numa_kernel_nodes); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
* David Rientjes rient...@google.com wrote: On Tue, 28 Jan 2014, Tang Chen wrote: On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Tested-by: Gu Zheng guz.f...@cn.fujitsu.com Reported-by: David Rientjes rient...@google.com Agreed. Tang Chen, please also spell it out in the changelog: David Rientjes reported a boot crash, caused by commit XYZ (foo: bar). I find it somewhat annoying that you found time to credit a corporate collegue with a Tested-by tag, who didn't even reply to the whole thread to indicate his testing efforts, but you didn't find the time to credit the original reporter of the bug who also reviewed your patches ... Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
On 01/28/2014 07:48 PM, Ingo Molnar wrote: * David Rientjesrient...@google.com wrote: On Tue, 28 Jan 2014, Tang Chen wrote: On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chentangc...@cn.fujitsu.com Tested-by: Gu Zhengguz.f...@cn.fujitsu.com Reported-by: David Rientjesrient...@google.com Agreed. Tang Chen, please also spell it out in the changelog: David Rientjes reported a boot crash, caused by commit XYZ (foo: bar). I find it somewhat annoying that you found time to credit a corporate collegue with a Tested-by tag, who didn't even reply to the whole thread to indicate his testing efforts, but you didn't find the time to credit the original reporter of the bug who also reviewed your patches ... Hi David, Ingo, I'm sorry for the missing original reporter. I was paying so much attention to the second patch. And Andrew has added the missing info and committed the patch. :) Thanks. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
Hi Ingo, On 01/28/2014 07:48 PM, Ingo Molnar wrote: * David Rientjes rient...@google.com wrote: On Tue, 28 Jan 2014, Tang Chen wrote: On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Tested-by: Gu Zheng guz.f...@cn.fujitsu.com Reported-by: David Rientjes rient...@google.com Agreed. Tang Chen, please also spell it out in the changelog: David Rientjes reported a boot crash, caused by commit XYZ (foo: bar). I find it somewhat annoying that you found time to credit a corporate collegue with a Tested-by tag, who didn't even reply to the whole thread to indicate his testing efforts, Sorry for missing to indicate the test result, because I am really busy with some thorny issues. If Tang did not remind me, maybe I'll miss the whole thread. But I think the Tested-by: is the best confirmation of the testing efforts, it indicates that the guy has nearly completely tested the patch on his environment. Thanks, Gu but you didn't find the time to credit the original reporter of the bug who also reviewed your patches ... Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().
* Gu Zheng guz.f...@cn.fujitsu.com wrote: Hi Ingo, On 01/28/2014 07:48 PM, Ingo Molnar wrote: * David Rientjes rient...@google.com wrote: On Tue, 28 Jan 2014, Tang Chen wrote: On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() was not initialized. So we need to initialize it. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Tested-by: Gu Zheng guz.f...@cn.fujitsu.com Reported-by: David Rientjes rient...@google.com Agreed. Tang Chen, please also spell it out in the changelog: David Rientjes reported a boot crash, caused by commit XYZ (foo: bar). I find it somewhat annoying that you found time to credit a corporate collegue with a Tested-by tag, who didn't even reply to the whole thread to indicate his testing efforts, Sorry for missing to indicate the test result, because I am really busy with some thorny issues. If Tang did not remind me, maybe I'll miss the whole thread. But I think the Tested-by: is the best confirmation of the testing efforts, it indicates that the guy has nearly completely tested the patch on his environment. Thanks for the effort! Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
