Re: [PATCH 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()

[Heiko Stübner]

Am Montag, 25. Mai 2020, 06:08:58 CEST schrieb Tiezhu Yang:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
> 
> Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL 
> PHY")
> Signed-off-by: Tiezhu Yang 

Reviewed-by: Heiko Stuebner 

[PATCH 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()

[Tiezhu Yang]

When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL 
PHY")
Signed-off-by: Tiezhu Yang 
---
 drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c 
b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index a7c6c94..8af8c6c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -607,8 +607,8 @@ static int inno_dsidphy_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, inno);
 
inno->phy_base = devm_platform_ioremap_resource(pdev, 0);
-   if (!inno->phy_base)
-   return -ENOMEM;
+   if (IS_ERR(inno->phy_base))
+   return PTR_ERR(inno->phy_base);
 
inno->ref_clk = devm_clk_get(dev, "ref");
if (IS_ERR(inno->ref_clk)) {
-- 
2.1.0