Re: [PATCH 1/2] platform/chrome: cros_ec_typec: Parameterize cros_typec_cmds_supported()

[Prashant Malani]

Hi Utkarsh,

On Wed, Dec 09, 2020 at 10:09:02PM -0800, Utkarsh Patel wrote:
> cros_typec_cmds_supported() is currently being used to check only one
> feature flag.
> Add a new feature parameter to it so that it can be used to check
> multiple feature flags supported in cros_ec.
> Rename cros_typec_cmds_supported() to cros_typec_feature_supported().
> 
> Signed-off-by: Utkarsh Patel 
Reviewed-by: Prashant Malani 

Thanks,

-Prashant

[PATCH 1/2] platform/chrome: cros_ec_typec: Parameterize cros_typec_cmds_supported()

[Utkarsh Patel]

cros_typec_cmds_supported() is currently being used to check only one
feature flag.
Add a new feature parameter to it so that it can be used to check
multiple feature flags supported in cros_ec.
Rename cros_typec_cmds_supported() to cros_typec_feature_supported().

Signed-off-by: Utkarsh Patel 
---
 drivers/platform/chrome/cros_ec_typec.c | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c 
b/drivers/platform/chrome/cros_ec_typec.c
index ce031a10eb1b..650aa5332055 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -829,8 +829,8 @@ static int cros_typec_get_cmd_version(struct 
cros_typec_data *typec)
return 0;
 }
 
-/* Check the EC feature flags to see if TYPEC_* commands are supported. */
-static int cros_typec_cmds_supported(struct cros_typec_data *typec)
+/* Check the EC feature flags to see if TYPEC_* features are supported. */
+static int cros_typec_feature_supported(struct cros_typec_data *typec, enum 
ec_feature_code feature)
 {
struct ec_response_get_features resp = {};
int ret;
@@ -839,11 +839,12 @@ static int cros_typec_cmds_supported(struct 
cros_typec_data *typec)
, sizeof(resp));
if (ret < 0) {
dev_warn(typec->dev,
-"Failed to get features, assuming typec commands 
unsupported.\n");
+"Failed to get features, assuming typec feature=%d 
unsupported.\n",
+feature);
return 0;
}
 
-   return resp.flags[EC_FEATURE_TYPEC_CMD / 32] & 
EC_FEATURE_MASK_1(EC_FEATURE_TYPEC_CMD);
+   return resp.flags[feature / 32] & EC_FEATURE_MASK_1(feature);
 }
 
 static void cros_typec_port_work(struct work_struct *work)
@@ -905,7 +906,8 @@ static int cros_typec_probe(struct platform_device *pdev)
return ret;
}
 
-   typec->typec_cmd_supported = !!cros_typec_cmds_supported(typec);
+   typec->typec_cmd_supported = !!cros_typec_feature_supported(typec,
+   EC_FEATURE_TYPEC_CMD);
 
ret = cros_typec_ec_command(typec, 0, EC_CMD_USB_PD_PORTS, NULL, 0,
, sizeof(resp));
-- 
2.25.1