Re: [PATCH 1/2] platform/x86: huawei-wmi: Stricter battery thresholds set

2019-10-20 Thread Andy Shevchenko 
On Sun, Oct 20, 2019 at 3:33 AM  wrote:
> On Sat, 2019-10-19 at 11:31 +0300, Dan Carpenter wrote:
> > On Fri, Oct 18, 2019 at 06:42:13PM -0400, Ayman Bagabas wrote:
> > > Check if battery thresholds are within 0 and 100.

> > Don't forget to add your Signed-off-by: though.

Please, resend all three with properly tagged with Sob, Fixes, etc.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] platform/x86: huawei-wmi: Stricter battery thresholds set

2019-10-19 Thread ayman . bagabas 
On Sat, 2019-10-19 at 11:31 +0300, Dan Carpenter wrote:
> On Fri, Oct 18, 2019 at 06:42:13PM -0400, Ayman Bagabas wrote:
> > Check if battery thresholds are within 0 and 100.
> > ---
> 
> Thanks!
> 
> Don't forget to add your Signed-off-by: though.

Signed-off-by: Ayman Bagabas 

Thank you,
Ayman
> 
> regards,
> dan carpenter
>

Re: [PATCH 1/2] platform/x86: huawei-wmi: Stricter battery thresholds set

2019-10-19 Thread Dan Carpenter 
On Fri, Oct 18, 2019 at 06:42:13PM -0400, Ayman Bagabas wrote:
> Check if battery thresholds are within 0 and 100.
> ---

Thanks!

Don't forget to add your Signed-off-by: though.

regards,
dan carpenter

[PATCH 1/2] platform/x86: huawei-wmi: Stricter battery thresholds set

2019-10-18 Thread Ayman Bagabas 
Check if battery thresholds are within 0 and 100.
---
 drivers/platform/x86/huawei-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/huawei-wmi.c 
b/drivers/platform/x86/huawei-wmi.c
index 5837d1b8693d..26041d44286a 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -345,7 +345,7 @@ static int huawei_wmi_battery_set(int start, int end)
union hwmi_arg arg;
int err;
 
-   if (start < 0 || end > 100)
+   if (start < 0 || end < 0 || start > 100 || end > 100)
return -EINVAL;
 
arg.cmd = BATTERY_THRESH_SET;

base-commit: fd13c8622a5ad4f7317b64de4f6aa2de1962220e
-- 
2.21.0