Re: [PATCH 1/2] regulator: ti-abb: skip optional parameter for ldo-address
On Fri, Sep 27, 2013 at 08:25:13AM -0500, Nishanth Menon wrote: > On platforms like OMAP4460, LDO override is never used. Even though > efuse determines the ABB bias mode to operate at, ABB voltage is > preconfigured in internal efuse registers without the need for > LDO override for bias voltage. So skip optional parameter if > property is not present. Applied, thanks. signature.asc Description: Digital signature
[PATCH 1/2] regulator: ti-abb: skip optional parameter for ldo-address
On platforms like OMAP4460, LDO override is never used. Even though
efuse determines the ABB bias mode to operate at, ABB voltage is
preconfigured in internal efuse registers without the need for
LDO override for bias voltage. So skip optional parameter if
property is not present.
Signed-off-by: Nishanth Menon
---
drivers/regulator/ti-abb-regulator.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/regulator/ti-abb-regulator.c
b/drivers/regulator/ti-abb-regulator.c
index d8e3e12..1e02805 100644
--- a/drivers/regulator/ti-abb-regulator.c
+++ b/drivers/regulator/ti-abb-regulator.c
@@ -765,6 +765,11 @@ static int ti_abb_probe(struct platform_device *pdev)
pname = "ldo-address";
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
+ if (!res) {
+ dev_dbg(dev, "Missing '%s' IO resource\n", pname);
+ ret = -ENODEV;
+ goto skip_opt;
+ }
abb->ldo_base = devm_ioremap_resource(dev, res);
if (IS_ERR(abb->ldo_base)) {
ret = PTR_ERR(abb->ldo_base);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] regulator: ti-abb: skip optional parameter for ldo-address
On platforms like OMAP4460, LDO override is never used. Even though
efuse determines the ABB bias mode to operate at, ABB voltage is
preconfigured in internal efuse registers without the need for
LDO override for bias voltage. So skip optional parameter if
property is not present.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/regulator/ti-abb-regulator.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/regulator/ti-abb-regulator.c
b/drivers/regulator/ti-abb-regulator.c
index d8e3e12..1e02805 100644
--- a/drivers/regulator/ti-abb-regulator.c
+++ b/drivers/regulator/ti-abb-regulator.c
@@ -765,6 +765,11 @@ static int ti_abb_probe(struct platform_device *pdev)
pname = ldo-address;
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
+ if (!res) {
+ dev_dbg(dev, Missing '%s' IO resource\n, pname);
+ ret = -ENODEV;
+ goto skip_opt;
+ }
abb-ldo_base = devm_ioremap_resource(dev, res);
if (IS_ERR(abb-ldo_base)) {
ret = PTR_ERR(abb-ldo_base);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] regulator: ti-abb: skip optional parameter for ldo-address
On Fri, Sep 27, 2013 at 08:25:13AM -0500, Nishanth Menon wrote: On platforms like OMAP4460, LDO override is never used. Even though efuse determines the ABB bias mode to operate at, ABB voltage is preconfigured in internal efuse registers without the need for LDO override for bias voltage. So skip optional parameter if property is not present. Applied, thanks. signature.asc Description: Digital signature
