Re: [PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN
On 2019-06-02 22:07, Joe Perches wrote: On Sun, 2019-06-02 at 18:35 +0200, Michael Straube wrote: ETH_ALEN is defined in linux/if_ether.h which is included by osdep_service.h, so remove the redundant definition from ieee80211.h. [] diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h [] @@ -14,7 +14,6 @@ #define MGMT_QUEUE_NUM 5 -#define ETH_ALEN 6 #define ETH_TYPE_LEN 2 #define PAYLOAD_TYPE_LEN 1 While you're at it: neither ETH_TYPE_LEN nor PAYLOAD_TYPE_LEN appear to be used. They are removed in the second patch of the series.
Re: [PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN
On Sun, 2019-06-02 at 18:35 +0200, Michael Straube wrote: > ETH_ALEN is defined in linux/if_ether.h which is included by > osdep_service.h, so remove the redundant definition from ieee80211.h. [] > diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h > b/drivers/staging/rtl8188eu/include/ieee80211.h [] > @@ -14,7 +14,6 @@ > > #define MGMT_QUEUE_NUM 5 > > -#define ETH_ALEN 6 > #define ETH_TYPE_LEN 2 > #define PAYLOAD_TYPE_LEN 1 While you're at it: neither ETH_TYPE_LEN nor PAYLOAD_TYPE_LEN appear to be used.
[PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN
ETH_ALEN is defined in linux/if_ether.h which is included by osdep_service.h, so remove the redundant definition from ieee80211.h. osdep_service.h:33:#include etherdevice.h:25:#include Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/ieee80211.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h index c60b833ca110..d43aa4304ca5 100644 --- a/drivers/staging/rtl8188eu/include/ieee80211.h +++ b/drivers/staging/rtl8188eu/include/ieee80211.h @@ -14,7 +14,6 @@ #define MGMT_QUEUE_NUM 5 -#define ETH_ALEN 6 #define ETH_TYPE_LEN 2 #define PAYLOAD_TYPE_LEN 1 -- 2.21.0
