Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, Oct 11, 2012 at 10:42:26PM -0400, Steven Rostedt wrote: > On Thu, 2012-10-11 at 19:31 -0700, David Sharp wrote: > > On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt wrote: > > > Sorry, I know this is late, but it was pushed down in my todo list > > > (never off, but something I probably wouldn't have seen for a few more > > > months). > > > > > > On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote: > > >> From: David Sharp > > > > > > If this is from David it needs his SOB. > > > > Is that true even though we are working for the same company? > > > > Yes. > > I would never push a patch from Ingo without his Signed-off-by even > though he and I work for the same company ;-) > > Although, the GPL would let you. But it's best not to do it. I'd say that it is even a no-no. The SOB chain denotes author - possible intermediary handler as in this case - committer and we all feel very strongly (I'm told :-)) about stating the exact origin and path upstream of every patch. So it is not only an authorship issue. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, Oct 11, 2012 at 10:42:26PM -0400, Steven Rostedt wrote: On Thu, 2012-10-11 at 19:31 -0700, David Sharp wrote: On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt rost...@goodmis.org wrote: Sorry, I know this is late, but it was pushed down in my todo list (never off, but something I probably wouldn't have seen for a few more months). On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote: From: David Sharp dhsh...@google.com If this is from David it needs his SOB. Is that true even though we are working for the same company? Yes. I would never push a patch from Ingo without his Signed-off-by even though he and I work for the same company ;-) Although, the GPL would let you. But it's best not to do it. I'd say that it is even a no-no. The SOB chain denotes author - possible intermediary handler as in this case - committer and we all feel very strongly (I'm told :-)) about stating the exact origin and path upstream of every patch. So it is not only an authorship issue. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, 2012-10-11 at 19:31 -0700, David Sharp wrote: > On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt wrote: > > Sorry, I know this is late, but it was pushed down in my todo list > > (never off, but something I probably wouldn't have seen for a few more > > months). > > > > On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote: > >> From: David Sharp > > > > If this is from David it needs his SOB. > > Is that true even though we are working for the same company? > Yes. I would never push a patch from Ingo without his Signed-off-by even though he and I work for the same company ;-) Although, the GPL would let you. But it's best not to do it. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt wrote:
> Sorry, I know this is late, but it was pushed down in my todo list
> (never off, but something I probably wouldn't have seen for a few more
> months).
>
> On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
>> From: David Sharp
>
> If this is from David it needs his SOB.
Is that true even though we are working for the same company?
> -- Steve
>
>>
>> Remove ftrace_format_syscall() declaration; it is neither defined nor
>> used. Also update a comment and formatting.
>>
>> Signed-off-by: Vaibhav Nagarnaik
Signed-off-by: David Sharp
>> ---
>> include/trace/syscall.h|2 --
>> kernel/trace/ring_buffer.c |6 +++---
>> 2 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/trace/syscall.h b/include/trace/syscall.h
>> index 31966a4..0c95796 100644
>> --- a/include/trace/syscall.h
>> +++ b/include/trace/syscall.h
>> @@ -39,8 +39,6 @@ extern int reg_event_syscall_enter(struct
>> ftrace_event_call *call);
>> extern void unreg_event_syscall_enter(struct ftrace_event_call *call);
>> extern int reg_event_syscall_exit(struct ftrace_event_call *call);
>> extern void unreg_event_syscall_exit(struct ftrace_event_call *call);
>> -extern int
>> -ftrace_format_syscall(struct ftrace_event_call *call, struct trace_seq *s);
>> enum print_line_t print_syscall_enter(struct trace_iterator *iter, int
>> flags,
>> struct trace_event *event);
>> enum print_line_t print_syscall_exit(struct trace_iterator *iter, int flags,
>> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
>> index 1d0f6a8..96c2dd1 100644
>> --- a/kernel/trace/ring_buffer.c
>> +++ b/kernel/trace/ring_buffer.c
>> @@ -1816,7 +1816,7 @@ rb_add_time_stamp(struct ring_buffer_event *event, u64
>> delta)
>> }
>>
>> /**
>> - * ring_buffer_update_event - update event type and data
>> + * rb_update_event - update event type and data
>> * @event: the even to update
>> * @type: the type of event
>> * @length: the size of the event field in the ring buffer
>> @@ -2716,8 +2716,8 @@ EXPORT_SYMBOL_GPL(ring_buffer_discard_commit);
>> * and not the length of the event which would hold the header.
>> */
>> int ring_buffer_write(struct ring_buffer *buffer,
>> - unsigned long length,
>> - void *data)
>> + unsigned long length,
>> + void *data)
>> {
>> struct ring_buffer_per_cpu *cpu_buffer;
>> struct ring_buffer_event *event;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
Sorry, I know this is late, but it was pushed down in my todo list
(never off, but something I probably wouldn't have seen for a few more
months).
On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
> From: David Sharp
If this is from David it needs his SOB.
-- Steve
>
> Remove ftrace_format_syscall() declaration; it is neither defined nor
> used. Also update a comment and formatting.
>
> Signed-off-by: Vaibhav Nagarnaik
> ---
> include/trace/syscall.h|2 --
> kernel/trace/ring_buffer.c |6 +++---
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/include/trace/syscall.h b/include/trace/syscall.h
> index 31966a4..0c95796 100644
> --- a/include/trace/syscall.h
> +++ b/include/trace/syscall.h
> @@ -39,8 +39,6 @@ extern int reg_event_syscall_enter(struct ftrace_event_call
> *call);
> extern void unreg_event_syscall_enter(struct ftrace_event_call *call);
> extern int reg_event_syscall_exit(struct ftrace_event_call *call);
> extern void unreg_event_syscall_exit(struct ftrace_event_call *call);
> -extern int
> -ftrace_format_syscall(struct ftrace_event_call *call, struct trace_seq *s);
> enum print_line_t print_syscall_enter(struct trace_iterator *iter, int flags,
> struct trace_event *event);
> enum print_line_t print_syscall_exit(struct trace_iterator *iter, int flags,
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 1d0f6a8..96c2dd1 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -1816,7 +1816,7 @@ rb_add_time_stamp(struct ring_buffer_event *event, u64
> delta)
> }
>
> /**
> - * ring_buffer_update_event - update event type and data
> + * rb_update_event - update event type and data
> * @event: the even to update
> * @type: the type of event
> * @length: the size of the event field in the ring buffer
> @@ -2716,8 +2716,8 @@ EXPORT_SYMBOL_GPL(ring_buffer_discard_commit);
> * and not the length of the event which would hold the header.
> */
> int ring_buffer_write(struct ring_buffer *buffer,
> - unsigned long length,
> - void *data)
> + unsigned long length,
> + void *data)
> {
> struct ring_buffer_per_cpu *cpu_buffer;
> struct ring_buffer_event *event;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
Sorry, I know this is late, but it was pushed down in my todo list
(never off, but something I probably wouldn't have seen for a few more
months).
On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
From: David Sharp dhsh...@google.com
If this is from David it needs his SOB.
-- Steve
Remove ftrace_format_syscall() declaration; it is neither defined nor
used. Also update a comment and formatting.
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
---
include/trace/syscall.h|2 --
kernel/trace/ring_buffer.c |6 +++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/trace/syscall.h b/include/trace/syscall.h
index 31966a4..0c95796 100644
--- a/include/trace/syscall.h
+++ b/include/trace/syscall.h
@@ -39,8 +39,6 @@ extern int reg_event_syscall_enter(struct ftrace_event_call
*call);
extern void unreg_event_syscall_enter(struct ftrace_event_call *call);
extern int reg_event_syscall_exit(struct ftrace_event_call *call);
extern void unreg_event_syscall_exit(struct ftrace_event_call *call);
-extern int
-ftrace_format_syscall(struct ftrace_event_call *call, struct trace_seq *s);
enum print_line_t print_syscall_enter(struct trace_iterator *iter, int flags,
struct trace_event *event);
enum print_line_t print_syscall_exit(struct trace_iterator *iter, int flags,
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 1d0f6a8..96c2dd1 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1816,7 +1816,7 @@ rb_add_time_stamp(struct ring_buffer_event *event, u64
delta)
}
/**
- * ring_buffer_update_event - update event type and data
+ * rb_update_event - update event type and data
* @event: the even to update
* @type: the type of event
* @length: the size of the event field in the ring buffer
@@ -2716,8 +2716,8 @@ EXPORT_SYMBOL_GPL(ring_buffer_discard_commit);
* and not the length of the event which would hold the header.
*/
int ring_buffer_write(struct ring_buffer *buffer,
- unsigned long length,
- void *data)
+ unsigned long length,
+ void *data)
{
struct ring_buffer_per_cpu *cpu_buffer;
struct ring_buffer_event *event;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt rost...@goodmis.org wrote:
Sorry, I know this is late, but it was pushed down in my todo list
(never off, but something I probably wouldn't have seen for a few more
months).
On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
From: David Sharp dhsh...@google.com
If this is from David it needs his SOB.
Is that true even though we are working for the same company?
-- Steve
Remove ftrace_format_syscall() declaration; it is neither defined nor
used. Also update a comment and formatting.
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
include/trace/syscall.h|2 --
kernel/trace/ring_buffer.c |6 +++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/trace/syscall.h b/include/trace/syscall.h
index 31966a4..0c95796 100644
--- a/include/trace/syscall.h
+++ b/include/trace/syscall.h
@@ -39,8 +39,6 @@ extern int reg_event_syscall_enter(struct
ftrace_event_call *call);
extern void unreg_event_syscall_enter(struct ftrace_event_call *call);
extern int reg_event_syscall_exit(struct ftrace_event_call *call);
extern void unreg_event_syscall_exit(struct ftrace_event_call *call);
-extern int
-ftrace_format_syscall(struct ftrace_event_call *call, struct trace_seq *s);
enum print_line_t print_syscall_enter(struct trace_iterator *iter, int
flags,
struct trace_event *event);
enum print_line_t print_syscall_exit(struct trace_iterator *iter, int flags,
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 1d0f6a8..96c2dd1 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1816,7 +1816,7 @@ rb_add_time_stamp(struct ring_buffer_event *event, u64
delta)
}
/**
- * ring_buffer_update_event - update event type and data
+ * rb_update_event - update event type and data
* @event: the even to update
* @type: the type of event
* @length: the size of the event field in the ring buffer
@@ -2716,8 +2716,8 @@ EXPORT_SYMBOL_GPL(ring_buffer_discard_commit);
* and not the length of the event which would hold the header.
*/
int ring_buffer_write(struct ring_buffer *buffer,
- unsigned long length,
- void *data)
+ unsigned long length,
+ void *data)
{
struct ring_buffer_per_cpu *cpu_buffer;
struct ring_buffer_event *event;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] tracing: trivial cleanup
On Thu, 2012-10-11 at 19:31 -0700, David Sharp wrote: On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt rost...@goodmis.org wrote: Sorry, I know this is late, but it was pushed down in my todo list (never off, but something I probably wouldn't have seen for a few more months). On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote: From: David Sharp dhsh...@google.com If this is from David it needs his SOB. Is that true even though we are working for the same company? Yes. I would never push a patch from Ingo without his Signed-off-by even though he and I work for the same company ;-) Although, the GPL would let you. But it's best not to do it. -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
