[PATCH 1/3] /drivers/net ioremap balancing/returncode check (resend)
resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for iounmap this audit was only for files directly in drivers/net directory, not the full tree. Signed-off-by: Scott Thompson hushmail.com> -- diff --git a/drivers/net/es3210.c b/drivers/net/es3210.c index 822e5bf..d7d6b90 100644 --- a/drivers/net/es3210.c +++ b/drivers/net/es3210.c @@ -307,6 +307,10 @@ out1: free_irq(dev->irq, dev); out: release_region(ioaddr + ES_SA_PROM, ES_IO_EXTENT); + + if (ei_status.mem) + iounmap(ei_status.mem); + return retval; } diff --git a/drivers/net/lne390.c b/drivers/net/lne390.c index 0a08d0c..f6d9fb6 100644 --- a/drivers/net/lne390.c +++ b/drivers/net/lne390.c @@ -290,7 +290,7 @@ static int __init lne390_probe1(struct net_device *dev, int ioaddr) goto unmap; return 0; unmap: - if (ei_status.reg0) + if (ei_status.mem) iounmap(ei_status.mem); cleanup: free_irq(dev->irq, dev); Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news, photos & more. http://mobile.yahoo.com/go?refer=1GNXIC - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] /drivers/net ioremap balancing/returncode check (resend)
resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for iounmap this audit was only for files directly in drivers/net directory, not the full tree. Signed-off-by: Scott Thompson postfail at hushmail.com -- diff --git a/drivers/net/es3210.c b/drivers/net/es3210.c index 822e5bf..d7d6b90 100644 --- a/drivers/net/es3210.c +++ b/drivers/net/es3210.c @@ -307,6 +307,10 @@ out1: free_irq(dev-irq, dev); out: release_region(ioaddr + ES_SA_PROM, ES_IO_EXTENT); + + if (ei_status.mem) + iounmap(ei_status.mem); + return retval; } diff --git a/drivers/net/lne390.c b/drivers/net/lne390.c index 0a08d0c..f6d9fb6 100644 --- a/drivers/net/lne390.c +++ b/drivers/net/lne390.c @@ -290,7 +290,7 @@ static int __init lne390_probe1(struct net_device *dev, int ioaddr) goto unmap; return 0; unmap: - if (ei_status.reg0) + if (ei_status.mem) iounmap(ei_status.mem); cleanup: free_irq(dev-irq, dev); Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news, photos more. http://mobile.yahoo.com/go?refer=1GNXIC - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
