RE: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[David Laight]

From: Alex Williamson
> Sent: 15 May 2017 04:21
...
> > >   /* Find end of list, sew whole thing into vi->rq.pages. */
> > > - for (end = page; end->private; end = (struct page *)end->private);
> > > + for (end = page; end->private; end = (struct page *)end->private)
> > > + ;
> 
> FWIW, I generally like to put a comment on the next line to make it
> abundantly clear that there's nothing in the body of the loop, it's
> also more aesthetically pleasing than a semi-colon on the line by
> itself, ex. /* Nothing */;  It's just too easy to misinterpret the
> loop otherwise, especially without gratuitous white space.  Thanks,

My preference is to put 'continue;' on a line by itself.
Or even move the termination condition into the loop:
for (end = page;; end = (struct page *)end->private)
if (!end->private)
break;

(oh, is that cast needed??)

David

RE: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[David Laight]

From: Alex Williamson
> Sent: 15 May 2017 04:21
...
> > >   /* Find end of list, sew whole thing into vi->rq.pages. */
> > > - for (end = page; end->private; end = (struct page *)end->private);
> > > + for (end = page; end->private; end = (struct page *)end->private)
> > > + ;
> 
> FWIW, I generally like to put a comment on the next line to make it
> abundantly clear that there's nothing in the body of the loop, it's
> also more aesthetically pleasing than a semi-colon on the line by
> itself, ex. /* Nothing */;  It's just too easy to misinterpret the
> loop otherwise, especially without gratuitous white space.  Thanks,

My preference is to put 'continue;' on a line by itself.
Or even move the termination condition into the loop:
for (end = page;; end = (struct page *)end->private)
if (!end->private)
break;

(oh, is that cast needed??)

David

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Alex Williamson]

On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin"  wrote:

> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski 
> > 
> > Signed-off-by: Maciej Fijalkowski   
> 
> I prefer the original form - ; isn't a full statement.
> 
> > ---
> >  drivers/net/virtio_net.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 9320d96..f20dfb8 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
> > page *page)
> > struct page *end;
> >  
> > /* Find end of list, sew whole thing into vi->rq.pages. */
> > -   for (end = page; end->private; end = (struct page *)end->private);
> > +   for (end = page; end->private; end = (struct page *)end->private)
> > +   ;

FWIW, I generally like to put a comment on the next line to make it
abundantly clear that there's nothing in the body of the loop, it's
also more aesthetically pleasing than a semi-colon on the line by
itself, ex. /* Nothing */;  It's just too easy to misinterpret the
loop otherwise, especially without gratuitous white space.  Thanks,

Alex


> > end->private = (unsigned long)rq->pages;
> > rq->pages = page;
> >  }
> > -- 
> > 2.4.11  
> ___
> Virtualization mailing list
> virtualizat...@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Alex Williamson]

On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin"  wrote:

> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski 
> > 
> > Signed-off-by: Maciej Fijalkowski   
> 
> I prefer the original form - ; isn't a full statement.
> 
> > ---
> >  drivers/net/virtio_net.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 9320d96..f20dfb8 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
> > page *page)
> > struct page *end;
> >  
> > /* Find end of list, sew whole thing into vi->rq.pages. */
> > -   for (end = page; end->private; end = (struct page *)end->private);
> > +   for (end = page; end->private; end = (struct page *)end->private)
> > +   ;

FWIW, I generally like to put a comment on the next line to make it
abundantly clear that there's nothing in the body of the loop, it's
also more aesthetically pleasing than a semi-colon on the line by
itself, ex. /* Nothing */;  It's just too easy to misinterpret the
loop otherwise, especially without gratuitous white space.  Thanks,

Alex


> > end->private = (unsigned long)rq->pages;
> > rq->pages = page;
> >  }
> > -- 
> > 2.4.11  
> ___
> Virtualization mailing list
> virtualizat...@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Michael S. Tsirkin]

On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski 
> 
> Signed-off-by: Maciej Fijalkowski 

I prefer the original form - ; isn't a full statement.

> ---
>  drivers/net/virtio_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9320d96..f20dfb8 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
> page *page)
>   struct page *end;
>  
>   /* Find end of list, sew whole thing into vi->rq.pages. */
> - for (end = page; end->private; end = (struct page *)end->private);
> + for (end = page; end->private; end = (struct page *)end->private)
> + ;
>   end->private = (unsigned long)rq->pages;
>   rq->pages = page;
>  }
> -- 
> 2.4.11

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Michael S. Tsirkin]

On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski 
> 
> Signed-off-by: Maciej Fijalkowski 

I prefer the original form - ; isn't a full statement.

> ---
>  drivers/net/virtio_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9320d96..f20dfb8 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
> page *page)
>   struct page *end;
>  
>   /* Find end of list, sew whole thing into vi->rq.pages. */
> - for (end = page; end->private; end = (struct page *)end->private);
> + for (end = page; end->private; end = (struct page *)end->private)
> + ;
>   end->private = (unsigned long)rq->pages;
>   rq->pages = page;
>  }
> -- 
> 2.4.11

[PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Maciek Fijalkowski]

From: Maciej Fijalkowski 

Signed-off-by: Maciej Fijalkowski 
---
 drivers/net/virtio_net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
page *page)
struct page *end;
 
/* Find end of list, sew whole thing into vi->rq.pages. */
-   for (end = page; end->private; end = (struct page *)end->private);
+   for (end = page; end->private; end = (struct page *)end->private)
+   ;
end->private = (unsigned long)rq->pages;
rq->pages = page;
 }
-- 
2.4.11

[PATCH 1/3] Fix ERROR: trailing statements should be on next line

[Maciek Fijalkowski]

From: Maciej Fijalkowski 

Signed-off-by: Maciej Fijalkowski 
---
 drivers/net/virtio_net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct 
page *page)
struct page *end;
 
/* Find end of list, sew whole thing into vi->rq.pages. */
-   for (end = page; end->private; end = (struct page *)end->private);
+   for (end = page; end->private; end = (struct page *)end->private)
+   ;
end->private = (unsigned long)rq->pages;
rq->pages = page;
 }
-- 
2.4.11