Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-21 Thread Shawn Guo
On Wed, Jan 16, 2019 at 05:31:46PM +, Ioana Ciornei wrote:
> > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > > platforms
> > >
> > > On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote:
> > > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > > > DPAA2 platforms
> > > > >
> > > > > On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> > > > > > Add the dpaa2-console device tree node for the following
> > > > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > > > >
> > > > > > Signed-off-by: Ioana Ciornei 
> > > > >
> > > > > DTS patch generally goes to the last in a series.
> > > >
> > > > Should I resend this with the DTS patch the last?
> > >
> > > You do not have to resend the series only for this.  It's pretty much
> > > a suggestion for future posting.
> > 
> 
> One more thing, do you have any other feedback on the DTS part?
> I think the best path for this patch set is through Leo's fsl soc tree but of 
> course we need an ack from the DTS part also.

I do not see there is a hard dependency between driver and dts part,
e.g. build error or causing regression.  In that case, dts should just
go via its channel.

Shawn


RE: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-16 Thread Ioana Ciornei
> > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > platforms
> >
> > On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote:
> > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > > DPAA2 platforms
> > > >
> > > > On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> > > > > Add the dpaa2-console device tree node for the following
> > > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > > >
> > > > > Signed-off-by: Ioana Ciornei 
> > > >
> > > > DTS patch generally goes to the last in a series.
> > >
> > > Should I resend this with the DTS patch the last?
> >
> > You do not have to resend the series only for this.  It's pretty much
> > a suggestion for future posting.
> 

One more thing, do you have any other feedback on the DTS part?
I think the best path for this patch set is through Leo's fsl soc tree but of 
course we need an ack from the DTS part also.

Thanks,
Ioana


RE: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-16 Thread Ioana Ciornei
> Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> platforms
> 
> On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote:
> > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > DPAA2 platforms
> > >
> > > On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> > > > Add the dpaa2-console device tree node for the following
> > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > >
> > > > Signed-off-by: Ioana Ciornei 
> > >
> > > DTS patch generally goes to the last in a series.
> >
> > Should I resend this with the DTS patch the last?
> 
> You do not have to resend the series only for this.  It's pretty much a 
> suggestion
> for future posting.

Ok, thanks for the suggestion.

Ioana




Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-16 Thread Shawn Guo
On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote:
> > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > platforms
> > 
> > On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> > > Add the dpaa2-console device tree node for the following
> > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > >
> > > Signed-off-by: Ioana Ciornei 
> > 
> > DTS patch generally goes to the last in a series.
> 
> Should I resend this with the DTS patch the last?

You do not have to resend the series only for this.  It's pretty much a
suggestion for future posting.

Shawn


RE: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-16 Thread Ioana Ciornei
> Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> platforms
> 
> On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> > Add the dpaa2-console device tree node for the following
> > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> >
> > Signed-off-by: Ioana Ciornei 
> 
> DTS patch generally goes to the last in a series.

Should I resend this with the DTS patch the last?

Ioana

> 
> Shawn


Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-11 Thread Shawn Guo
On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote:
> Add the dpaa2-console device tree node for the following
> DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> 
> Signed-off-by: Ioana Ciornei 

DTS patch generally goes to the last in a series.

Shawn


[PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2018-12-21 Thread Ioana Ciornei
Add the dpaa2-console device tree node for the following
DPAA2 based platforms: LS1088A, LS2080A and LS2088A.

Signed-off-by: Ioana Ciornei 
---
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 5 +
 2 files changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index e73e55f..664e337 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -569,6 +569,11 @@
clock-names = "apb_pclk", "wdog_clk";
};
 
+   dpaa2-console@0x08340020 {
+   compatible = "dpaa2-console";
+   reg = <0x 0x08340020 0 0x2>;
+   };
+
fsl_mc: fsl-mc@80c00 {
compatible = "fsl,qoriq-mc";
reg = <0x0008 0x0c00 0 0x40>,/* MC portal 
base */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index d188774..6db6ea4 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -333,6 +333,11 @@
};
};
 
+   dpaa2-console@0x08340020 {
+   compatible = "dpaa2-console";
+   reg = <0x 0x08340020 0 0x2>;
+   };
+
fsl_mc: fsl-mc@80c00 {
compatible = "fsl,qoriq-mc";
reg = <0x0008 0x0c00 0 0x40>,/* MC portal 
base */
-- 
1.9.1