[PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Michael Ellerman 
kcmp.h appears to be part of the API, it's documented in kcmp(2), and
the selftests/kcmp code uses it. So move it to uapi so it's actually
exported.

Signed-off-by: Michael Ellerman 
---
 include/linux/kcmp.h  | 17 -
 include/uapi/linux/Kbuild |  1 +
 include/uapi/linux/kcmp.h | 17 +
 3 files changed, 18 insertions(+), 17 deletions(-)
 delete mode 100644 include/linux/kcmp.h
 create mode 100644 include/uapi/linux/kcmp.h

diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
deleted file mode 100644
index 2dcd1b3aafc8..
--- a/include/linux/kcmp.h
+++ /dev/null
@@ -1,17 +0,0 @@
-#ifndef _LINUX_KCMP_H
-#define _LINUX_KCMP_H
-
-/* Comparison type */
-enum kcmp_type {
-   KCMP_FILE,
-   KCMP_VM,
-   KCMP_FILES,
-   KCMP_FS,
-   KCMP_SIGHAND,
-   KCMP_IO,
-   KCMP_SYSVSEM,
-
-   KCMP_TYPES,
-};
-
-#endif /* _LINUX_KCMP_H */
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index 4c94f31a8c99..a7b3071c03f2 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -211,6 +211,7 @@ header-y += ivtvfb.h
 header-y += ixjuser.h
 header-y += jffs2.h
 header-y += joystick.h
+header-y += kcmp.h
 header-y += kd.h
 header-y += kdev_t.h
 header-y += kernel-page-flags.h
diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
new file mode 100644
index ..84df14b37360
--- /dev/null
+++ b/include/uapi/linux/kcmp.h
@@ -0,0 +1,17 @@
+#ifndef _UAPI_LINUX_KCMP_H
+#define _UAPI_LINUX_KCMP_H
+
+/* Comparison type */
+enum kcmp_type {
+   KCMP_FILE,
+   KCMP_VM,
+   KCMP_FILES,
+   KCMP_FS,
+   KCMP_SIGHAND,
+   KCMP_IO,
+   KCMP_SYSVSEM,
+
+   KCMP_TYPES,
+};
+
+#endif /* _UAPI_LINUX_KCMP_H */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Michael Ellerman 
On Mon, 2014-12-01 at 10:00 -0700, Shuah Khan wrote:
> On 11/27/2014 07:18 PM, Michael Ellerman wrote:
> > On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
> >> kcmp.h appears to be part of the API, it's documented in kcmp(2), and
> >> the selftests/kcmp code uses it. So move it to uapi so it's actually
> >> exported.
> > 
> > Looks like this series fell through the cracks?
> > 
> > It still applies on rc6. Should I resend?
> > 
> > cheers
> > 
> >> Signed-off-by: Michael Ellerman 
> 
> I am expecting a patch v2 for the series based on the comments
> on the series. Please see my responses to the individual patch
> threads.

Sure, will repost.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Shuah Khan 
On 11/27/2014 07:18 PM, Michael Ellerman wrote:
> On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
>> kcmp.h appears to be part of the API, it's documented in kcmp(2), and
>> the selftests/kcmp code uses it. So move it to uapi so it's actually
>> exported.
> 
> Looks like this series fell through the cracks?
> 
> It still applies on rc6. Should I resend?
> 
> cheers
> 
>> Signed-off-by: Michael Ellerman 

I am expecting a patch v2 for the series based on the comments
on the series. Please see my responses to the individual patch
threads.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Shuah Khan 
On 10/23/2014 02:14 AM, Cyrill Gorcunov wrote:
> On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
>> On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
>>> --- a/include/linux/kcmp.h
>>> +++ b/include/linux/kcmp.h
>>> @@ -1,17 +1,6 @@
>>>  #ifndef _LINUX_KCMP_H
>>>  #define _LINUX_KCMP_H
>>>  
>>> -/* Comparison type */
>>> -enum kcmp_type {
>>> -   KCMP_FILE,
>>> -   KCMP_VM,
>>> -   KCMP_FILES,
>>> -   KCMP_FS,
>>> -   KCMP_SIGHAND,
>>> -   KCMP_IO,
>>> -   KCMP_SYSVSEM,
>>> -
>>> -   KCMP_TYPES,
>>> -};
>>> +#include 
>>>  
>>>  #endif /* _LINUX_KCMP_H */
>>>
>>
>> If the file is empty except for the uapi include, I think it's better to
>> delete it completely. The include path logic should ensure we pick the
>> other one up.
> 
> Good point, somehow managed to miss this.
> 

Michael,

Are you planning to send v2 to address the comments?

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Michael Ellerman 
On Mon, 2014-12-01 at 10:00 -0700, Shuah Khan wrote:
 On 11/27/2014 07:18 PM, Michael Ellerman wrote:
  On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
  kcmp.h appears to be part of the API, it's documented in kcmp(2), and
  the selftests/kcmp code uses it. So move it to uapi so it's actually
  exported.
  
  Looks like this series fell through the cracks?
  
  It still applies on rc6. Should I resend?
  
  cheers
  
  Signed-off-by: Michael Ellerman m...@ellerman.id.au
 
 I am expecting a patch v2 for the series based on the comments
 on the series. Please see my responses to the individual patch
 threads.

Sure, will repost.

cheers


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Michael Ellerman 
kcmp.h appears to be part of the API, it's documented in kcmp(2), and
the selftests/kcmp code uses it. So move it to uapi so it's actually
exported.

Signed-off-by: Michael Ellerman m...@ellerman.id.au
---
 include/linux/kcmp.h  | 17 -
 include/uapi/linux/Kbuild |  1 +
 include/uapi/linux/kcmp.h | 17 +
 3 files changed, 18 insertions(+), 17 deletions(-)
 delete mode 100644 include/linux/kcmp.h
 create mode 100644 include/uapi/linux/kcmp.h

diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
deleted file mode 100644
index 2dcd1b3aafc8..
--- a/include/linux/kcmp.h
+++ /dev/null
@@ -1,17 +0,0 @@
-#ifndef _LINUX_KCMP_H
-#define _LINUX_KCMP_H
-
-/* Comparison type */
-enum kcmp_type {
-   KCMP_FILE,
-   KCMP_VM,
-   KCMP_FILES,
-   KCMP_FS,
-   KCMP_SIGHAND,
-   KCMP_IO,
-   KCMP_SYSVSEM,
-
-   KCMP_TYPES,
-};
-
-#endif /* _LINUX_KCMP_H */
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index 4c94f31a8c99..a7b3071c03f2 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -211,6 +211,7 @@ header-y += ivtvfb.h
 header-y += ixjuser.h
 header-y += jffs2.h
 header-y += joystick.h
+header-y += kcmp.h
 header-y += kd.h
 header-y += kdev_t.h
 header-y += kernel-page-flags.h
diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
new file mode 100644
index ..84df14b37360
--- /dev/null
+++ b/include/uapi/linux/kcmp.h
@@ -0,0 +1,17 @@
+#ifndef _UAPI_LINUX_KCMP_H
+#define _UAPI_LINUX_KCMP_H
+
+/* Comparison type */
+enum kcmp_type {
+   KCMP_FILE,
+   KCMP_VM,
+   KCMP_FILES,
+   KCMP_FS,
+   KCMP_SIGHAND,
+   KCMP_IO,
+   KCMP_SYSVSEM,
+
+   KCMP_TYPES,
+};
+
+#endif /* _UAPI_LINUX_KCMP_H */
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Shuah Khan 
On 10/23/2014 02:14 AM, Cyrill Gorcunov wrote:
 On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
 On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
 --- a/include/linux/kcmp.h
 +++ b/include/linux/kcmp.h
 @@ -1,17 +1,6 @@
  #ifndef _LINUX_KCMP_H
  #define _LINUX_KCMP_H
  
 -/* Comparison type */
 -enum kcmp_type {
 -   KCMP_FILE,
 -   KCMP_VM,
 -   KCMP_FILES,
 -   KCMP_FS,
 -   KCMP_SIGHAND,
 -   KCMP_IO,
 -   KCMP_SYSVSEM,
 -
 -   KCMP_TYPES,
 -};
 +#include uapi/linux/kcmp.h
  
  #endif /* _LINUX_KCMP_H */


 If the file is empty except for the uapi include, I think it's better to
 delete it completely. The include path logic should ensure we pick the
 other one up.
 
 Good point, somehow managed to miss this.
 

Michael,

Are you planning to send v2 to address the comments?

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-12-01 Thread Shuah Khan 
On 11/27/2014 07:18 PM, Michael Ellerman wrote:
 On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
 kcmp.h appears to be part of the API, it's documented in kcmp(2), and
 the selftests/kcmp code uses it. So move it to uapi so it's actually
 exported.
 
 Looks like this series fell through the cracks?
 
 It still applies on rc6. Should I resend?
 
 cheers
 
 Signed-off-by: Michael Ellerman m...@ellerman.id.au

I am expecting a patch v2 for the series based on the comments
on the series. Please see my responses to the individual patch
threads.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-11-27 Thread Michael Ellerman 
On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
> kcmp.h appears to be part of the API, it's documented in kcmp(2), and
> the selftests/kcmp code uses it. So move it to uapi so it's actually
> exported.

Looks like this series fell through the cracks?

It still applies on rc6. Should I resend?

cheers

> Signed-off-by: Michael Ellerman 
> ---
>  include/linux/kcmp.h  | 13 +
>  include/uapi/linux/Kbuild |  1 +
>  include/uapi/linux/kcmp.h | 17 +
>  3 files changed, 19 insertions(+), 12 deletions(-)
>  create mode 100644 include/uapi/linux/kcmp.h
> 
> diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
> index 2dcd1b3aafc8..9dfb23e1771b 100644
> --- a/include/linux/kcmp.h
> +++ b/include/linux/kcmp.h
> @@ -1,17 +1,6 @@
>  #ifndef _LINUX_KCMP_H
>  #define _LINUX_KCMP_H
>  
> -/* Comparison type */
> -enum kcmp_type {
> - KCMP_FILE,
> - KCMP_VM,
> - KCMP_FILES,
> - KCMP_FS,
> - KCMP_SIGHAND,
> - KCMP_IO,
> - KCMP_SYSVSEM,
> -
> - KCMP_TYPES,
> -};
> +#include 
>  
>  #endif /* _LINUX_KCMP_H */
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index b70237e8bc37..1cf50d682dbf 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -209,6 +209,7 @@ header-y += ivtvfb.h
>  header-y += ixjuser.h
>  header-y += jffs2.h
>  header-y += joystick.h
> +header-y += kcmp.h
>  header-y += kd.h
>  header-y += kdev_t.h
>  header-y += kernel-page-flags.h
> diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
> new file mode 100644
> index ..84df14b37360
> --- /dev/null
> +++ b/include/uapi/linux/kcmp.h
> @@ -0,0 +1,17 @@
> +#ifndef _UAPI_LINUX_KCMP_H
> +#define _UAPI_LINUX_KCMP_H
> +
> +/* Comparison type */
> +enum kcmp_type {
> + KCMP_FILE,
> + KCMP_VM,
> + KCMP_FILES,
> + KCMP_FS,
> + KCMP_SIGHAND,
> + KCMP_IO,
> + KCMP_SYSVSEM,
> +
> + KCMP_TYPES,
> +};
> +
> +#endif /* _UAPI_LINUX_KCMP_H */




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-11-27 Thread Michael Ellerman 
On Thu, 2014-10-23 at 16:07 +1100, Michael Ellerman wrote:
 kcmp.h appears to be part of the API, it's documented in kcmp(2), and
 the selftests/kcmp code uses it. So move it to uapi so it's actually
 exported.

Looks like this series fell through the cracks?

It still applies on rc6. Should I resend?

cheers

 Signed-off-by: Michael Ellerman m...@ellerman.id.au
 ---
  include/linux/kcmp.h  | 13 +
  include/uapi/linux/Kbuild |  1 +
  include/uapi/linux/kcmp.h | 17 +
  3 files changed, 19 insertions(+), 12 deletions(-)
  create mode 100644 include/uapi/linux/kcmp.h
 
 diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
 index 2dcd1b3aafc8..9dfb23e1771b 100644
 --- a/include/linux/kcmp.h
 +++ b/include/linux/kcmp.h
 @@ -1,17 +1,6 @@
  #ifndef _LINUX_KCMP_H
  #define _LINUX_KCMP_H
  
 -/* Comparison type */
 -enum kcmp_type {
 - KCMP_FILE,
 - KCMP_VM,
 - KCMP_FILES,
 - KCMP_FS,
 - KCMP_SIGHAND,
 - KCMP_IO,
 - KCMP_SYSVSEM,
 -
 - KCMP_TYPES,
 -};
 +#include uapi/linux/kcmp.h
  
  #endif /* _LINUX_KCMP_H */
 diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
 index b70237e8bc37..1cf50d682dbf 100644
 --- a/include/uapi/linux/Kbuild
 +++ b/include/uapi/linux/Kbuild
 @@ -209,6 +209,7 @@ header-y += ivtvfb.h
  header-y += ixjuser.h
  header-y += jffs2.h
  header-y += joystick.h
 +header-y += kcmp.h
  header-y += kd.h
  header-y += kdev_t.h
  header-y += kernel-page-flags.h
 diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
 new file mode 100644
 index ..84df14b37360
 --- /dev/null
 +++ b/include/uapi/linux/kcmp.h
 @@ -0,0 +1,17 @@
 +#ifndef _UAPI_LINUX_KCMP_H
 +#define _UAPI_LINUX_KCMP_H
 +
 +/* Comparison type */
 +enum kcmp_type {
 + KCMP_FILE,
 + KCMP_VM,
 + KCMP_FILES,
 + KCMP_FS,
 + KCMP_SIGHAND,
 + KCMP_IO,
 + KCMP_SYSVSEM,
 +
 + KCMP_TYPES,
 +};
 +
 +#endif /* _UAPI_LINUX_KCMP_H */




--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Cyrill Gorcunov 
On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
> On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
> > --- a/include/linux/kcmp.h
> > +++ b/include/linux/kcmp.h
> > @@ -1,17 +1,6 @@
> >  #ifndef _LINUX_KCMP_H
> >  #define _LINUX_KCMP_H
> >  
> > -/* Comparison type */
> > -enum kcmp_type {
> > -   KCMP_FILE,
> > -   KCMP_VM,
> > -   KCMP_FILES,
> > -   KCMP_FS,
> > -   KCMP_SIGHAND,
> > -   KCMP_IO,
> > -   KCMP_SYSVSEM,
> > -
> > -   KCMP_TYPES,
> > -};
> > +#include 
> >  
> >  #endif /* _LINUX_KCMP_H */
> > 
> 
> If the file is empty except for the uapi include, I think it's better to
> delete it completely. The include path logic should ensure we pick the
> other one up.

Good point, somehow managed to miss this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Arnd Bergmann 
On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
> --- a/include/linux/kcmp.h
> +++ b/include/linux/kcmp.h
> @@ -1,17 +1,6 @@
>  #ifndef _LINUX_KCMP_H
>  #define _LINUX_KCMP_H
>  
> -/* Comparison type */
> -enum kcmp_type {
> -   KCMP_FILE,
> -   KCMP_VM,
> -   KCMP_FILES,
> -   KCMP_FS,
> -   KCMP_SIGHAND,
> -   KCMP_IO,
> -   KCMP_SYSVSEM,
> -
> -   KCMP_TYPES,
> -};
> +#include 
>  
>  #endif /* _LINUX_KCMP_H */
> 

If the file is empty except for the uapi include, I think it's better to
delete it completely. The include path logic should ensure we pick the
other one up.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Cyrill Gorcunov 
On Thu, Oct 23, 2014 at 04:07:12PM +1100, Michael Ellerman wrote:
> kcmp.h appears to be part of the API, it's documented in kcmp(2), and
> the selftests/kcmp code uses it. So move it to uapi so it's actually
> exported.
> 
> Signed-off-by: Michael Ellerman 
Acked-by: Cyrill Gorcunov 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Cyrill Gorcunov 
On Thu, Oct 23, 2014 at 04:07:12PM +1100, Michael Ellerman wrote:
 kcmp.h appears to be part of the API, it's documented in kcmp(2), and
 the selftests/kcmp code uses it. So move it to uapi so it's actually
 exported.
 
 Signed-off-by: Michael Ellerman m...@ellerman.id.au
Acked-by: Cyrill Gorcunov gorcu...@openvz.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Arnd Bergmann 
On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
 --- a/include/linux/kcmp.h
 +++ b/include/linux/kcmp.h
 @@ -1,17 +1,6 @@
  #ifndef _LINUX_KCMP_H
  #define _LINUX_KCMP_H
  
 -/* Comparison type */
 -enum kcmp_type {
 -   KCMP_FILE,
 -   KCMP_VM,
 -   KCMP_FILES,
 -   KCMP_FS,
 -   KCMP_SIGHAND,
 -   KCMP_IO,
 -   KCMP_SYSVSEM,
 -
 -   KCMP_TYPES,
 -};
 +#include uapi/linux/kcmp.h
  
  #endif /* _LINUX_KCMP_H */
 

If the file is empty except for the uapi include, I think it's better to
delete it completely. The include path logic should ensure we pick the
other one up.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-23 Thread Cyrill Gorcunov 
On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
 On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
  --- a/include/linux/kcmp.h
  +++ b/include/linux/kcmp.h
  @@ -1,17 +1,6 @@
   #ifndef _LINUX_KCMP_H
   #define _LINUX_KCMP_H
   
  -/* Comparison type */
  -enum kcmp_type {
  -   KCMP_FILE,
  -   KCMP_VM,
  -   KCMP_FILES,
  -   KCMP_FS,
  -   KCMP_SIGHAND,
  -   KCMP_IO,
  -   KCMP_SYSVSEM,
  -
  -   KCMP_TYPES,
  -};
  +#include uapi/linux/kcmp.h
   
   #endif /* _LINUX_KCMP_H */
  
 
 If the file is empty except for the uapi include, I think it's better to
 delete it completely. The include path logic should ensure we pick the
 other one up.

Good point, somehow managed to miss this.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-22 Thread Michael Ellerman 
kcmp.h appears to be part of the API, it's documented in kcmp(2), and
the selftests/kcmp code uses it. So move it to uapi so it's actually
exported.

Signed-off-by: Michael Ellerman 
---
 include/linux/kcmp.h  | 13 +
 include/uapi/linux/Kbuild |  1 +
 include/uapi/linux/kcmp.h | 17 +
 3 files changed, 19 insertions(+), 12 deletions(-)
 create mode 100644 include/uapi/linux/kcmp.h

diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
index 2dcd1b3aafc8..9dfb23e1771b 100644
--- a/include/linux/kcmp.h
+++ b/include/linux/kcmp.h
@@ -1,17 +1,6 @@
 #ifndef _LINUX_KCMP_H
 #define _LINUX_KCMP_H
 
-/* Comparison type */
-enum kcmp_type {
-   KCMP_FILE,
-   KCMP_VM,
-   KCMP_FILES,
-   KCMP_FS,
-   KCMP_SIGHAND,
-   KCMP_IO,
-   KCMP_SYSVSEM,
-
-   KCMP_TYPES,
-};
+#include 
 
 #endif /* _LINUX_KCMP_H */
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index b70237e8bc37..1cf50d682dbf 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -209,6 +209,7 @@ header-y += ivtvfb.h
 header-y += ixjuser.h
 header-y += jffs2.h
 header-y += joystick.h
+header-y += kcmp.h
 header-y += kd.h
 header-y += kdev_t.h
 header-y += kernel-page-flags.h
diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
new file mode 100644
index ..84df14b37360
--- /dev/null
+++ b/include/uapi/linux/kcmp.h
@@ -0,0 +1,17 @@
+#ifndef _UAPI_LINUX_KCMP_H
+#define _UAPI_LINUX_KCMP_H
+
+/* Comparison type */
+enum kcmp_type {
+   KCMP_FILE,
+   KCMP_VM,
+   KCMP_FILES,
+   KCMP_FS,
+   KCMP_SIGHAND,
+   KCMP_IO,
+   KCMP_SYSVSEM,
+
+   KCMP_TYPES,
+};
+
+#endif /* _UAPI_LINUX_KCMP_H */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] kcmp: Move kcmp.h into uapi

2014-10-22 Thread Michael Ellerman 
kcmp.h appears to be part of the API, it's documented in kcmp(2), and
the selftests/kcmp code uses it. So move it to uapi so it's actually
exported.

Signed-off-by: Michael Ellerman m...@ellerman.id.au
---
 include/linux/kcmp.h  | 13 +
 include/uapi/linux/Kbuild |  1 +
 include/uapi/linux/kcmp.h | 17 +
 3 files changed, 19 insertions(+), 12 deletions(-)
 create mode 100644 include/uapi/linux/kcmp.h

diff --git a/include/linux/kcmp.h b/include/linux/kcmp.h
index 2dcd1b3aafc8..9dfb23e1771b 100644
--- a/include/linux/kcmp.h
+++ b/include/linux/kcmp.h
@@ -1,17 +1,6 @@
 #ifndef _LINUX_KCMP_H
 #define _LINUX_KCMP_H
 
-/* Comparison type */
-enum kcmp_type {
-   KCMP_FILE,
-   KCMP_VM,
-   KCMP_FILES,
-   KCMP_FS,
-   KCMP_SIGHAND,
-   KCMP_IO,
-   KCMP_SYSVSEM,
-
-   KCMP_TYPES,
-};
+#include uapi/linux/kcmp.h
 
 #endif /* _LINUX_KCMP_H */
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index b70237e8bc37..1cf50d682dbf 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -209,6 +209,7 @@ header-y += ivtvfb.h
 header-y += ixjuser.h
 header-y += jffs2.h
 header-y += joystick.h
+header-y += kcmp.h
 header-y += kd.h
 header-y += kdev_t.h
 header-y += kernel-page-flags.h
diff --git a/include/uapi/linux/kcmp.h b/include/uapi/linux/kcmp.h
new file mode 100644
index ..84df14b37360
--- /dev/null
+++ b/include/uapi/linux/kcmp.h
@@ -0,0 +1,17 @@
+#ifndef _UAPI_LINUX_KCMP_H
+#define _UAPI_LINUX_KCMP_H
+
+/* Comparison type */
+enum kcmp_type {
+   KCMP_FILE,
+   KCMP_VM,
+   KCMP_FILES,
+   KCMP_FS,
+   KCMP_SIGHAND,
+   KCMP_IO,
+   KCMP_SYSVSEM,
+
+   KCMP_TYPES,
+};
+
+#endif /* _UAPI_LINUX_KCMP_H */
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/