Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Suman Anna]

On 02/27/2015 05:26 PM, Joe Perches wrote:
> On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
>> Fix couple of checkpatch warnings of the type,
>> "WARNING: Missing a blank line after declarations"
> []
>> diff --git a/drivers/remoteproc/ste_modem_rproc.c 
>> b/drivers/remoteproc/ste_modem_rproc.c
> []
>> @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
>>  static int sproc_stop(struct rproc *rproc)
>>  {
>>  struct sproc *sproc = rproc->priv;
>> +
>>  sproc_dbg(sproc, "stop ste-modem\n");
> 
> You could probably delete this sproc_dbg
> statement too as it duplicates function tracing.

Thanks for the comment, I will leave that to be done in a different
cleanup patch.

regards
Suman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Suman Anna]

On 02/27/2015 05:26 PM, Joe Perches wrote:
 On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
 Fix couple of checkpatch warnings of the type,
 WARNING: Missing a blank line after declarations
 []
 diff --git a/drivers/remoteproc/ste_modem_rproc.c 
 b/drivers/remoteproc/ste_modem_rproc.c
 []
 @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
  static int sproc_stop(struct rproc *rproc)
  {
  struct sproc *sproc = rproc-priv;
 +
  sproc_dbg(sproc, stop ste-modem\n);
 
 You could probably delete this sproc_dbg
 statement too as it duplicates function tracing.

Thanks for the comment, I will leave that to be done in a different
cleanup patch.

regards
Suman

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Joe Perches]

On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
> Fix couple of checkpatch warnings of the type,
> "WARNING: Missing a blank line after declarations"
[]
> diff --git a/drivers/remoteproc/ste_modem_rproc.c 
> b/drivers/remoteproc/ste_modem_rproc.c
[]
> @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
>  static int sproc_stop(struct rproc *rproc)
>  {
>   struct sproc *sproc = rproc->priv;
> +
>   sproc_dbg(sproc, "stop ste-modem\n");

You could probably delete this sproc_dbg
statement too as it duplicates function tracing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Suman Anna]

Fix couple of checkpatch warnings of the type,
"WARNING: Missing a blank line after declarations"

Signed-off-by: Suman Anna 
---
 drivers/remoteproc/ste_modem_rproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/ste_modem_rproc.c 
b/drivers/remoteproc/ste_modem_rproc.c
index 16b7b7bd805b..cdfcb3f84b3b 100644
--- a/drivers/remoteproc/ste_modem_rproc.c
+++ b/drivers/remoteproc/ste_modem_rproc.c
@@ -67,8 +67,7 @@ static int sproc_load_segments(struct rproc *rproc, const 
struct firmware *fw)
 static const struct ste_toc_entry *sproc_find_rsc_entry(const void *data)
 {
int i;
-   const struct ste_toc *toc;
-   toc = data;
+   const struct ste_toc *toc = data;
 
/* Search the table for the resource table */
for (i = 0; i < SPROC_MAX_TOC_ENTRIES &&
@@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
 static int sproc_stop(struct rproc *rproc)
 {
struct sproc *sproc = rproc->priv;
+
sproc_dbg(sproc, "stop ste-modem\n");
 
return sproc->mdev->ops.power(sproc->mdev, false);
-- 
2.3.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Suman Anna]

Fix couple of checkpatch warnings of the type,
WARNING: Missing a blank line after declarations

Signed-off-by: Suman Anna s-a...@ti.com
---
 drivers/remoteproc/ste_modem_rproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/ste_modem_rproc.c 
b/drivers/remoteproc/ste_modem_rproc.c
index 16b7b7bd805b..cdfcb3f84b3b 100644
--- a/drivers/remoteproc/ste_modem_rproc.c
+++ b/drivers/remoteproc/ste_modem_rproc.c
@@ -67,8 +67,7 @@ static int sproc_load_segments(struct rproc *rproc, const 
struct firmware *fw)
 static const struct ste_toc_entry *sproc_find_rsc_entry(const void *data)
 {
int i;
-   const struct ste_toc *toc;
-   toc = data;
+   const struct ste_toc *toc = data;
 
/* Search the table for the resource table */
for (i = 0; i  SPROC_MAX_TOC_ENTRIES 
@@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
 static int sproc_stop(struct rproc *rproc)
 {
struct sproc *sproc = rproc-priv;
+
sproc_dbg(sproc, stop ste-modem\n);
 
return sproc-mdev-ops.power(sproc-mdev, false);
-- 
2.3.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

[Joe Perches]

On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
 Fix couple of checkpatch warnings of the type,
 WARNING: Missing a blank line after declarations
[]
 diff --git a/drivers/remoteproc/ste_modem_rproc.c 
 b/drivers/remoteproc/ste_modem_rproc.c
[]
 @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
  static int sproc_stop(struct rproc *rproc)
  {
   struct sproc *sproc = rproc-priv;
 +
   sproc_dbg(sproc, stop ste-modem\n);

You could probably delete this sproc_dbg
statement too as it duplicates function tracing.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/