Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
On 2014/9/22 12:02, Tejun Heo wrote:
> On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote:
>> From: Tetsuo Handa
>>
>> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
>> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
>> because it is used as bit number. Redefine it as decimal bit number.
>
> It's also changing the bit position, which is fine but should be
> mentioned in the description.
>
I've resent the patch with changelog updated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote:
> From: Tetsuo Handa
>
> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
> because it is used as bit number. Redefine it as decimal bit number.
It's also changing the bit position, which is fine but should be
mentioned in the description.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
From: Tetsuo Handa
Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
because it is used as bit number. Redefine it as decimal bit number.
Signed-off-by: Tetsuo Handa
Acked-by: Kees Cook
Signed-off-by: Zefan Li
---
include/linux/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5c2c885..4557765 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1957,7 +1957,7 @@ static inline void memalloc_noio_restore(unsigned int
flags)
}
/* Per-process atomic flags. */
-#define PFA_NO_NEW_PRIVS 0x0001/* May not gain new privileges. */
+#define PFA_NO_NEW_PRIVS 0 /* May not gain new privileges. */
static inline bool task_no_new_privs(struct task_struct *p)
{
--
1.8.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
From: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Commit 1d4457f99928 (sched: move no_new_privs into new atomic flags)
defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
because it is used as bit number. Redefine it as decimal bit number.
Signed-off-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Acked-by: Kees Cook keesc...@chromium.org
Signed-off-by: Zefan Li lize...@huawei.com
---
include/linux/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5c2c885..4557765 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1957,7 +1957,7 @@ static inline void memalloc_noio_restore(unsigned int
flags)
}
/* Per-process atomic flags. */
-#define PFA_NO_NEW_PRIVS 0x0001/* May not gain new privileges. */
+#define PFA_NO_NEW_PRIVS 0 /* May not gain new privileges. */
static inline bool task_no_new_privs(struct task_struct *p)
{
--
1.8.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote: From: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Commit 1d4457f99928 (sched: move no_new_privs into new atomic flags) defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number. It's also changing the bit position, which is fine but should be mentioned in the description. Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
On 2014/9/22 12:02, Tejun Heo wrote: On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote: From: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Commit 1d4457f99928 (sched: move no_new_privs into new atomic flags) defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number. It's also changing the bit position, which is fine but should be mentioned in the description. I've resent the patch with changelog updated. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
