Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/18/2017 09:19 AM, Shuah Khan wrote: > On 09/18/2017 09:18 AM, Steven Rostedt wrote: >> On Thu, 14 Sep 2017 08:15:19 -0700 >> Masami Hiramatsuwrote: >> >> Hi Steve/Masami, This patch looks good to me. Adds a check similar to the one one in tools/testing/selftests/ftrace/test.d/kprobe/functions >>> >>> Yes, this looks good to me too :) >>> >>> Acked-by: Masami Hiramatsu >>> >> >> Acked-by: Steven Rostedt (VMware) >> >> -- Steve >> > > Thanks Steve and Masami, > > I will get this into rc2 > Applied to linux-kselftest fixes 4.14-rc2 thanks, -- Shuah
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/18/2017 09:19 AM, Shuah Khan wrote: > On 09/18/2017 09:18 AM, Steven Rostedt wrote: >> On Thu, 14 Sep 2017 08:15:19 -0700 >> Masami Hiramatsu wrote: >> >> Hi Steve/Masami, This patch looks good to me. Adds a check similar to the one one in tools/testing/selftests/ftrace/test.d/kprobe/functions >>> >>> Yes, this looks good to me too :) >>> >>> Acked-by: Masami Hiramatsu >>> >> >> Acked-by: Steven Rostedt (VMware) >> >> -- Steve >> > > Thanks Steve and Masami, > > I will get this into rc2 > Applied to linux-kselftest fixes 4.14-rc2 thanks, -- Shuah
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/18/2017 09:18 AM, Steven Rostedt wrote: > On Thu, 14 Sep 2017 08:15:19 -0700 > Masami Hiramatsuwrote: > > >>> Hi Steve/Masami, >>> >>> This patch looks good to me. Adds a check similar to the one one in >>> tools/testing/selftests/ftrace/test.d/kprobe/functions >> >> Yes, this looks good to me too :) >> >> Acked-by: Masami Hiramatsu >> > > Acked-by: Steven Rostedt (VMware) > > -- Steve > Thanks Steve and Masami, I will get this into rc2 thanks, -- Shuah
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/18/2017 09:18 AM, Steven Rostedt wrote: > On Thu, 14 Sep 2017 08:15:19 -0700 > Masami Hiramatsu wrote: > > >>> Hi Steve/Masami, >>> >>> This patch looks good to me. Adds a check similar to the one one in >>> tools/testing/selftests/ftrace/test.d/kprobe/functions >> >> Yes, this looks good to me too :) >> >> Acked-by: Masami Hiramatsu >> > > Acked-by: Steven Rostedt (VMware) > > -- Steve > Thanks Steve and Masami, I will get this into rc2 thanks, -- Shuah
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:15:19 -0700 Masami Hiramatsuwrote: > > Hi Steve/Masami, > > > > This patch looks good to me. Adds a check similar to the one one in > > tools/testing/selftests/ftrace/test.d/kprobe/functions > > Yes, this looks good to me too :) > > Acked-by: Masami Hiramatsu > Acked-by: Steven Rostedt (VMware) -- Steve
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:15:19 -0700 Masami Hiramatsu wrote: > > Hi Steve/Masami, > > > > This patch looks good to me. Adds a check similar to the one one in > > tools/testing/selftests/ftrace/test.d/kprobe/functions > > Yes, this looks good to me too :) > > Acked-by: Masami Hiramatsu > Acked-by: Steven Rostedt (VMware) -- Steve
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:15:19 -0700 Masami Hiramatsuwrote: > Yes, this looks good to me too :) Agreed. > > Acked-by: Masami Hiramatsu Acked-by: Steven Rostedt (VMware) -- Steve
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:15:19 -0700 Masami Hiramatsu wrote: > Yes, this looks good to me too :) Agreed. > > Acked-by: Masami Hiramatsu Acked-by: Steven Rostedt (VMware) -- Steve
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:58:20 -0600 Shuah Khanwrote: > On 09/08/2017 06:01 AM, Thomas Meyer wrote: > > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > > Add the check to prevent a false test result. > > > > Signed-off-by: Thomas Meyer > > --- > > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > index 2a1cb9908746..a4fd4c851a5b 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > @@ -1,6 +1,8 @@ > > #!/bin/sh > > # description: Register/unregister many kprobe events > > > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > > + > > # ftrace fentry skip size depends on the machine architecture. > > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > > case `uname -m` in > > > > Hi Steve/Masami, > > This patch looks good to me. Adds a check similar to the one one in > tools/testing/selftests/ftrace/test.d/kprobe/functions Yes, this looks good to me too :) Acked-by: Masami Hiramatsu Thanks! > > If you don't have objections, I will get this into 4.14-rc2 or rc3 > > thanks, > -- Shuah > -- > To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Masami Hiramatsu
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On Thu, 14 Sep 2017 08:58:20 -0600 Shuah Khan wrote: > On 09/08/2017 06:01 AM, Thomas Meyer wrote: > > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > > Add the check to prevent a false test result. > > > > Signed-off-by: Thomas Meyer > > --- > > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > index 2a1cb9908746..a4fd4c851a5b 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > @@ -1,6 +1,8 @@ > > #!/bin/sh > > # description: Register/unregister many kprobe events > > > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > > + > > # ftrace fentry skip size depends on the machine architecture. > > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > > case `uname -m` in > > > > Hi Steve/Masami, > > This patch looks good to me. Adds a check similar to the one one in > tools/testing/selftests/ftrace/test.d/kprobe/functions Yes, this looks good to me too :) Acked-by: Masami Hiramatsu Thanks! > > If you don't have objections, I will get this into 4.14-rc2 or rc3 > > thanks, > -- Shuah > -- > To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Masami Hiramatsu
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/08/2017 06:01 AM, Thomas Meyer wrote: > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > Add the check to prevent a false test result. > > Signed-off-by: Thomas Meyer> --- > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > index 2a1cb9908746..a4fd4c851a5b 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > @@ -1,6 +1,8 @@ > #!/bin/sh > # description: Register/unregister many kprobe events > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > + > # ftrace fentry skip size depends on the machine architecture. > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > case `uname -m` in > Hi Steve/Masami, This patch looks good to me. Adds a check similar to the one one in tools/testing/selftests/ftrace/test.d/kprobe/functions If you don't have objections, I will get this into 4.14-rc2 or rc3 thanks, -- Shuah
Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
On 09/08/2017 06:01 AM, Thomas Meyer wrote: > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > Add the check to prevent a false test result. > > Signed-off-by: Thomas Meyer > --- > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > index 2a1cb9908746..a4fd4c851a5b 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > @@ -1,6 +1,8 @@ > #!/bin/sh > # description: Register/unregister many kprobe events > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > + > # ftrace fentry skip size depends on the machine architecture. > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > case `uname -m` in > Hi Steve/Masami, This patch looks good to me. Adds a check similar to the one one in tools/testing/selftests/ftrace/test.d/kprobe/functions If you don't have objections, I will get this into 4.14-rc2 or rc3 thanks, -- Shuah
[PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
The multiple_kprobes test case fails to check for KPROBE_EVENT support. Add the check to prevent a false test result. Signed-off-by: Thomas Meyer--- tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc index 2a1cb9908746..a4fd4c851a5b 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc @@ -1,6 +1,8 @@ #!/bin/sh # description: Register/unregister many kprobe events +[ -f kprobe_events ] || exit_unsupported # this is configurable + # ftrace fentry skip size depends on the machine architecture. # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le case `uname -m` in -- 2.11.0
[PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
The multiple_kprobes test case fails to check for KPROBE_EVENT support. Add the check to prevent a false test result. Signed-off-by: Thomas Meyer --- tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc index 2a1cb9908746..a4fd4c851a5b 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc @@ -1,6 +1,8 @@ #!/bin/sh # description: Register/unregister many kprobe events +[ -f kprobe_events ] || exit_unsupported # this is configurable + # ftrace fentry skip size depends on the machine architecture. # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le case `uname -m` in -- 2.11.0