Re: [PATCH 1/3] staging: dgnc: remove redundant NULL check in

[DaeSeok Youn]

2016-05-09 21:08 GMT+09:00 Greg KH :
> On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
>> tty and ch are already checked for NULL
>> before calling dgnc_block_til_ready().
>>
>> Signed-off-by: Daeseok Youn 
>
> Your subject line doesn't make sense, please fix it up and resend.
OK. I will resend this.

thanks

regards,
Daeseok.

>
> thanks,
>
> greg k-h

Re: [PATCH 1/3] staging: dgnc: remove redundant NULL check in

[DaeSeok Youn]

2016-05-09 21:08 GMT+09:00 Greg KH :
> On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
>> tty and ch are already checked for NULL
>> before calling dgnc_block_til_ready().
>>
>> Signed-off-by: Daeseok Youn 
>
> Your subject line doesn't make sense, please fix it up and resend.
OK. I will resend this.

thanks

regards,
Daeseok.

>
> thanks,
>
> greg k-h

Re: [PATCH 1/3] staging: dgnc: remove redundant NULL check in

[Greg KH]

On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
> tty and ch are already checked for NULL
> before calling dgnc_block_til_ready().
> 
> Signed-off-by: Daeseok Youn 

Your subject line doesn't make sense, please fix it up and resend.

thanks,

greg k-h

Re: [PATCH 1/3] staging: dgnc: remove redundant NULL check in

[Greg KH]

On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
> tty and ch are already checked for NULL
> before calling dgnc_block_til_ready().
> 
> Signed-off-by: Daeseok Youn 

Your subject line doesn't make sense, please fix it up and resend.

thanks,

greg k-h

[PATCH 1/3] staging: dgnc: remove redundant NULL check in

[Daeseok Youn]

tty and ch are already checked for NULL
before calling dgnc_block_til_ready().

Signed-off-by: Daeseok Youn 
---
 drivers/staging/dgnc/dgnc_tty.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2cecdb0..d85d005 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1172,17 +1172,12 @@ static int dgnc_block_til_ready(struct tty_struct *tty,
struct channel_t *ch)
 {
int retval = 0;
-   struct un_t *un = NULL;
+   struct un_t *un = tty->driver_data;
unsigned long flags;
uintold_flags = 0;
int sleep_on_un_flags = 0;
 
-   if (!tty || tty->magic != TTY_MAGIC || !file || !ch ||
-   ch->magic != DGNC_CHANNEL_MAGIC)
-   return -ENXIO;
-
-   un = tty->driver_data;
-   if (!un || un->magic != DGNC_UNIT_MAGIC)
+   if (!file)
return -ENXIO;
 
spin_lock_irqsave(>ch_lock, flags);
-- 
2.8.2

[PATCH 1/3] staging: dgnc: remove redundant NULL check in

[Daeseok Youn]

tty and ch are already checked for NULL
before calling dgnc_block_til_ready().

Signed-off-by: Daeseok Youn 
---
 drivers/staging/dgnc/dgnc_tty.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2cecdb0..d85d005 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1172,17 +1172,12 @@ static int dgnc_block_til_ready(struct tty_struct *tty,
struct channel_t *ch)
 {
int retval = 0;
-   struct un_t *un = NULL;
+   struct un_t *un = tty->driver_data;
unsigned long flags;
uintold_flags = 0;
int sleep_on_un_flags = 0;
 
-   if (!tty || tty->magic != TTY_MAGIC || !file || !ch ||
-   ch->magic != DGNC_CHANNEL_MAGIC)
-   return -ENXIO;
-
-   un = tty->driver_data;
-   if (!un || un->magic != DGNC_UNIT_MAGIC)
+   if (!file)
return -ENXIO;
 
spin_lock_irqsave(>ch_lock, flags);
-- 
2.8.2