Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings
On Fri, 13 Oct 2023 10:09:53 +0200 Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. > > Signed-off-by: Luca Weiss I assume this will go with the dts changes that use it. Acked-by: Jonathan Cameron > --- > include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h | 69 > + > 1 file changed, 69 insertions(+) > > diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > new file mode 100644 > index ..96908014e09e > --- /dev/null > +++ b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > @@ -0,0 +1,69 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2020 The Linux Foundation. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_QCOM_SPMI_VADC_PM7325_H > +#define _DT_BINDINGS_QCOM_SPMI_VADC_PM7325_H > + > +#ifndef PM7325_SID > +#define PM7325_SID 1 > +#endif > + > +#include > + > +/* ADC channels for PM7325_ADC for PMIC7 */ > +#define PM7325_ADC7_REF_GND (PM7325_SID << 8 | ADC7_REF_GND) > +#define PM7325_ADC7_1P25VREF (PM7325_SID << 8 | > ADC7_1P25VREF) > +#define PM7325_ADC7_VREF_VADC(PM7325_SID << 8 | > ADC7_VREF_VADC) > +#define PM7325_ADC7_DIE_TEMP (PM7325_SID << 8 | > ADC7_DIE_TEMP) > + > +#define PM7325_ADC7_AMUX_THM1(PM7325_SID << 8 | > ADC7_AMUX_THM1) > +#define PM7325_ADC7_AMUX_THM2(PM7325_SID << 8 | > ADC7_AMUX_THM2) > +#define PM7325_ADC7_AMUX_THM3(PM7325_SID << 8 | > ADC7_AMUX_THM3) > +#define PM7325_ADC7_AMUX_THM4(PM7325_SID << 8 | > ADC7_AMUX_THM4) > +#define PM7325_ADC7_AMUX_THM5(PM7325_SID << 8 | > ADC7_AMUX_THM5) > +#define PM7325_ADC7_GPIO1(PM7325_SID << 8 | ADC7_GPIO1) > +#define PM7325_ADC7_GPIO2(PM7325_SID << 8 | ADC7_GPIO2) > +#define PM7325_ADC7_GPIO3(PM7325_SID << 8 | ADC7_GPIO3) > +#define PM7325_ADC7_GPIO4(PM7325_SID << 8 | ADC7_GPIO4) > + > +/* 30k pull-up1 */ > +#define PM7325_ADC7_AMUX_THM1_30K_PU (PM7325_SID << 8 | > ADC7_AMUX_THM1_30K_PU) > +#define PM7325_ADC7_AMUX_THM2_30K_PU (PM7325_SID << 8 | > ADC7_AMUX_THM2_30K_PU) > +#define PM7325_ADC7_AMUX_THM3_30K_PU (PM7325_SID << 8 | > ADC7_AMUX_THM3_30K_PU) > +#define PM7325_ADC7_AMUX_THM4_30K_PU (PM7325_SID << 8 | > ADC7_AMUX_THM4_30K_PU) > +#define PM7325_ADC7_AMUX_THM5_30K_PU (PM7325_SID << 8 | > ADC7_AMUX_THM5_30K_PU) > +#define PM7325_ADC7_GPIO1_30K_PU (PM7325_SID << 8 | > ADC7_GPIO1_30K_PU) > +#define PM7325_ADC7_GPIO2_30K_PU (PM7325_SID << 8 | > ADC7_GPIO2_30K_PU) > +#define PM7325_ADC7_GPIO3_30K_PU (PM7325_SID << 8 | > ADC7_GPIO3_30K_PU) > +#define PM7325_ADC7_GPIO4_30K_PU (PM7325_SID << 8 | > ADC7_GPIO4_30K_PU) > + > +/* 100k pull-up2 */ > +#define PM7325_ADC7_AMUX_THM1_100K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM1_100K_PU) > +#define PM7325_ADC7_AMUX_THM2_100K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM2_100K_PU) > +#define PM7325_ADC7_AMUX_THM3_100K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM3_100K_PU) > +#define PM7325_ADC7_AMUX_THM4_100K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM4_100K_PU) > +#define PM7325_ADC7_AMUX_THM5_100K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM5_100K_PU) > +#define PM7325_ADC7_GPIO1_100K_PU(PM7325_SID << 8 | > ADC7_GPIO1_100K_PU) > +#define PM7325_ADC7_GPIO2_100K_PU(PM7325_SID << 8 | > ADC7_GPIO2_100K_PU) > +#define PM7325_ADC7_GPIO3_100K_PU(PM7325_SID << 8 | > ADC7_GPIO3_100K_PU) > +#define PM7325_ADC7_GPIO4_100K_PU(PM7325_SID << 8 | > ADC7_GPIO4_100K_PU) > + > +/* 400k pull-up3 */ > +#define PM7325_ADC7_AMUX_THM1_400K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM1_400K_PU) > +#define PM7325_ADC7_AMUX_THM2_400K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM2_400K_PU) > +#define PM7325_ADC7_AMUX_THM3_400K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM3_400K_PU) > +#define PM7325_ADC7_AMUX_THM4_400K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM4_400K_PU) > +#define PM7325_ADC7_AMUX_THM5_400K_PU(PM7325_SID << 8 | > ADC7_AMUX_THM5_400K_PU) > +#define PM7325_ADC7_GPIO1_400K_PU(PM7325_SID << 8 | > ADC7_GPIO1_400K_PU) > +#define PM7325_ADC7_GPIO2_400K_PU(PM7325_SID << 8 | > ADC7_GPIO2_400K_PU) > +#define PM7325_ADC7_GPIO3_400K_PU(PM7325_SID << 8 | > ADC7_GPIO3_400K_PU) > +#define PM7325_ADC7_GPIO4_400K_PU(PM7325_SID << 8 | > ADC7_GPIO4_400K_PU) > + > +/* 1/3 Divider */ > +#define PM7325_ADC7_GPIO4_DIV3 (PM7325_SID << 8 | > ADC7_GPIO4_DIV3) > + >
Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings
On 13/10/2023 10:54, Luca Weiss wrote: >> We expect the bindings to be dual licensed. What was the license of the >> original work? > > Yes, just GPL-2.0-only: > https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LA.UM.9.14.1.r1-08600-QCM6490.QSSI13.0/include/dt-bindings/iio/qcom%2Cspmi-adc7-pm7325.h > > Unfortunately it's the same situation with all the other header files > like this one. > > $ grep SPDX include/dt-bindings/iio/qcom,spmi-adc7-* > include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h:/* SPDX-License-Identifier: > GPL-2.0-only */ > include/dt-bindings/iio/qcom,spmi-adc7-pm8350b.h:/* > SPDX-License-Identifier: GPL-2.0-only */ > include/dt-bindings/iio/qcom,spmi-adc7-pmk8350.h:/* > SPDX-License-Identifier: GPL-2.0-only */ > include/dt-bindings/iio/qcom,spmi-adc7-pmr735a.h:/* > SPDX-License-Identifier: GPL-2.0-only */ > include/dt-bindings/iio/qcom,spmi-adc7-pmr735b.h:/* > SPDX-License-Identifier: GPL-2.0-only */ > > If you know someone at Qualcomm to ask nicely to relicense those (plus > ones that will presumably be added later), that'd be appreciated. We could relicense Qualcomm stuff but this was transferred to Linux Foundation. :/ Best regards, Krzysztof
Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings
On Fri Oct 13, 2023 at 10:38 AM CEST, Krzysztof Kozlowski wrote: > On 13/10/2023 10:09, Luca Weiss wrote: > > Add the defines for the ADC channels found on the PM7325. The list is > > taken from downstream msm-5.4 and adjusted for mainline. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. Seems very inconsistent (git log --oneline include/dt-bindings/iio/qcom,*) but I guess this would fit better? dt-bindings: iio: adc: Add PM7325 PMIC7 ADC bindings Will update for v2. > > > > > Signed-off-by: Luca Weiss > > --- > > include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h | 69 > > + > > 1 file changed, 69 insertions(+) > > > > diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > > b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > > new file mode 100644 > > index ..96908014e09e > > --- /dev/null > > +++ b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > > @@ -0,0 +1,69 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > We expect the bindings to be dual licensed. What was the license of the > original work? Yes, just GPL-2.0-only: https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LA.UM.9.14.1.r1-08600-QCM6490.QSSI13.0/include/dt-bindings/iio/qcom%2Cspmi-adc7-pm7325.h Unfortunately it's the same situation with all the other header files like this one. $ grep SPDX include/dt-bindings/iio/qcom,spmi-adc7-* include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h:/* SPDX-License-Identifier: GPL-2.0-only */ include/dt-bindings/iio/qcom,spmi-adc7-pm8350b.h:/* SPDX-License-Identifier: GPL-2.0-only */ include/dt-bindings/iio/qcom,spmi-adc7-pmk8350.h:/* SPDX-License-Identifier: GPL-2.0-only */ include/dt-bindings/iio/qcom,spmi-adc7-pmr735a.h:/* SPDX-License-Identifier: GPL-2.0-only */ include/dt-bindings/iio/qcom,spmi-adc7-pmr735b.h:/* SPDX-License-Identifier: GPL-2.0-only */ If you know someone at Qualcomm to ask nicely to relicense those (plus ones that will presumably be added later), that'd be appreciated. Regards Luca > > > +/* > > + * Copyright (c) 2020 The Linux Foundation. All rights reserved. > > + */ > > > > Best regards, > Krzysztof
Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings
On 13/10/2023 10:09, Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > > Signed-off-by: Luca Weiss > --- > include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h | 69 > + > 1 file changed, 69 insertions(+) > > diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > new file mode 100644 > index ..96908014e09e > --- /dev/null > +++ b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h > @@ -0,0 +1,69 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ We expect the bindings to be dual licensed. What was the license of the original work? > +/* > + * Copyright (c) 2020 The Linux Foundation. All rights reserved. > + */ Best regards, Krzysztof
[PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings
Add the defines for the ADC channels found on the PM7325. The list is taken from downstream msm-5.4 and adjusted for mainline. Signed-off-by: Luca Weiss --- include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h | 69 + 1 file changed, 69 insertions(+) diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h new file mode 100644 index ..96908014e09e --- /dev/null +++ b/include/dt-bindings/iio/qcom,spmi-adc7-pm7325.h @@ -0,0 +1,69 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2020 The Linux Foundation. All rights reserved. + */ + +#ifndef _DT_BINDINGS_QCOM_SPMI_VADC_PM7325_H +#define _DT_BINDINGS_QCOM_SPMI_VADC_PM7325_H + +#ifndef PM7325_SID +#define PM7325_SID 1 +#endif + +#include + +/* ADC channels for PM7325_ADC for PMIC7 */ +#define PM7325_ADC7_REF_GND(PM7325_SID << 8 | ADC7_REF_GND) +#define PM7325_ADC7_1P25VREF (PM7325_SID << 8 | ADC7_1P25VREF) +#define PM7325_ADC7_VREF_VADC (PM7325_SID << 8 | ADC7_VREF_VADC) +#define PM7325_ADC7_DIE_TEMP (PM7325_SID << 8 | ADC7_DIE_TEMP) + +#define PM7325_ADC7_AMUX_THM1 (PM7325_SID << 8 | ADC7_AMUX_THM1) +#define PM7325_ADC7_AMUX_THM2 (PM7325_SID << 8 | ADC7_AMUX_THM2) +#define PM7325_ADC7_AMUX_THM3 (PM7325_SID << 8 | ADC7_AMUX_THM3) +#define PM7325_ADC7_AMUX_THM4 (PM7325_SID << 8 | ADC7_AMUX_THM4) +#define PM7325_ADC7_AMUX_THM5 (PM7325_SID << 8 | ADC7_AMUX_THM5) +#define PM7325_ADC7_GPIO1 (PM7325_SID << 8 | ADC7_GPIO1) +#define PM7325_ADC7_GPIO2 (PM7325_SID << 8 | ADC7_GPIO2) +#define PM7325_ADC7_GPIO3 (PM7325_SID << 8 | ADC7_GPIO3) +#define PM7325_ADC7_GPIO4 (PM7325_SID << 8 | ADC7_GPIO4) + +/* 30k pull-up1 */ +#define PM7325_ADC7_AMUX_THM1_30K_PU (PM7325_SID << 8 | ADC7_AMUX_THM1_30K_PU) +#define PM7325_ADC7_AMUX_THM2_30K_PU (PM7325_SID << 8 | ADC7_AMUX_THM2_30K_PU) +#define PM7325_ADC7_AMUX_THM3_30K_PU (PM7325_SID << 8 | ADC7_AMUX_THM3_30K_PU) +#define PM7325_ADC7_AMUX_THM4_30K_PU (PM7325_SID << 8 | ADC7_AMUX_THM4_30K_PU) +#define PM7325_ADC7_AMUX_THM5_30K_PU (PM7325_SID << 8 | ADC7_AMUX_THM5_30K_PU) +#define PM7325_ADC7_GPIO1_30K_PU (PM7325_SID << 8 | ADC7_GPIO1_30K_PU) +#define PM7325_ADC7_GPIO2_30K_PU (PM7325_SID << 8 | ADC7_GPIO2_30K_PU) +#define PM7325_ADC7_GPIO3_30K_PU (PM7325_SID << 8 | ADC7_GPIO3_30K_PU) +#define PM7325_ADC7_GPIO4_30K_PU (PM7325_SID << 8 | ADC7_GPIO4_30K_PU) + +/* 100k pull-up2 */ +#define PM7325_ADC7_AMUX_THM1_100K_PU (PM7325_SID << 8 | ADC7_AMUX_THM1_100K_PU) +#define PM7325_ADC7_AMUX_THM2_100K_PU (PM7325_SID << 8 | ADC7_AMUX_THM2_100K_PU) +#define PM7325_ADC7_AMUX_THM3_100K_PU (PM7325_SID << 8 | ADC7_AMUX_THM3_100K_PU) +#define PM7325_ADC7_AMUX_THM4_100K_PU (PM7325_SID << 8 | ADC7_AMUX_THM4_100K_PU) +#define PM7325_ADC7_AMUX_THM5_100K_PU (PM7325_SID << 8 | ADC7_AMUX_THM5_100K_PU) +#define PM7325_ADC7_GPIO1_100K_PU (PM7325_SID << 8 | ADC7_GPIO1_100K_PU) +#define PM7325_ADC7_GPIO2_100K_PU (PM7325_SID << 8 | ADC7_GPIO2_100K_PU) +#define PM7325_ADC7_GPIO3_100K_PU (PM7325_SID << 8 | ADC7_GPIO3_100K_PU) +#define PM7325_ADC7_GPIO4_100K_PU (PM7325_SID << 8 | ADC7_GPIO4_100K_PU) + +/* 400k pull-up3 */ +#define PM7325_ADC7_AMUX_THM1_400K_PU (PM7325_SID << 8 | ADC7_AMUX_THM1_400K_PU) +#define PM7325_ADC7_AMUX_THM2_400K_PU (PM7325_SID << 8 | ADC7_AMUX_THM2_400K_PU) +#define PM7325_ADC7_AMUX_THM3_400K_PU (PM7325_SID << 8 | ADC7_AMUX_THM3_400K_PU) +#define PM7325_ADC7_AMUX_THM4_400K_PU (PM7325_SID << 8 | ADC7_AMUX_THM4_400K_PU) +#define PM7325_ADC7_AMUX_THM5_400K_PU (PM7325_SID << 8 | ADC7_AMUX_THM5_400K_PU) +#define PM7325_ADC7_GPIO1_400K_PU (PM7325_SID << 8 | ADC7_GPIO1_400K_PU) +#define PM7325_ADC7_GPIO2_400K_PU (PM7325_SID << 8 | ADC7_GPIO2_400K_PU) +#define PM7325_ADC7_GPIO3_400K_PU (PM7325_SID << 8 | ADC7_GPIO3_400K_PU) +#define PM7325_ADC7_GPIO4_400K_PU (PM7325_SID << 8 | ADC7_GPIO4_400K_PU) + +/* 1/3 Divider */ +#define PM7325_ADC7_GPIO4_DIV3 (PM7325_SID << 8 | ADC7_GPIO4_DIV3) + +#define PM7325_ADC7_VPH_PWR(PM7325_SID << 8 | ADC7_VPH_PWR) + +#endif /* _DT_BINDINGS_QCOM_SPMI_VADC_PM7325_H */ -- 2.42.0
