Re: [PATCH 1/5] mfd: Add DT bindings for tps65218 PMIC

2014-07-03 Thread Felipe Balbi
Hi,

On Thu, Jul 03, 2014 at 07:14:58PM +0530, Keerthy wrote:
> Add DT bindings for tps65218 PMIC
> 
> Signed-off-by: Keerthy 
> ---
>  Documentation/devicetree/bindings/mfd/tps65218.txt |   57 
> 
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt 
> b/Documentation/devicetree/bindings/mfd/tps65218.txt
> new file mode 100644
> index 000..38f48ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
> @@ -0,0 +1,57 @@
> +Texas Instruments TPS65218 family
> +
> +The TPS65218 are Integrated Power Management Chips.
> +
> +Required properties:
> +- compatible : Must be "ti,tps65218";
> +  For Integrated power-management used in AM437x based boards
> +- interrupts : This i2c device has an IRQ line connected to the main SoC
> +- interrupt-controller : Since the tps65218 supports several interrupts
> +  internally, it is considered as an interrupt controller cascaded to the
> +  SoC one.
> +- #interrupt-cells = <2>;
> +- interrupt-parent : The parent interrupt controller which is gic.
> +
> +Optional node:
> +- TPS65218 PMIC has a number of child nodes. Mainly the regularors and SMPSs.
> +
> +Example:
> +/*
> + * Integrated Power Management Chip
> + */
> +tps65218: tps65218@24 {
> + reg = <0x24>;
> + compatible = "ti,tps65218";
> + interrupts = ; /* NMIn */
> + interrupt-parent = <>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + dcdc1: regulator-dcdc1 {
> + compatible = "ti,tps65218-dcdc1";
> + /* VDD_CORE voltage limits min of OPP50 and max of OPP100 */

wonder if this comment really makes sense here as boards might have
another regulator assignment. Likewise fro the other two regulators.
Also, this device provides 7 regulated outputs according to [1], why
only provide three here ?

[1] http://www.ti.com/product/tps65218

-- 
balbi


signature.asc
Description: Digital signature


[PATCH 1/5] mfd: Add DT bindings for tps65218 PMIC

2014-07-03 Thread Keerthy
Add DT bindings for tps65218 PMIC

Signed-off-by: Keerthy 
---
 Documentation/devicetree/bindings/mfd/tps65218.txt |   57 
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt

diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt 
b/Documentation/devicetree/bindings/mfd/tps65218.txt
new file mode 100644
index 000..38f48ef
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
@@ -0,0 +1,57 @@
+Texas Instruments TPS65218 family
+
+The TPS65218 are Integrated Power Management Chips.
+
+Required properties:
+- compatible : Must be "ti,tps65218";
+  For Integrated power-management used in AM437x based boards
+- interrupts : This i2c device has an IRQ line connected to the main SoC
+- interrupt-controller : Since the tps65218 supports several interrupts
+  internally, it is considered as an interrupt controller cascaded to the
+  SoC one.
+- #interrupt-cells = <2>;
+- interrupt-parent : The parent interrupt controller which is gic.
+
+Optional node:
+- TPS65218 PMIC has a number of child nodes. Mainly the regularors and SMPSs.
+
+Example:
+/*
+ * Integrated Power Management Chip
+ */
+tps65218: tps65218@24 {
+   reg = <0x24>;
+   compatible = "ti,tps65218";
+   interrupts = ; /* NMIn */
+   interrupt-parent = <>;
+   interrupt-controller;
+   #interrupt-cells = <2>;
+
+   dcdc1: regulator-dcdc1 {
+   compatible = "ti,tps65218-dcdc1";
+   /* VDD_CORE voltage limits min of OPP50 and max of OPP100 */
+   regulator-name = "vdd_core";
+   regulator-min-microvolt = <912000>;
+   regulator-max-microvolt = <1144000>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   dcdc2: regulator-dcdc2 {
+   compatible = "ti,tps65218-dcdc2";
+   /* VDD_MPU voltage limits min of OPP50 and max of OPP_NITRO */
+   regulator-name = "vdd_mpu";
+   regulator-min-microvolt = <912000>;
+   regulator-max-microvolt = <1378000>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   ldo1: regulator-ldo1 {
+   compatible = "ti,tps65218-ldo1";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+};
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 1/5] mfd: Add DT bindings for tps65218 PMIC

2014-07-03 Thread Keerthy
Add DT bindings for tps65218 PMIC

Signed-off-by: Keerthy j-keer...@ti.com
---
 Documentation/devicetree/bindings/mfd/tps65218.txt |   57 
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt

diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt 
b/Documentation/devicetree/bindings/mfd/tps65218.txt
new file mode 100644
index 000..38f48ef
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
@@ -0,0 +1,57 @@
+Texas Instruments TPS65218 family
+
+The TPS65218 are Integrated Power Management Chips.
+
+Required properties:
+- compatible : Must be ti,tps65218;
+  For Integrated power-management used in AM437x based boards
+- interrupts : This i2c device has an IRQ line connected to the main SoC
+- interrupt-controller : Since the tps65218 supports several interrupts
+  internally, it is considered as an interrupt controller cascaded to the
+  SoC one.
+- #interrupt-cells = 2;
+- interrupt-parent : The parent interrupt controller which is gic.
+
+Optional node:
+- TPS65218 PMIC has a number of child nodes. Mainly the regularors and SMPSs.
+
+Example:
+/*
+ * Integrated Power Management Chip
+ */
+tps65218: tps65218@24 {
+   reg = 0x24;
+   compatible = ti,tps65218;
+   interrupts = GIC_SPI 7 IRQ_TYPE_NONE; /* NMIn */
+   interrupt-parent = gic;
+   interrupt-controller;
+   #interrupt-cells = 2;
+
+   dcdc1: regulator-dcdc1 {
+   compatible = ti,tps65218-dcdc1;
+   /* VDD_CORE voltage limits min of OPP50 and max of OPP100 */
+   regulator-name = vdd_core;
+   regulator-min-microvolt = 912000;
+   regulator-max-microvolt = 1144000;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   dcdc2: regulator-dcdc2 {
+   compatible = ti,tps65218-dcdc2;
+   /* VDD_MPU voltage limits min of OPP50 and max of OPP_NITRO */
+   regulator-name = vdd_mpu;
+   regulator-min-microvolt = 912000;
+   regulator-max-microvolt = 1378000;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   ldo1: regulator-ldo1 {
+   compatible = ti,tps65218-ldo1;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+};
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 1/5] mfd: Add DT bindings for tps65218 PMIC

2014-07-03 Thread Felipe Balbi
Hi,

On Thu, Jul 03, 2014 at 07:14:58PM +0530, Keerthy wrote:
 Add DT bindings for tps65218 PMIC
 
 Signed-off-by: Keerthy j-keer...@ti.com
 ---
  Documentation/devicetree/bindings/mfd/tps65218.txt |   57 
 
  1 file changed, 57 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt
 
 diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt 
 b/Documentation/devicetree/bindings/mfd/tps65218.txt
 new file mode 100644
 index 000..38f48ef
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
 @@ -0,0 +1,57 @@
 +Texas Instruments TPS65218 family
 +
 +The TPS65218 are Integrated Power Management Chips.
 +
 +Required properties:
 +- compatible : Must be ti,tps65218;
 +  For Integrated power-management used in AM437x based boards
 +- interrupts : This i2c device has an IRQ line connected to the main SoC
 +- interrupt-controller : Since the tps65218 supports several interrupts
 +  internally, it is considered as an interrupt controller cascaded to the
 +  SoC one.
 +- #interrupt-cells = 2;
 +- interrupt-parent : The parent interrupt controller which is gic.
 +
 +Optional node:
 +- TPS65218 PMIC has a number of child nodes. Mainly the regularors and SMPSs.
 +
 +Example:
 +/*
 + * Integrated Power Management Chip
 + */
 +tps65218: tps65218@24 {
 + reg = 0x24;
 + compatible = ti,tps65218;
 + interrupts = GIC_SPI 7 IRQ_TYPE_NONE; /* NMIn */
 + interrupt-parent = gic;
 + interrupt-controller;
 + #interrupt-cells = 2;
 +
 + dcdc1: regulator-dcdc1 {
 + compatible = ti,tps65218-dcdc1;
 + /* VDD_CORE voltage limits min of OPP50 and max of OPP100 */

wonder if this comment really makes sense here as boards might have
another regulator assignment. Likewise fro the other two regulators.
Also, this device provides 7 regulated outputs according to [1], why
only provide three here ?

[1] http://www.ti.com/product/tps65218

-- 
balbi


signature.asc
Description: Digital signature