Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb_halinit.c

2019-07-26 Thread Joe Perches 
On Fri, 2019-07-26 at 20:04 +0200, Michael Straube wrote:
> Add spaces around '+' to improve readability and follow kernel
> coding style. Reported by checkpatch.

My preference would be to do all the horizontal whitespace
changes for the entire driver in one go without worrying
about long lines.

$ git ls-files -- 'drivers/staging/rtl8188eu/*.[ch]' | \
  xargs ./scripts/checkpatch.pl -f --types=SPACING --fix-inplace
$ git diff -w drivers/staging/rtl8188eu/
$ git diff --shortstat drivers/staging/rtl8188eu
 35 files changed, 603 insertions(+), 603 deletions(-)

Mention that git diff -w shows no difference and
verify that object files are unchanged and mention
both in the changelog.

Subject could be something like:

staging: rtl8188eu: Use typical kernel horizontal whitespace

Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb_halinit.c

2019-07-26 Thread Larry Finger 

On 7/26/19 1:04 PM, Michael Straube wrote:

Add spaces around '+' to improve readability and follow kernel
coding style. Reported by checkpatch.

Signed-off-by: Michael Straube 
---
  drivers/staging/rtl8188eu/hal/usb_halinit.c | 76 ++---
  1 file changed, 38 insertions(+), 38 deletions(-)


If they apply, all six of these are OK.

Acked-by: Larry Finger 

Larry

[PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb_halinit.c

2019-07-26 Thread Michael Straube 
Add spaces around '+' to improve readability and follow kernel
coding style. Reported by checkpatch.

Signed-off-by: Michael Straube 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 76 ++---
 1 file changed, 38 insertions(+), 38 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 994392ac249b..c2e1b000cf89 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -183,7 +183,7 @@ static void _InitTxBufferBoundary(struct adapter *Adapter, 
u8 txpktbuf_bndy)
usb_write8(Adapter, REG_TXPKTBUF_MGQ_BDNY, txpktbuf_bndy);
usb_write8(Adapter, REG_TXPKTBUF_WMAC_LBK_BF_HD, txpktbuf_bndy);
usb_write8(Adapter, REG_TRXFF_BNDY, txpktbuf_bndy);
-   usb_write8(Adapter, REG_TDECTRL+1, txpktbuf_bndy);
+   usb_write8(Adapter, REG_TDECTRL + 1, txpktbuf_bndy);
 }
 
 static void _InitPageBoundary(struct adapter *Adapter)
@@ -504,7 +504,7 @@ static void usb_AggSettingRxUpdate(struct adapter *Adapter)
switch (haldata->UsbRxAggMode) {
case USB_RX_AGG_DMA:
usb_write8(Adapter, REG_RXDMA_AGG_PG_TH, 
haldata->UsbRxAggPageCount);
-   usb_write8(Adapter, REG_RXDMA_AGG_PG_TH+1, 
haldata->UsbRxAggPageTimeout);
+   usb_write8(Adapter, REG_RXDMA_AGG_PG_TH + 1, 
haldata->UsbRxAggPageTimeout);
break;
case USB_RX_AGG_USB:
usb_write8(Adapter, REG_USB_AGG_TH, 
haldata->UsbRxAggBlockCount);
@@ -512,7 +512,7 @@ static void usb_AggSettingRxUpdate(struct adapter *Adapter)
break;
case USB_RX_AGG_MIX:
usb_write8(Adapter, REG_RXDMA_AGG_PG_TH, 
haldata->UsbRxAggPageCount);
-   usb_write8(Adapter, REG_RXDMA_AGG_PG_TH+1, 
(haldata->UsbRxAggPageTimeout & 0x1F));/* 0x280[12:8] */
+   usb_write8(Adapter, REG_RXDMA_AGG_PG_TH + 1, 
(haldata->UsbRxAggPageTimeout & 0x1F));/* 0x280[12:8] */
usb_write8(Adapter, REG_USB_AGG_TH, 
haldata->UsbRxAggBlockCount);
usb_write8(Adapter, REG_USB_AGG_TO, 
haldata->UsbRxAggBlockTimeout);
break;
@@ -569,9 +569,9 @@ static void _InitBeaconParameters(struct adapter *Adapter)
 
haldata->RegBcnCtrlVal = usb_read8(Adapter, REG_BCN_CTRL);
haldata->RegTxPause = usb_read8(Adapter, REG_TXPAUSE);
-   haldata->RegFwHwTxQCtrl = usb_read8(Adapter, REG_FWHW_TXQ_CTRL+2);
-   haldata->RegReg542 = usb_read8(Adapter, REG_TBTT_PROHIBIT+2);
-   haldata->RegCR_1 = usb_read8(Adapter, REG_CR+1);
+   haldata->RegFwHwTxQCtrl = usb_read8(Adapter, REG_FWHW_TXQ_CTRL + 2);
+   haldata->RegReg542 = usb_read8(Adapter, REG_TBTT_PROHIBIT + 2);
+   haldata->RegCR_1 = usb_read8(Adapter, REG_CR + 1);
 }
 
 static void _BeaconFunctionEnable(struct adapter *Adapter,
@@ -579,7 +579,7 @@ static void _BeaconFunctionEnable(struct adapter *Adapter,
 {
usb_write8(Adapter, REG_BCN_CTRL, (BIT(4) | BIT(3) | BIT(1)));
 
-   usb_write8(Adapter, REG_RD_CTRL+1, 0x6F);
+   usb_write8(Adapter, REG_RD_CTRL + 1, 0x6F);
 }
 
 /*  Set CCK and OFDM Block "ON" */
@@ -770,7 +770,7 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
value8 = usb_read8(Adapter, REG_TX_RPT_CTRL);
usb_write8(Adapter,  REG_TX_RPT_CTRL, (value8 | BIT(1) | BIT(0)));
/* Set MAX RPT MACID */
-   usb_write8(Adapter,  REG_TX_RPT_CTRL+1, 2);/* FOR sta mode ,0: bc/mc 
,1:AP */
+   usb_write8(Adapter,  REG_TX_RPT_CTRL + 1, 2);/* FOR sta mode ,0: bc/mc 
,1:AP */
/* Tx RPT Timer. Unit: 32us */
usb_write16(Adapter, REG_TX_RPT_TIME, 0xCdf0);
 
@@ -827,10 +827,10 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
pwrctrlpriv->rf_pwrstate = rf_on;
 
/*  enable Tx report. */
-   usb_write8(Adapter,  REG_FWHW_TXQ_CTRL+1, 0x0F);
+   usb_write8(Adapter,  REG_FWHW_TXQ_CTRL + 1, 0x0F);
 
/*  Suggested by SD1 pisa. Added by tynli. 2011.10.21. */
-   usb_write8(Adapter, REG_EARLY_MODE_CONTROL+3, 0x01);/* Pretx_en, for 
WEP/TKIP SEC */
+   usb_write8(Adapter, REG_EARLY_MODE_CONTROL + 3, 0x01);/* Pretx_en, for 
WEP/TKIP SEC */
 
/* tynli_test_tx_report. */
usb_write16(Adapter, REG_TX_RPT_TIME, 0x3DF0);
@@ -894,9 +894,9 @@ static void CardDisableRTL8188EU(struct adapter *Adapter)
val8 = usb_read8(Adapter, REG_MCUFWDL);
if ((val8 & RAM_DL_SEL) && Adapter->bFWReady) { /* 8051 RAM code */
/*  Reset MCU 0x2[10]=0. */
-   val8 = usb_read8(Adapter, REG_SYS_FUNC_EN+1);
+   val8 = usb_read8(Adapter, REG_SYS_FUNC_EN + 1);
val8 &= ~BIT(2);/*  0x2[10], FEN_CPUEN */
-   usb_write8(Adapter, REG_SYS_FUNC_EN+1, val8);
+   usb_write8(Adapter, REG_SYS_FUNC_EN + 1, val8);
}
 
/*  reset MCU ready status */
@@ -912,10 +912,10 @@ static void CardDisableRTL8188EU(struct adapter *Adapter)