Re: [PATCH 1/7] USB: cdc-acm: fix double free on probe failure

2021-03-22 Thread Oliver Neukum
Am Donnerstag, den 18.03.2021, 16:51 +0100 schrieb Johan Hovold:
> If tty-device registration fails the driver copy of any Country
> Selection functional descriptor would end up being freed twice; first
> explicitly in the error path and then again in the tty-port destructor.
> 
> Drop the first erroneous free that was left when fixing a tty-port
> resource leak.
> 
> Fixes: cae2bc768d17 ("usb: cdc-acm: Decrement tty port's refcount if probe() 
> fail")
> Cc: sta...@vger.kernel.org  # 4.19
> Cc: Jaejoong Kim 
> Signed-off-by: Johan Hovold 
Acked-by: Oliver Neukum 



[PATCH 1/7] USB: cdc-acm: fix double free on probe failure

2021-03-18 Thread Johan Hovold
If tty-device registration fails the driver copy of any Country
Selection functional descriptor would end up being freed twice; first
explicitly in the error path and then again in the tty-port destructor.

Drop the first erroneous free that was left when fixing a tty-port
resource leak.

Fixes: cae2bc768d17 ("usb: cdc-acm: Decrement tty port's refcount if probe() 
fail")
Cc: sta...@vger.kernel.org  # 4.19
Cc: Jaejoong Kim 
Signed-off-by: Johan Hovold 
---
 drivers/usb/class/cdc-acm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 39ddb5585ded..d75a78ad464d 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1508,7 +1508,6 @@ static int acm_probe(struct usb_interface *intf,
_attr_wCountryCodes);
device_remove_file(>control->dev,
_attr_iCountryCodeRelDate);
-   kfree(acm->country_codes);
}
device_remove_file(>control->dev, _attr_bmCapabilities);
 alloc_fail5:
-- 
2.26.2