[PATCH 1/8] cgroup: warn if "xattr" is specified with "sane_behavior"
Mount option "xattr" is no longer necessary as it's enabled by default
on kernfs. Warn if "xattr" is specified with "sane_behavior" so that
the option can be removed in the future.
Signed-off-by: Tejun Heo
---
include/linux/cgroup.h | 2 ++
kernel/cgroup.c| 3 +++
2 files changed, 5 insertions(+)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b6c2652..6fe238e 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -262,6 +262,8 @@ enum {
* - "release_agent" and "notify_on_release" are removed.
* Replacement notification mechanism will be implemented.
*
+* - "xattr" mount option is deprecated. kernfs always enables it.
+*
* - cpuset: tasks will be kept in empty cpusets when hotplug happens
* and take masks of ancestors with non-empty cpus/mems, instead of
* being moved to an ancestor.
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 203438e..6b96516 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1265,6 +1265,9 @@ static int parse_cgroupfs_options(char *data, struct
cgroup_sb_opts *opts)
pr_err("cgroup: sane_behavior: clone_children is not
allowed\n");
return -EINVAL;
}
+
+ if (opts->flags & CGRP_ROOT_XATTR)
+ pr_warning("cgroup: sane_behavior: xattr is always
available, flag unnecessary\n");
}
/*
--
1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/8] cgroup: warn if xattr is specified with sane_behavior
Mount option xattr is no longer necessary as it's enabled by default
on kernfs. Warn if xattr is specified with sane_behavior so that
the option can be removed in the future.
Signed-off-by: Tejun Heo t...@kernel.org
---
include/linux/cgroup.h | 2 ++
kernel/cgroup.c| 3 +++
2 files changed, 5 insertions(+)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b6c2652..6fe238e 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -262,6 +262,8 @@ enum {
* - release_agent and notify_on_release are removed.
* Replacement notification mechanism will be implemented.
*
+* - xattr mount option is deprecated. kernfs always enables it.
+*
* - cpuset: tasks will be kept in empty cpusets when hotplug happens
* and take masks of ancestors with non-empty cpus/mems, instead of
* being moved to an ancestor.
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 203438e..6b96516 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1265,6 +1265,9 @@ static int parse_cgroupfs_options(char *data, struct
cgroup_sb_opts *opts)
pr_err(cgroup: sane_behavior: clone_children is not
allowed\n);
return -EINVAL;
}
+
+ if (opts-flags CGRP_ROOT_XATTR)
+ pr_warning(cgroup: sane_behavior: xattr is always
available, flag unnecessary\n);
}
/*
--
1.8.5.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/8] cgroup: warn if "xattr" is specified with "sane_behavior"
Mount option "xattr" is no longer necessary as it's enabled by default
on kernfs. Warn if "xattr" is specified with "sane_behavior" so that
the option can be removed in the future.
Signed-off-by: Tejun Heo
---
include/linux/cgroup.h | 2 ++
kernel/cgroup.c| 3 +++
2 files changed, 5 insertions(+)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b6c2652..6fe238e 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -262,6 +262,8 @@ enum {
* - "release_agent" and "notify_on_release" are removed.
* Replacement notification mechanism will be implemented.
*
+* - "xattr" mount option is deprecated. kernfs always enables it.
+*
* - cpuset: tasks will be kept in empty cpusets when hotplug happens
* and take masks of ancestors with non-empty cpus/mems, instead of
* being moved to an ancestor.
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e60a5e3..056bd7d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1265,6 +1265,9 @@ static int parse_cgroupfs_options(char *data, struct
cgroup_sb_opts *opts)
pr_err("cgroup: sane_behavior: clone_children is not
allowed\n");
return -EINVAL;
}
+
+ if (opts->flags & CGRP_ROOT_XATTR)
+ pr_warning("cgroup: sane_behavior: xattr is always
available, flag unnecessary\n");
}
/*
--
1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/8] cgroup: warn if xattr is specified with sane_behavior
Mount option xattr is no longer necessary as it's enabled by default
on kernfs. Warn if xattr is specified with sane_behavior so that
the option can be removed in the future.
Signed-off-by: Tejun Heo t...@kernel.org
---
include/linux/cgroup.h | 2 ++
kernel/cgroup.c| 3 +++
2 files changed, 5 insertions(+)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b6c2652..6fe238e 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -262,6 +262,8 @@ enum {
* - release_agent and notify_on_release are removed.
* Replacement notification mechanism will be implemented.
*
+* - xattr mount option is deprecated. kernfs always enables it.
+*
* - cpuset: tasks will be kept in empty cpusets when hotplug happens
* and take masks of ancestors with non-empty cpus/mems, instead of
* being moved to an ancestor.
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e60a5e3..056bd7d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1265,6 +1265,9 @@ static int parse_cgroupfs_options(char *data, struct
cgroup_sb_opts *opts)
pr_err(cgroup: sane_behavior: clone_children is not
allowed\n);
return -EINVAL;
}
+
+ if (opts-flags CGRP_ROOT_XATTR)
+ pr_warning(cgroup: sane_behavior: xattr is always
available, flag unnecessary\n);
}
/*
--
1.8.5.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
