Re: [PATCH 1/8] soc: realview: Switch to use DEVICE_ATTR_RO()

[Linus Walleij]

On Sat, May 23, 2020 at 7:09 PM Sudeep Holla  wrote:

> Move device attributes to DEVICE_ATTR_RO() as that would make things
> a lot more "obvious" what is happening over the existing __ATTR usage.
>
> Cc: Linus Walleij 
> Signed-off-by: Sudeep Holla 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij

[PATCH 1/8] soc: realview: Switch to use DEVICE_ATTR_RO()

[Sudeep Holla]

Move device attributes to DEVICE_ATTR_RO() as that would make things
a lot more "obvious" what is happening over the existing __ATTR usage.

Cc: Linus Walleij 
Signed-off-by: Sudeep Holla 
---
 drivers/soc/versatile/soc-realview.c | 40 +++-
 1 file changed, 16 insertions(+), 24 deletions(-)

diff --git a/drivers/soc/versatile/soc-realview.c 
b/drivers/soc/versatile/soc-realview.c
index 9471353dd8c3..cb3bcb7dd824 100644
--- a/drivers/soc/versatile/soc-realview.c
+++ b/drivers/soc/versatile/soc-realview.c
@@ -39,45 +39,37 @@ static const char *realview_arch_str(u32 id)
}
 }
 
-static ssize_t realview_get_manf(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+static ssize_t
+manufacturer_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
return sprintf(buf, "%02x\n", realview_coreid >> 24);
 }
 
-static struct device_attribute realview_manf_attr =
-   __ATTR(manufacturer,  S_IRUGO, realview_get_manf,  NULL);
+static DEVICE_ATTR_RO(manufacturer);
 
-static ssize_t realview_get_board(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+static ssize_t
+board_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
return sprintf(buf, "HBI-%03x\n", ((realview_coreid >> 16) & 0xfff));
 }
 
-static struct device_attribute realview_board_attr =
-   __ATTR(board,  S_IRUGO, realview_get_board,  NULL);
+static DEVICE_ATTR_RO(board);
 
-static ssize_t realview_get_arch(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+static ssize_t
+fpga_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
return sprintf(buf, "%s\n", realview_arch_str(realview_coreid));
 }
 
-static struct device_attribute realview_arch_attr =
-   __ATTR(fpga,  S_IRUGO, realview_get_arch,  NULL);
+static DEVICE_ATTR_RO(fpga);
 
-static ssize_t realview_get_build(struct device *dev,
-  struct device_attribute *attr,
-  char *buf)
+static ssize_t
+build_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
return sprintf(buf, "%02x\n", (realview_coreid & 0xFF));
 }
 
-static struct device_attribute realview_build_attr =
-   __ATTR(build,  S_IRUGO, realview_get_build,  NULL);
+static DEVICE_ATTR_RO(build);
 
 static int realview_soc_probe(struct platform_device *pdev)
 {
@@ -112,10 +104,10 @@ static int realview_soc_probe(struct platform_device 
*pdev)
if (ret)
return -ENODEV;
 
-   device_create_file(soc_device_to_device(soc_dev), _manf_attr);
-   device_create_file(soc_device_to_device(soc_dev), _board_attr);
-   device_create_file(soc_device_to_device(soc_dev), _arch_attr);
-   device_create_file(soc_device_to_device(soc_dev), _build_attr);
+   device_create_file(soc_device_to_device(soc_dev), 
_attr_manufacturer);
+   device_create_file(soc_device_to_device(soc_dev), _attr_board);
+   device_create_file(soc_device_to_device(soc_dev), _attr_fpga);
+   device_create_file(soc_device_to_device(soc_dev), _attr_build);
 
dev_info(>dev, "RealView Syscon Core ID: 0x%08x, HBI-%03x\n",
 realview_coreid,
-- 
2.17.1