Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-12-31 Thread chas williams - CONTRACTOR 
Acked-by: chas williams - CONTRACTOR 

On Fri, 28 Dec 2012 10:46:36 +0530
Tushar Behera  wrote:

> Ping.
> 
> On 11/16/2012 12:20 PM, Tushar Behera wrote:
> > No need to check whether unsigned variable is less than 0.
> > 
> > CC: Chas Williams 
> > CC: linux-atm-gene...@lists.sourceforge.net
> > CC: net...@vger.kernel.org
> > Signed-off-by: Tushar Behera 
> > ---
> >  drivers/atm/fore200e.c |2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
> > index 361f5ae..fdd3fe7 100644
> > --- a/drivers/atm/fore200e.c
> > +++ b/drivers/atm/fore200e.c
> > @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int 
> > scheme, int magn)
> >where, scheme, magn, buffer->index, buffer->scheme);
> > }
> >  
> > -   if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ 
> > scheme ][ magn ])) {
> > +   if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
> > printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer 
> > index = %ld !\n",
> >where, scheme, magn, buffer->index);
> > }
> > 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-12-31 Thread chas williams - CONTRACTOR 
Acked-by: chas williams - CONTRACTOR c...@cmf.nrl.navy.mil

On Fri, 28 Dec 2012 10:46:36 +0530
Tushar Behera tushar.beh...@linaro.org wrote:

 Ping.
 
 On 11/16/2012 12:20 PM, Tushar Behera wrote:
  No need to check whether unsigned variable is less than 0.
  
  CC: Chas Williams c...@cmf.nrl.navy.mil
  CC: linux-atm-gene...@lists.sourceforge.net
  CC: net...@vger.kernel.org
  Signed-off-by: Tushar Behera tushar.beh...@linaro.org
  ---
   drivers/atm/fore200e.c |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
  
  diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
  index 361f5ae..fdd3fe7 100644
  --- a/drivers/atm/fore200e.c
  +++ b/drivers/atm/fore200e.c
  @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int 
  scheme, int magn)
 where, scheme, magn, buffer-index, buffer-scheme);
  }
   
  -   if ((buffer-index  0) || (buffer-index = fore200e_rx_buf_nbr[ 
  scheme ][ magn ])) {
  +   if (buffer-index = fore200e_rx_buf_nbr[ scheme ][ magn ]) {
  printk(FORE200E bsq_audit(%d): queue %d.%d, out of range buffer 
  index = %ld !\n,
 where, scheme, magn, buffer-index);
  }
  
 
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-12-27 Thread Tushar Behera 
Ping.

On 11/16/2012 12:20 PM, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
> 
> CC: Chas Williams 
> CC: linux-atm-gene...@lists.sourceforge.net
> CC: net...@vger.kernel.org
> Signed-off-by: Tushar Behera 
> ---
>  drivers/atm/fore200e.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
> index 361f5ae..fdd3fe7 100644
> --- a/drivers/atm/fore200e.c
> +++ b/drivers/atm/fore200e.c
> @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int 
> scheme, int magn)
>  where, scheme, magn, buffer->index, buffer->scheme);
>   }
>  
> - if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ 
> scheme ][ magn ])) {
> + if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
>   printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer 
> index = %ld !\n",
>  where, scheme, magn, buffer->index);
>   }
> 


-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-12-27 Thread Tushar Behera 
Ping.

On 11/16/2012 12:20 PM, Tushar Behera wrote:
 No need to check whether unsigned variable is less than 0.
 
 CC: Chas Williams c...@cmf.nrl.navy.mil
 CC: linux-atm-gene...@lists.sourceforge.net
 CC: net...@vger.kernel.org
 Signed-off-by: Tushar Behera tushar.beh...@linaro.org
 ---
  drivers/atm/fore200e.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
 index 361f5ae..fdd3fe7 100644
 --- a/drivers/atm/fore200e.c
 +++ b/drivers/atm/fore200e.c
 @@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int 
 scheme, int magn)
  where, scheme, magn, buffer-index, buffer-scheme);
   }
  
 - if ((buffer-index  0) || (buffer-index = fore200e_rx_buf_nbr[ 
 scheme ][ magn ])) {
 + if (buffer-index = fore200e_rx_buf_nbr[ scheme ][ magn ]) {
   printk(FORE200E bsq_audit(%d): queue %d.%d, out of range buffer 
 index = %ld !\n,
  where, scheme, magn, buffer-index);
   }
 


-- 
Tushar Behera
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-11-15 Thread Tushar Behera 
No need to check whether unsigned variable is less than 0.

CC: Chas Williams 
CC: linux-atm-gene...@lists.sourceforge.net
CC: net...@vger.kernel.org
Signed-off-by: Tushar Behera 
---
 drivers/atm/fore200e.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 361f5ae..fdd3fe7 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, 
int magn)
   where, scheme, magn, buffer->index, buffer->scheme);
}
 
-   if ((buffer->index < 0) || (buffer->index >= fore200e_rx_buf_nbr[ 
scheme ][ magn ])) {
+   if (buffer->index >= fore200e_rx_buf_nbr[ scheme ][ magn ]) {
printk(FORE200E "bsq_audit(%d): queue %d.%d, out of range buffer 
index = %ld !\n",
   where, scheme, magn, buffer->index);
}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-11-15 Thread Tushar Behera 
No need to check whether unsigned variable is less than 0.

CC: Chas Williams c...@cmf.nrl.navy.mil
CC: linux-atm-gene...@lists.sourceforge.net
CC: net...@vger.kernel.org
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
 drivers/atm/fore200e.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 361f5ae..fdd3fe7 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -972,7 +972,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, 
int magn)
   where, scheme, magn, buffer-index, buffer-scheme);
}
 
-   if ((buffer-index  0) || (buffer-index = fore200e_rx_buf_nbr[ 
scheme ][ magn ])) {
+   if (buffer-index = fore200e_rx_buf_nbr[ scheme ][ magn ]) {
printk(FORE200E bsq_audit(%d): queue %d.%d, out of range buffer 
index = %ld !\n,
   where, scheme, magn, buffer-index);
}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/