Re: [PATCH 11/11] arm64: dts: meson-g12a-x96-max: Enable USB
Hi Neil,
On Sat, Mar 16, 2019 at 3:46 PM Neil Armstrong wrote:
>
>
>
> Le 15/03/2019 22:50, Martin Blumenstingl a écrit :
> > Hi Neil,
> >
> > On Mon, Mar 11, 2019 at 10:58 AM Neil Armstrong
> > wrote:
> > [...]
> >> + {
> >> + status = "okay";
> >> +};
> > your patch description states that this enables the "USB host ports"
> > but dwc2 is only used for peripheral mode (meaning: dr_mode =
> > "peripheral" or dr_mode = "otg").
> > do we still need to enable dwc2 in a host-only configuration?
>
> DWC2 is peripheral-only, but we can still manually switch one of the
> ports and use it as peripheral with a Type-A to Type-A cable, thus
> enabling dwc2.
thank you for the explanation!
> If the OTG capable PHYs was behind an USB Hub or directly connected to
> a device, we could disable dwc2, but for now this port is always tied
> to a physical Type-A or micro-USB connector.
>
> Maybe it would be sane to always enable dwc2, and disable it for specific
> boards only.
In case the port is connected to an USB hub we can add a comment to
the .dts to explain why dwc2 is being disabled. that way we don't need
a comment in each board.dts that it's enabled to support forced mode
switching.
in other words: I like this idea!
Regards
Martin
Re: [PATCH 11/11] arm64: dts: meson-g12a-x96-max: Enable USB
Le 15/03/2019 22:50, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Mar 11, 2019 at 10:58 AM Neil Armstrong
> wrote:
> [...]
>> + {
>> + status = "okay";
>> +};
> your patch description states that this enables the "USB host ports"
> but dwc2 is only used for peripheral mode (meaning: dr_mode =
> "peripheral" or dr_mode = "otg").
> do we still need to enable dwc2 in a host-only configuration?
DWC2 is peripheral-only, but we can still manually switch one of the
ports and use it as peripheral with a Type-A to Type-A cable, thus
enabling dwc2.
If the OTG capable PHYs was behind an USB Hub or directly connected to
a device, we could disable dwc2, but for now this port is always tied
to a physical Type-A or micro-USB connector.
Maybe it would be sane to always enable dwc2, and disable it for specific
boards only.
Neil
>
>
> Regards
> Martin
>
Re: [PATCH 11/11] arm64: dts: meson-g12a-x96-max: Enable USB
Hi Neil,
On Mon, Mar 11, 2019 at 10:58 AM Neil Armstrong wrote:
[...]
> + {
> + status = "okay";
> +};
your patch description states that this enables the "USB host ports"
but dwc2 is only used for peripheral mode (meaning: dr_mode =
"peripheral" or dr_mode = "otg").
do we still need to enable dwc2 in a host-only configuration?
Regards
Martin
[PATCH 11/11] arm64: dts: meson-g12a-x96-max: Enable USB
Enable the USB2 and USB3 Host ports on the X96 Max Set-Top-Box.
Signed-off-by: Neil Armstrong
---
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index 61606601fb4f..625e240a9c09 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -105,3 +105,12 @@
pinctrl-0 = <_ao_a_pins>;
pinctrl-names = "default";
};
+
+ {
+ status = "okay";
+ dr_mode = "host";
+};
+
+ {
+ status = "okay";
+};
--
2.20.1
