Re: [PATCH 11/29] hwmon: (scmi-hwmon): Avoid comma separated statements

2020-08-25 Thread Guenter Roeck
On Mon, Aug 24, 2020 at 09:56:08PM -0700, Joe Perches wrote:
> Use semicolons and braces.
> 
> Signed-off-by: Joe Perches 

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/scmi-hwmon.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index d421e691318b..09ce30cba54b 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -202,8 +202,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
>   }
>   }
>  
> - if (nr_count[hwmon_temp])
> - nr_count[hwmon_chip]++, nr_types++;
> + if (nr_count[hwmon_temp]) {
> + nr_count[hwmon_chip]++;
> + nr_types++;
> + }
>  
>   scmi_hwmon_chan = devm_kcalloc(dev, nr_types, sizeof(*scmi_hwmon_chan),
>  GFP_KERNEL);


[PATCH 11/29] hwmon: (scmi-hwmon): Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces.

Signed-off-by: Joe Perches 
---
 drivers/hwmon/scmi-hwmon.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index d421e691318b..09ce30cba54b 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b/drivers/hwmon/scmi-hwmon.c
@@ -202,8 +202,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
}
}
 
-   if (nr_count[hwmon_temp])
-   nr_count[hwmon_chip]++, nr_types++;
+   if (nr_count[hwmon_temp]) {
+   nr_count[hwmon_chip]++;
+   nr_types++;
+   }
 
scmi_hwmon_chan = devm_kcalloc(dev, nr_types, sizeof(*scmi_hwmon_chan),
   GFP_KERNEL);
-- 
2.26.0