Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Bartlomiej Zolnierkiewicz]

On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote:
> On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote:
> > exynos_tmu.h is used only by exynos_tmu.c so there is no need
> > for a separate include file.
> > 
> > There should be no functional changes caused by this patch.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz 
> > ---
> >  drivers/thermal/samsung/exynos_tmu.c | 18 +++-
> >  drivers/thermal/samsung/exynos_tmu.h | 41 
> > 
> >  2 files changed, 17 insertions(+), 42 deletions(-)
> >  delete mode 100644 drivers/thermal/samsung/exynos_tmu.h
> > 
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c 
> > b/drivers/thermal/samsung/exynos_tmu.c
> > index 7975f33..197f267 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -34,8 +34,10 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> > +
> 
> This one should go away, no ?

Yes, thanks for noticing (I've just sent v2 of this patch).
.
> Apart this.
> 
> Acked-by: Daniel Lezcano 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Bartlomiej Zolnierkiewicz]

On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote:
> On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote:
> > exynos_tmu.h is used only by exynos_tmu.c so there is no need
> > for a separate include file.
> > 
> > There should be no functional changes caused by this patch.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz 
> > ---
> >  drivers/thermal/samsung/exynos_tmu.c | 18 +++-
> >  drivers/thermal/samsung/exynos_tmu.h | 41 
> > 
> >  2 files changed, 17 insertions(+), 42 deletions(-)
> >  delete mode 100644 drivers/thermal/samsung/exynos_tmu.h
> > 
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c 
> > b/drivers/thermal/samsung/exynos_tmu.c
> > index 7975f33..197f267 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -34,8 +34,10 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> > +
> 
> This one should go away, no ?

Yes, thanks for noticing (I've just sent v2 of this patch).
.
> Apart this.
> 
> Acked-by: Daniel Lezcano 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Daniel Lezcano]

On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote:
> exynos_tmu.h is used only by exynos_tmu.c so there is no need
> for a separate include file.
> 
> There should be no functional changes caused by this patch.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz 
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 18 +++-
>  drivers/thermal/samsung/exynos_tmu.h | 41 
> 
>  2 files changed, 17 insertions(+), 42 deletions(-)
>  delete mode 100644 drivers/thermal/samsung/exynos_tmu.h
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c 
> b/drivers/thermal/samsung/exynos_tmu.c
> index 7975f33..197f267 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -34,8 +34,10 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +

This one should go away, no ?

Apart this.

Acked-by: Daniel Lezcano 





-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Daniel Lezcano]

On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote:
> exynos_tmu.h is used only by exynos_tmu.c so there is no need
> for a separate include file.
> 
> There should be no functional changes caused by this patch.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz 
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 18 +++-
>  drivers/thermal/samsung/exynos_tmu.h | 41 
> 
>  2 files changed, 17 insertions(+), 42 deletions(-)
>  delete mode 100644 drivers/thermal/samsung/exynos_tmu.h
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c 
> b/drivers/thermal/samsung/exynos_tmu.c
> index 7975f33..197f267 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -34,8 +34,10 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +

This one should go away, no ?

Apart this.

Acked-by: Daniel Lezcano 





-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

[PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Bartlomiej Zolnierkiewicz]

exynos_tmu.h is used only by exynos_tmu.c so there is no need
for a separate include file.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz 
---
 drivers/thermal/samsung/exynos_tmu.c | 18 +++-
 drivers/thermal/samsung/exynos_tmu.h | 41 
 2 files changed, 17 insertions(+), 42 deletions(-)
 delete mode 100644 drivers/thermal/samsung/exynos_tmu.h

diff --git a/drivers/thermal/samsung/exynos_tmu.c 
b/drivers/thermal/samsung/exynos_tmu.c
index 7975f33..197f267 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -34,8 +34,10 @@
 #include 
 #include 
 #include 
+#include 
+
+#include 
 
-#include "exynos_tmu.h"
 #include "../thermal_core.h"
 
 /* Exynos generic registers */
@@ -173,6 +175,20 @@
 #define EXYNOS_NOISE_CANCEL_MODE   4
 
 #define MCELSIUS   1000
+
+enum soc_type {
+   SOC_ARCH_EXYNOS3250 = 1,
+   SOC_ARCH_EXYNOS4210,
+   SOC_ARCH_EXYNOS4412,
+   SOC_ARCH_EXYNOS5250,
+   SOC_ARCH_EXYNOS5260,
+   SOC_ARCH_EXYNOS5420,
+   SOC_ARCH_EXYNOS5420_TRIMINFO,
+   SOC_ARCH_EXYNOS5433,
+   SOC_ARCH_EXYNOS5440,
+   SOC_ARCH_EXYNOS7,
+};
+
 /**
  * struct exynos_tmu_data : A structure to hold the private data of the TMU
driver
diff --git a/drivers/thermal/samsung/exynos_tmu.h 
b/drivers/thermal/samsung/exynos_tmu.h
deleted file mode 100644
index 8f56f86..000
--- a/drivers/thermal/samsung/exynos_tmu.h
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * exynos_tmu.h - Samsung EXYNOS TMU (Thermal Management Unit)
- *
- *  Copyright (C) 2011 Samsung Electronics
- *  Donggeun Kim 
- *  Amit Daniel Kachhap 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- */
-
-#ifndef _EXYNOS_TMU_H
-#define _EXYNOS_TMU_H
-#include 
-#include 
-
-enum soc_type {
-   SOC_ARCH_EXYNOS3250 = 1,
-   SOC_ARCH_EXYNOS4210,
-   SOC_ARCH_EXYNOS4412,
-   SOC_ARCH_EXYNOS5250,
-   SOC_ARCH_EXYNOS5260,
-   SOC_ARCH_EXYNOS5420,
-   SOC_ARCH_EXYNOS5420_TRIMINFO,
-   SOC_ARCH_EXYNOS5433,
-   SOC_ARCH_EXYNOS5440,
-   SOC_ARCH_EXYNOS7,
-};
-
-#endif /* _EXYNOS_TMU_H */
-- 
1.9.1

[PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

[Bartlomiej Zolnierkiewicz]

exynos_tmu.h is used only by exynos_tmu.c so there is no need
for a separate include file.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz 
---
 drivers/thermal/samsung/exynos_tmu.c | 18 +++-
 drivers/thermal/samsung/exynos_tmu.h | 41 
 2 files changed, 17 insertions(+), 42 deletions(-)
 delete mode 100644 drivers/thermal/samsung/exynos_tmu.h

diff --git a/drivers/thermal/samsung/exynos_tmu.c 
b/drivers/thermal/samsung/exynos_tmu.c
index 7975f33..197f267 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -34,8 +34,10 @@
 #include 
 #include 
 #include 
+#include 
+
+#include 
 
-#include "exynos_tmu.h"
 #include "../thermal_core.h"
 
 /* Exynos generic registers */
@@ -173,6 +175,20 @@
 #define EXYNOS_NOISE_CANCEL_MODE   4
 
 #define MCELSIUS   1000
+
+enum soc_type {
+   SOC_ARCH_EXYNOS3250 = 1,
+   SOC_ARCH_EXYNOS4210,
+   SOC_ARCH_EXYNOS4412,
+   SOC_ARCH_EXYNOS5250,
+   SOC_ARCH_EXYNOS5260,
+   SOC_ARCH_EXYNOS5420,
+   SOC_ARCH_EXYNOS5420_TRIMINFO,
+   SOC_ARCH_EXYNOS5433,
+   SOC_ARCH_EXYNOS5440,
+   SOC_ARCH_EXYNOS7,
+};
+
 /**
  * struct exynos_tmu_data : A structure to hold the private data of the TMU
driver
diff --git a/drivers/thermal/samsung/exynos_tmu.h 
b/drivers/thermal/samsung/exynos_tmu.h
deleted file mode 100644
index 8f56f86..000
--- a/drivers/thermal/samsung/exynos_tmu.h
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * exynos_tmu.h - Samsung EXYNOS TMU (Thermal Management Unit)
- *
- *  Copyright (C) 2011 Samsung Electronics
- *  Donggeun Kim 
- *  Amit Daniel Kachhap 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- */
-
-#ifndef _EXYNOS_TMU_H
-#define _EXYNOS_TMU_H
-#include 
-#include 
-
-enum soc_type {
-   SOC_ARCH_EXYNOS3250 = 1,
-   SOC_ARCH_EXYNOS4210,
-   SOC_ARCH_EXYNOS4412,
-   SOC_ARCH_EXYNOS5250,
-   SOC_ARCH_EXYNOS5260,
-   SOC_ARCH_EXYNOS5420,
-   SOC_ARCH_EXYNOS5420_TRIMINFO,
-   SOC_ARCH_EXYNOS5433,
-   SOC_ARCH_EXYNOS5440,
-   SOC_ARCH_EXYNOS7,
-};
-
-#endif /* _EXYNOS_TMU_H */
-- 
1.9.1