Re: [PATCH 12/20] omapfb: get rid of pointless access_ok() calls

2020-05-14 Thread Bartlomiej Zolnierkiewicz


On 5/10/20 1:45 AM, Al Viro wrote:
> From: Al Viro 
> 
> address is passed only to copy_to_user()
> 
> Signed-off-by: Al Viro 

Acked-by: Bartlomiej Zolnierkiewicz 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c 
> b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> index 56995f44e76d..f40be68d5aac 100644
> --- a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> @@ -482,9 +482,6 @@ static int omapfb_memory_read(struct fb_info *fbi,
>   if (!display || !display->driver->memory_read)
>   return -ENOENT;
>  
> - if (!access_ok(mr->buffer, mr->buffer_size))
> - return -EFAULT;
> -
>   if (mr->w > 4096 || mr->h > 4096)
>   return -EINVAL;
>  
> 



[PATCH 12/20] omapfb: get rid of pointless access_ok() calls

2020-05-09 Thread Al Viro
From: Al Viro 

address is passed only to copy_to_user()

Signed-off-by: Al Viro 
---
 drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c 
b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
index 56995f44e76d..f40be68d5aac 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
@@ -482,9 +482,6 @@ static int omapfb_memory_read(struct fb_info *fbi,
if (!display || !display->driver->memory_read)
return -ENOENT;
 
-   if (!access_ok(mr->buffer, mr->buffer_size))
-   return -EFAULT;
-
if (mr->w > 4096 || mr->h > 4096)
return -EINVAL;
 
-- 
2.11.0