Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
Hi Lee, On Mon, Nov 16, 2020 at 10:25:30AM +, Lee Jones wrote: > On Mon, 16 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > On Mon, Nov 16, 2020 at 08:40:23AM +, Lee Jones wrote: > > > On Sat, 14 Nov 2020, Sam Ravnborg wrote: > > > > > > > Hi Lee, > > > > On Fri, Nov 13, 2020 at 01:49:10PM +, Lee Jones wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous > > > > > prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > > > > > > > Cc: Eric Anholt > > > > > Cc: David Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: dri-de...@lists.freedesktop.org > > > > > Signed-off-by: Lee Jones > > > > > > > > Eric's was not copied on this or the other pl111 patch. > > > > Added Eric so he can be aware of this fix. > > > > > > Eric Anholt? > > > > > > He's on Cc? > > Not on the original mail I received. > > Looks fine to me: > > Date: Fri, 13 Nov 2020 13:49:10 + > From: Lee Jones > To: lee.jo...@linaro.org > Cc: linux-kernel@vger.kernel.org, Eric Anholt , David Airlie > , Daniel Vetter , > dri-de...@lists.freedesktop.org > Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static > > Also reflected in Gmail: > > https://i.imgur.com/d69YTzz.png Strange indeed. In lore Eric is not included: https://lore.kernel.org/dri-devel/20201113134938.4004947-13-lee.jo...@linaro.org/ I consider this a fluke in the force, and will not worry more about it. Sam
Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
On Mon, 16 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > On Mon, Nov 16, 2020 at 08:40:23AM +, Lee Jones wrote: > > On Sat, 14 Nov 2020, Sam Ravnborg wrote: > > > > > Hi Lee, > > > On Fri, Nov 13, 2020 at 01:49:10PM +, Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous > > > > prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > > > > > Cc: Eric Anholt > > > > Cc: David Airlie > > > > Cc: Daniel Vetter > > > > Cc: dri-de...@lists.freedesktop.org > > > > Signed-off-by: Lee Jones > > > > > > Eric's was not copied on this or the other pl111 patch. > > > Added Eric so he can be aware of this fix. > > > > Eric Anholt? > > > > He's on Cc? > Not on the original mail I received. Looks fine to me: Date: Fri, 13 Nov 2020 13:49:10 + From: Lee Jones To: lee.jo...@linaro.org Cc: linux-kernel@vger.kernel.org, Eric Anholt , David Airlie , Daniel Vetter , dri-de...@lists.freedesktop.org Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Also reflected in Gmail: https://i.imgur.com/d69YTzz.png -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
Hi Lee, On Mon, Nov 16, 2020 at 08:40:23AM +, Lee Jones wrote: > On Sat, 14 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > On Fri, Nov 13, 2020 at 01:49:10PM +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous > > > prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > > > Cc: Eric Anholt > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: dri-de...@lists.freedesktop.org > > > Signed-off-by: Lee Jones > > > > Eric's was not copied on this or the other pl111 patch. > > Added Eric so he can be aware of this fix. > > Eric Anholt? > > He's on Cc? Not on the original mail I received. Sam
Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
On Sat, 14 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > On Fri, Nov 13, 2020 at 01:49:10PM +, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous > > prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > Cc: Eric Anholt > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Lee Jones > > Eric's was not copied on this or the other pl111 patch. > Added Eric so he can be aware of this fix. Eric Anholt? He's on Cc? > > --- > > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c > > b/drivers/gpu/drm/pl111/pl111_display.c > > index b3e8697cafcf1..69c02e7c82b7e 100644 > > --- a/drivers/gpu/drm/pl111/pl111_display.c > > +++ b/drivers/gpu/drm/pl111/pl111_display.c > > @@ -353,7 +353,7 @@ static void pl111_display_enable(struct > > drm_simple_display_pipe *pipe, > > drm_crtc_vblank_on(crtc); > > } > > > > -void pl111_display_disable(struct drm_simple_display_pipe *pipe) > > +static void pl111_display_disable(struct drm_simple_display_pipe *pipe) > > { > > struct drm_crtc *crtc = &pipe->crtc; > > struct drm_device *drm = crtc->dev; -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
Hi Lee, On Fri, Nov 13, 2020 at 01:49:10PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype > for ‘pl111_display_disable’ [-Wmissing-prototypes] > > Cc: Eric Anholt > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Lee Jones Eric's was not copied on this or the other pl111 patch. Added Eric so he can be aware of this fix. Sam > --- > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c > b/drivers/gpu/drm/pl111/pl111_display.c > index b3e8697cafcf1..69c02e7c82b7e 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -353,7 +353,7 @@ static void pl111_display_enable(struct > drm_simple_display_pipe *pipe, > drm_crtc_vblank_on(crtc); > } > > -void pl111_display_disable(struct drm_simple_display_pipe *pipe) > +static void pl111_display_disable(struct drm_simple_display_pipe *pipe) > { > struct drm_crtc *crtc = &pipe->crtc; > struct drm_device *drm = crtc->dev; > -- > 2.25.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 12/40] drm/pl111/pl111_display: Make local function static
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/pl111/pl111_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index b3e8697cafcf1..69c02e7c82b7e 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe, drm_crtc_vblank_on(crtc); } -void pl111_display_disable(struct drm_simple_display_pipe *pipe) +static void pl111_display_disable(struct drm_simple_display_pipe *pipe) { struct drm_crtc *crtc = &pipe->crtc; struct drm_device *drm = crtc->dev; -- 2.25.1