Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One
Hi Julian, thank you for the review. You're right. I added the pinctrl client nodes. Also the patches were split incorrectly, so I fixed that too. regards, Ondrej On 24.6.2016 04:51, Julian Calaby wrote: > Hi Ondrej, > > On Fri, Jun 24, 2016 at 5:21 AM, wrote: >> From: Ondrej Jirman >> >> Xulong Orange Pi One uses GPIO based regulator that >> switches between two voltages: 1.1V and 1.3V. The >> regulator is controlled from the PL6 pin. >> >> Signed-off-by: Ondrej Jirman >> --- >> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> index 0adf932..ce4ba91 100644 >> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> @@ -88,6 +88,25 @@ >> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; >> }; >> }; >> + >> + vdd_soc: gpio-regulator { >> + compatible = "regulator-gpio"; >> + >> + regulator-name = "soc-vdd-supply"; >> + regulator-min-microvolt = <110>; >> + regulator-max-microvolt = <130>; >> + regulator-boot-on; >> + regulator-type = "voltage"; >> + >> + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; >> + states = <110 0x0 >> + 130 0x1>; >> + >> + startup-delay-us = <10>; >> + enable-active-high; > > Don't you need to reference the new pinctl node in this one? > > Thanks, > signature.asc Description: OpenPGP digital signature
Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One
Hi Ondrej, On Fri, Jun 24, 2016 at 5:21 AM, wrote: > From: Ondrej Jirman > > Xulong Orange Pi One uses GPIO based regulator that > switches between two voltages: 1.1V and 1.3V. The > regulator is controlled from the PL6 pin. > > Signed-off-by: Ondrej Jirman > --- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > index 0adf932..ce4ba91 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > @@ -88,6 +88,25 @@ > gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; > }; > }; > + > + vdd_soc: gpio-regulator { > + compatible = "regulator-gpio"; > + > + regulator-name = "soc-vdd-supply"; > + regulator-min-microvolt = <110>; > + regulator-max-microvolt = <130>; > + regulator-boot-on; > + regulator-type = "voltage"; > + > + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; > + states = <110 0x0 > + 130 0x1>; > + > + startup-delay-us = <10>; > + enable-active-high; > + }; > +}; > + Also, isn't adding another closing bracket here a syntax error? > }; Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One
Hi Ondrej, On Fri, Jun 24, 2016 at 5:21 AM, wrote: > From: Ondrej Jirman > > Xulong Orange Pi One uses GPIO based regulator that > switches between two voltages: 1.1V and 1.3V. The > regulator is controlled from the PL6 pin. > > Signed-off-by: Ondrej Jirman > --- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > index 0adf932..ce4ba91 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > @@ -88,6 +88,25 @@ > gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; > }; > }; > + > + vdd_soc: gpio-regulator { > + compatible = "regulator-gpio"; > + > + regulator-name = "soc-vdd-supply"; > + regulator-min-microvolt = <110>; > + regulator-max-microvolt = <130>; > + regulator-boot-on; > + regulator-type = "voltage"; > + > + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; > + states = <110 0x0 > + 130 0x1>; > + > + startup-delay-us = <10>; > + enable-active-high; Don't you need to reference the new pinctl node in this one? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
[PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One
From: Ondrej Jirman Xulong Orange Pi One uses GPIO based regulator that switches between two voltages: 1.1V and 1.3V. The regulator is controlled from the PL6 pin. Signed-off-by: Ondrej Jirman --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts index 0adf932..ce4ba91 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts @@ -88,6 +88,25 @@ gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; }; }; + + vdd_soc: gpio-regulator { + compatible = "regulator-gpio"; + + regulator-name = "soc-vdd-supply"; + regulator-min-microvolt = <110>; + regulator-max-microvolt = <130>; + regulator-boot-on; + regulator-type = "voltage"; + + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; + states = <110 0x0 + 130 0x1>; + + startup-delay-us = <10>; + enable-active-high; + }; +}; + }; &ehci1 { @@ -131,6 +150,13 @@ allwinner,drive = ; allwinner,pull = ; }; + + soc_reg0: soc_reg@0 { + allwinner,pins = "PL6"; + allwinner,function = "gpio_out"; + allwinner,drive = ; + allwinner,pull = ; + }; }; &uart0 { -- 2.9.0