Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-07 Thread Arnd Bergmann 
On Thursday 07 February 2013, Stephen Warren wrote:
> On 02/05/2013 12:48 PM, Linus Walleij wrote:
> > From: Lee Jones 
> > 
> > The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
> > driver. Now that it's back in use, let's ensure that it's available
> > when booting HREF with Device Tree enabled.
> 
> > diff --git a/arch/arm/boot/dts/hrefprev60.dts 
> > b/arch/arm/boot/dts/hrefprev60.dts
> 
> >   soc-u9500 {
> > + prcmu@80157000 {
> > + ab8500@5 {
> > + ab8500-gpio {
> > + compatible = "stericsson,ab8500-gpio";
> 
> The MFDs I've looked at (which admittedly might not be that many) all
> have the top-level chip described in device tree, but not all the
> component sub-devices, since they're all a static part of the top-level
> chip. Instead, the top-level MFD instantiates all the sub-devices
> itself. I'm curious why this MFD device works differently - do many work
> like this?

I think in general, describing only the top level in DT is preferred.
However, that does not work if you have devices outside of the MFD
refer to devices inside of it, such as GPIO, clocks or interrupts:

In order to connect a button or an LED to this GPIO controller
in DT, you need to have a node you can refer to that follows the
GPIO binding. Putting all of that into the top-level device
would get messy here.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-07 Thread Arnd Bergmann 
On Thursday 07 February 2013, Stephen Warren wrote:
 On 02/05/2013 12:48 PM, Linus Walleij wrote:
  From: Lee Jones lee.jo...@linaro.org
  
  The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
  driver. Now that it's back in use, let's ensure that it's available
  when booting HREF with Device Tree enabled.
 
  diff --git a/arch/arm/boot/dts/hrefprev60.dts 
  b/arch/arm/boot/dts/hrefprev60.dts
 
soc-u9500 {
  + prcmu@80157000 {
  + ab8500@5 {
  + ab8500-gpio {
  + compatible = stericsson,ab8500-gpio;
 
 The MFDs I've looked at (which admittedly might not be that many) all
 have the top-level chip described in device tree, but not all the
 component sub-devices, since they're all a static part of the top-level
 chip. Instead, the top-level MFD instantiates all the sub-devices
 itself. I'm curious why this MFD device works differently - do many work
 like this?

I think in general, describing only the top level in DT is preferred.
However, that does not work if you have devices outside of the MFD
refer to devices inside of it, such as GPIO, clocks or interrupts:

In order to connect a button or an LED to this GPIO controller
in DT, you need to have a node you can refer to that follows the
GPIO binding. Putting all of that into the top-level device
would get messy here.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-06 Thread Stephen Warren 
On 02/05/2013 12:48 PM, Linus Walleij wrote:
> From: Lee Jones 
> 
> The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
> driver. Now that it's back in use, let's ensure that it's available
> when booting HREF with Device Tree enabled.

> diff --git a/arch/arm/boot/dts/hrefprev60.dts 
> b/arch/arm/boot/dts/hrefprev60.dts

>   soc-u9500 {
> + prcmu@80157000 {
> + ab8500@5 {
> + ab8500-gpio {
> + compatible = "stericsson,ab8500-gpio";

The MFDs I've looked at (which admittedly might not be that many) all
have the top-level chip described in device tree, but not all the
component sub-devices, since they're all a static part of the top-level
chip. Instead, the top-level MFD instantiates all the sub-devices
itself. I'm curious why this MFD device works differently - do many work
like this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-06 Thread Stephen Warren 
On 02/05/2013 12:48 PM, Linus Walleij wrote:
 From: Lee Jones lee.jo...@linaro.org
 
 The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
 driver. Now that it's back in use, let's ensure that it's available
 when booting HREF with Device Tree enabled.

 diff --git a/arch/arm/boot/dts/hrefprev60.dts 
 b/arch/arm/boot/dts/hrefprev60.dts

   soc-u9500 {
 + prcmu@80157000 {
 + ab8500@5 {
 + ab8500-gpio {
 + compatible = stericsson,ab8500-gpio;

The MFDs I've looked at (which admittedly might not be that many) all
have the top-level chip described in device tree, but not all the
component sub-devices, since they're all a static part of the top-level
chip. Instead, the top-level MFD instantiates all the sub-devices
itself. I'm curious why this MFD device works differently - do many work
like this?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-05 Thread Linus Walleij 
From: Lee Jones 

The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
driver. Now that it's back in use, let's ensure that it's available
when booting HREF with Device Tree enabled.

Cc: a...@kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij 
---
Requesting an ACK from the ARM SoC maintainers on this patch.
---
 arch/arm/boot/dts/hrefprev60.dts | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
index eec29c4..0c2b975 100644
--- a/arch/arm/boot/dts/hrefprev60.dts
+++ b/arch/arm/boot/dts/hrefprev60.dts
@@ -25,6 +25,14 @@
};
 
soc-u9500 {
+   prcmu@80157000 {
+   ab8500@5 {
+   ab8500-gpio {
+   compatible = "stericsson,ab8500-gpio";
+   };
+   };
+   };
+
i2c@80004000 {
tps61052@33 {
compatible = "tps61052";
-- 
1.7.11.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-05 Thread Linus Walleij 
From: Lee Jones lee.jo...@linaro.org

The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl
driver. Now that it's back in use, let's ensure that it's available
when booting HREF with Device Tree enabled.

Cc: a...@kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
Requesting an ACK from the ARM SoC maintainers on this patch.
---
 arch/arm/boot/dts/hrefprev60.dts | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
index eec29c4..0c2b975 100644
--- a/arch/arm/boot/dts/hrefprev60.dts
+++ b/arch/arm/boot/dts/hrefprev60.dts
@@ -25,6 +25,14 @@
};
 
soc-u9500 {
+   prcmu@80157000 {
+   ab8500@5 {
+   ab8500-gpio {
+   compatible = stericsson,ab8500-gpio;
+   };
+   };
+   };
+
i2c@80004000 {
tps61052@33 {
compatible = tps61052;
-- 
1.7.11.3

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/