Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
Gustavo A. R. Silva wrote: > Absolutely. We'll never know how many bugs this will catch in the > future decades of kernel development, before the code is even > committed/submitted. :) A little bit OT here, but what are the plans for Geode in general as there was discussion around the fact that Debian will be one of the last platforms to drop i386 arch support. Thank you
Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
Hi Sam, On Sun, Nov 22, 2020 at 11:05:40PM +0100, Sam Ravnborg wrote: > Hi Gustavo, > On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva > > Thanks, applied this and the following patch to drm-misc-next. > Looks forward to have this warning enabled. > > One can only wonder how many hours will be saved by lettting the > compiler tell you a break is missing. This is the kind of bugs you can > stare you blind at. Absolutely. We'll never know how many bugs this will catch in the future decades of kernel development, before the code is even committed/submitted. :) Thanks! -- Gustavo
Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
Hi Gustavo, On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Thanks, applied this and the following patch to drm-misc-next. Looks forward to have this warning enabled. One can only wonder how many hours will be saved by lettting the compiler tell you a break is missing. This is the kind of bugs you can stare you blind at. Sam
[PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/video/fbdev/geode/lxfb_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/geode/lxfb_ops.c b/drivers/video/fbdev/geode/lxfb_ops.c index b3a041fce570..32baaf59fcf7 100644 --- a/drivers/video/fbdev/geode/lxfb_ops.c +++ b/drivers/video/fbdev/geode/lxfb_ops.c @@ -682,6 +682,7 @@ static void lx_restore_display_ctlr(struct lxfb_par *par) case DC_DV_CTL: /* set all ram to dirty */ write_dc(par, i, par->dc[i] | DC_DV_CTL_CLEAR_DV_RAM); + break; case DC_RSVD_1: case DC_RSVD_2: -- 2.27.0
