Re: [PATCH 15/57] staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header
On Thu, Apr 15, 2021 at 09:31:34AM +0100, Lee Jones wrote:
> On Thu, 15 Apr 2021, Fabio Aiuto wrote:
>
> > On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > from drivers/staging/rtl8188eu/core/rtw_security.c:10:
> > > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > > parameter or member 'p1k' not described in 'phase1'
> > > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > > parameter or member 'tk' not described in 'phase1'
> > > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > > parameter or member 'ta' not described in 'phase1'
> > > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > > parameter or member 'rc4key' not described in 'phase2'
> > > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > > parameter or member 'tk' not described in 'phase2'
> > > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > > parameter or member 'p1k' not described in 'phase2'
> > > drivers/staging/rtl8723bs/core/rtw_security.c:1937: warning: This
> > > comment starts with '/**', but isn't a kernel-doc comment. Refer
> > > Documentation/doc-guide/kernel-doc.rst
> > >
> > > Cc: Greg Kroah-Hartman
> > > Cc: linux-stag...@lists.linux.dev
> > > Signed-off-by: Lee Jones
> > > ---
> > > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c
> > > b/drivers/staging/rtl8723bs/core/rtw_security.c
> > > index 9587d89a6b24e..60b724729900e 100644
> > > --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> > > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> > > @@ -1921,7 +1921,7 @@ const u8 rcons[] = {
> > > /* for 128-bit blocks, Rijndael never uses more than 10 rcon values */
> > > };
> > >
> > > -/**
> > > +/*
> > > * Expand the cipher key into the encryption key schedule.
> > > *
> > > * @return the number of rounds for the given cipher key size.
> >
> > Hi,
> >
> > did you mean 'demote' in subject line?
>
> I did. Did I spell it incorrectly?
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
that's good, sorry for noise.
thank you,
fabio
Re: [PATCH 15/57] staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header
On Thu, 15 Apr 2021, Fabio Aiuto wrote:
> On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > from drivers/staging/rtl8188eu/core/rtw_security.c:10:
> > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > parameter or member 'p1k' not described in 'phase1'
> > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > parameter or member 'tk' not described in 'phase1'
> > drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> > parameter or member 'ta' not described in 'phase1'
> > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > parameter or member 'rc4key' not described in 'phase2'
> > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > parameter or member 'tk' not described in 'phase2'
> > drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> > parameter or member 'p1k' not described in 'phase2'
> > drivers/staging/rtl8723bs/core/rtw_security.c:1937: warning: This comment
> > starts with '/**', but isn't a kernel-doc comment. Refer
> > Documentation/doc-guide/kernel-doc.rst
> >
> > Cc: Greg Kroah-Hartman
> > Cc: linux-stag...@lists.linux.dev
> > Signed-off-by: Lee Jones
> > ---
> > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c
> > b/drivers/staging/rtl8723bs/core/rtw_security.c
> > index 9587d89a6b24e..60b724729900e 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> > @@ -1921,7 +1921,7 @@ const u8 rcons[] = {
> > /* for 128-bit blocks, Rijndael never uses more than 10 rcon values */
> > };
> >
> > -/**
> > +/*
> > * Expand the cipher key into the encryption key schedule.
> > *
> > * @return the number of rounds for the given cipher key size.
>
> Hi,
>
> did you mean 'demote' in subject line?
I did. Did I spell it incorrectly?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 15/57] staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header
On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> from drivers/staging/rtl8188eu/core/rtw_security.c:10:
> drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> parameter or member 'p1k' not described in 'phase1'
> drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> parameter or member 'tk' not described in 'phase1'
> drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> parameter or member 'ta' not described in 'phase1'
> drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> parameter or member 'rc4key' not described in 'phase2'
> drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> parameter or member 'tk' not described in 'phase2'
> drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function
> parameter or member 'p1k' not described in 'phase2'
> drivers/staging/rtl8723bs/core/rtw_security.c:1937: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Cc: Greg Kroah-Hartman
> Cc: linux-stag...@lists.linux.dev
> Signed-off-by: Lee Jones
> ---
> drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c
> b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 9587d89a6b24e..60b724729900e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -1921,7 +1921,7 @@ const u8 rcons[] = {
> /* for 128-bit blocks, Rijndael never uses more than 10 rcon values */
> };
>
> -/**
> +/*
> * Expand the cipher key into the encryption key schedule.
> *
> * @return the number of rounds for the given cipher key size.
> --
> 2.27.0
>
>
Hi,
did you mean 'demote' in subject line?
thank you,
fabio
[PATCH 15/57] staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header
Fixes the following W=1 kernel build warning(s):
from drivers/staging/rtl8188eu/core/rtw_security.c:10:
drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function parameter
or member 'p1k' not described in 'phase1'
drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function parameter
or member 'tk' not described in 'phase1'
drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function parameter
or member 'ta' not described in 'phase1'
drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function parameter
or member 'rc4key' not described in 'phase2'
drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function parameter
or member 'tk' not described in 'phase2'
drivers/staging/rtl8188eu/core/rtw_security.c:517: warning: Function parameter
or member 'p1k' not described in 'phase2'
drivers/staging/rtl8723bs/core/rtw_security.c:1937: warning: This comment
starts with '/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c
b/drivers/staging/rtl8723bs/core/rtw_security.c
index 9587d89a6b24e..60b724729900e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -1921,7 +1921,7 @@ const u8 rcons[] = {
/* for 128-bit blocks, Rijndael never uses more than 10 rcon values */
};
-/**
+/*
* Expand the cipher key into the encryption key schedule.
*
* @return the number of rounds for the given cipher key size.
--
2.27.0
